[INFO] fetching crate ppca 0.5.0... [INFO] checking ppca-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ppca 0.5.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate ppca 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate ppca 0.5.0 [INFO] finished tweaking crates.io crate ppca 0.5.0 [INFO] tweaked toml for crates.io crate ppca 0.5.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 45 packages to latest compatible versions [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding nalgebra v0.32.6 (latest: v0.33.0) [INFO] [stderr] Adding ndarray v0.15.6 (latest: v0.16.1) [INFO] [stderr] Adding ordered-float v3.9.2 (latest: v4.2.2) [INFO] [stderr] Adding simba v0.8.1 (latest: v0.9.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 61619e5feb5a970366828bd9bfa7a86ae70705f874b22316b5932768c5b00c48 [INFO] running `Command { std: "docker" "start" "-a" "61619e5feb5a970366828bd9bfa7a86ae70705f874b22316b5932768c5b00c48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "61619e5feb5a970366828bd9bfa7a86ae70705f874b22316b5932768c5b00c48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "61619e5feb5a970366828bd9bfa7a86ae70705f874b22316b5932768c5b00c48", kill_on_drop: false }` [INFO] [stdout] 61619e5feb5a970366828bd9bfa7a86ae70705f874b22316b5932768c5b00c48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 322d7f6ad8e2bd124a436db5358cf71fe233792c39e533d6ada80ed47837144d [INFO] running `Command { std: "docker" "start" "-a" "322d7f6ad8e2bd124a436db5358cf71fe233792c39e533d6ada80ed47837144d", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking safe_arch v0.7.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking wide v0.7.28 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking ordered-float v3.9.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling nalgebra-macros v0.2.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Checking nalgebra v0.32.6 [INFO] [stderr] Checking ppca v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mix.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn new(models: Vec, log_weights: DVector) -> PPCAMix { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | PPCAMix(Arc::new(PPCAMixInner { [INFO] [stdout] | _________________^ [INFO] [stdout] 67 | | output_size: unique_sizes[0], [INFO] [stdout] 68 | | models, [INFO] [stdout] 69 | | log_weights: robust_log_softmax(log_weights), [INFO] [stdout] 70 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mix.rs:332:17 [INFO] [stdout] | [INFO] [stdout] 297 | let (iterated_models, log_weights): (Vec<_>, Vec) = self [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 332 | PPCAMix(Arc::new(PPCAMixInner { [INFO] [stdout] | _________________^ [INFO] [stdout] 333 | | output_size: self.0.output_size, [INFO] [stdout] 334 | | models: iterated_models, [INFO] [stdout] 335 | | log_weights: robust_log_softmax(log_weights.into()), [INFO] [stdout] 336 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mix.rs:328:18 [INFO] [stdout] | [INFO] [stdout] 326 | let dataset = dataset.with_weights(unnorm_posteriors); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 327 | [INFO] [stdout] 328 | (model.iterate_with_prior(&dataset, prior), logsum_posteriors) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ppca_model.rs:386:19 [INFO] [stdout] | [INFO] [stdout] 278 | let inferred = self.infer(dataset); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | PPCAModel(Arc::new(PPCAModelInner { [INFO] [stdout] | ___________________^ [INFO] [stdout] 387 | | output_covariance: OutputCovariance { [INFO] [stdout] 388 | | transform: Cow::Owned(new_transform), [INFO] [stdout] 389 | | isotropic_noise: isotropic_noise_sq.sqrt(), [INFO] [stdout] 390 | | }, [INFO] [stdout] 391 | | mean: new_mean, [INFO] [stdout] 392 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub(crate) fn filter<'a, I: IntoIterator>(&'a self, it: I) -> impl 'a + Iterator [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | / self.0 [INFO] [stdout] 46 | | .iter() [INFO] [stdout] 47 | | .zip(it) [INFO] [stdout] 48 | | .filter(|(selected, _)| *selected) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mix.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn new(models: Vec, log_weights: DVector) -> PPCAMix { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | PPCAMix(Arc::new(PPCAMixInner { [INFO] [stdout] | _________________^ [INFO] [stdout] 67 | | output_size: unique_sizes[0], [INFO] [stdout] 68 | | models, [INFO] [stdout] 69 | | log_weights: robust_log_softmax(log_weights), [INFO] [stdout] 70 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ppca` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mix.rs:332:17 [INFO] [stdout] | [INFO] [stdout] 297 | let (iterated_models, log_weights): (Vec<_>, Vec) = self [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 332 | PPCAMix(Arc::new(PPCAMixInner { [INFO] [stdout] | _________________^ [INFO] [stdout] 333 | | output_size: self.0.output_size, [INFO] [stdout] 334 | | models: iterated_models, [INFO] [stdout] 335 | | log_weights: robust_log_softmax(log_weights.into()), [INFO] [stdout] 336 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mix.rs:328:18 [INFO] [stdout] | [INFO] [stdout] 326 | let dataset = dataset.with_weights(unnorm_posteriors); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 327 | [INFO] [stdout] 328 | (model.iterate_with_prior(&dataset, prior), logsum_posteriors) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ppca_model.rs:386:19 [INFO] [stdout] | [INFO] [stdout] 278 | let inferred = self.infer(dataset); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 386 | PPCAModel(Arc::new(PPCAModelInner { [INFO] [stdout] | ___________________^ [INFO] [stdout] 387 | | output_covariance: OutputCovariance { [INFO] [stdout] 388 | | transform: Cow::Owned(new_transform), [INFO] [stdout] 389 | | isotropic_noise: isotropic_noise_sq.sqrt(), [INFO] [stdout] 390 | | }, [INFO] [stdout] 391 | | mean: new_mean, [INFO] [stdout] 392 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub(crate) fn filter<'a, I: IntoIterator>(&'a self, it: I) -> impl 'a + Iterator [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | / self.0 [INFO] [stdout] 46 | | .iter() [INFO] [stdout] 47 | | .zip(it) [INFO] [stdout] 48 | | .filter(|(selected, _)| *selected) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ppca` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "322d7f6ad8e2bd124a436db5358cf71fe233792c39e533d6ada80ed47837144d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "322d7f6ad8e2bd124a436db5358cf71fe233792c39e533d6ada80ed47837144d", kill_on_drop: false }` [INFO] [stdout] 322d7f6ad8e2bd124a436db5358cf71fe233792c39e533d6ada80ed47837144d