[INFO] fetching crate postgres_query_macro 0.3.1... [INFO] checking postgres_query_macro-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate postgres_query_macro 0.3.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate postgres_query_macro 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate postgres_query_macro 0.3.1 [INFO] finished tweaking crates.io crate postgres_query_macro 0.3.1 [INFO] tweaked toml for crates.io crate postgres_query_macro 0.3.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ea0af6d39940a21ea491dac624c6132353713fc99bb85c1b1acf5b052c925253 [INFO] running `Command { std: "docker" "start" "-a" "ea0af6d39940a21ea491dac624c6132353713fc99bb85c1b1acf5b052c925253", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ea0af6d39940a21ea491dac624c6132353713fc99bb85c1b1acf5b052c925253", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea0af6d39940a21ea491dac624c6132353713fc99bb85c1b1acf5b052c925253", kill_on_drop: false }` [INFO] [stdout] ea0af6d39940a21ea491dac624c6132353713fc99bb85c1b1acf5b052c925253 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 679fca5f394809c5e601ee192c1bd683e1f9ba53aac0e1e6edd613023d53dc42 [INFO] running `Command { std: "docker" "start" "-a" "679fca5f394809c5e601ee192c1bd683e1f9ba53aac0e1e6edd613023d53dc42", kill_on_drop: false }` [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v1.0.109 [INFO] [stderr] Checking postgres_query_macro v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_sql_row.rs:252:15 [INFO] [stdout] | [INFO] [stdout] 252 | keys: props [INFO] [stdout] | _______________^ [INFO] [stdout] 253 | | .iter() [INFO] [stdout] 254 | | .filter_map(|prop| match prop.attrs.key { [INFO] [stdout] 255 | | Some(_) => Some((prop.ident.clone(), prop.ty.clone())), [INFO] [stdout] 256 | | None => None, [INFO] [stdout] 257 | | }) [INFO] [stdout] 258 | | .collect(), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_sql_row.rs:259:22 [INFO] [stdout] | [INFO] [stdout] 259 | collections: props [INFO] [stdout] | ______________________^ [INFO] [stdout] 260 | | .iter() [INFO] [stdout] 261 | | .filter_map(|prop| match prop.attrs.merge { [INFO] [stdout] 262 | | Some(_) => Some((prop.ident.clone(), prop.ty.clone())), [INFO] [stdout] 263 | | None => None, [INFO] [stdout] 264 | | }) [INFO] [stdout] 265 | | .collect(), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 23 | let mut parameters = Punctuated::::parse_terminated(input)?.into_iter(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | [INFO] [stdout] 25 | let text = parameters [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let arguments: Vec<_> = parameters.map(expr_to_argument).collect::>()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | Ok(QueryInput { text, arguments }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_sql_row.rs:252:15 [INFO] [stdout] | [INFO] [stdout] 252 | keys: props [INFO] [stdout] | _______________^ [INFO] [stdout] 253 | | .iter() [INFO] [stdout] 254 | | .filter_map(|prop| match prop.attrs.key { [INFO] [stdout] 255 | | Some(_) => Some((prop.ident.clone(), prop.ty.clone())), [INFO] [stdout] 256 | | None => None, [INFO] [stdout] 257 | | }) [INFO] [stdout] 258 | | .collect(), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/from_sql_row.rs:259:22 [INFO] [stdout] | [INFO] [stdout] 259 | collections: props [INFO] [stdout] | ______________________^ [INFO] [stdout] 260 | | .iter() [INFO] [stdout] 261 | | .filter_map(|prop| match prop.attrs.merge { [INFO] [stdout] 262 | | Some(_) => Some((prop.ident.clone(), prop.ty.clone())), [INFO] [stdout] 263 | | None => None, [INFO] [stdout] 264 | | }) [INFO] [stdout] 265 | | .collect(), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/query.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 23 | let mut parameters = Punctuated::::parse_terminated(input)?.into_iter(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | [INFO] [stdout] 25 | let text = parameters [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let arguments: Vec<_> = parameters.map(expr_to_argument).collect::>()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | Ok(QueryInput { text, arguments }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `postgres_query_macro` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `postgres_query_macro` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "679fca5f394809c5e601ee192c1bd683e1f9ba53aac0e1e6edd613023d53dc42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "679fca5f394809c5e601ee192c1bd683e1f9ba53aac0e1e6edd613023d53dc42", kill_on_drop: false }` [INFO] [stdout] 679fca5f394809c5e601ee192c1bd683e1f9ba53aac0e1e6edd613023d53dc42