[INFO] fetching crate postgres-derive 0.4.5... [INFO] checking postgres-derive-0.4.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate postgres-derive 0.4.5 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate postgres-derive 0.4.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate postgres-derive 0.4.5 [INFO] finished tweaking crates.io crate postgres-derive 0.4.5 [INFO] tweaked toml for crates.io crate postgres-derive 0.4.5 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f60d9d89b0c7e54e160de2420ef61ff771bfd155e0e733ca29e70ec9bec1f82a [INFO] running `Command { std: "docker" "start" "-a" "f60d9d89b0c7e54e160de2420ef61ff771bfd155e0e733ca29e70ec9bec1f82a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f60d9d89b0c7e54e160de2420ef61ff771bfd155e0e733ca29e70ec9bec1f82a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f60d9d89b0c7e54e160de2420ef61ff771bfd155e0e733ca29e70ec9bec1f82a", kill_on_drop: false }` [INFO] [stdout] f60d9d89b0c7e54e160de2420ef61ff771bfd155e0e733ca29e70ec9bec1f82a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 983ac164ce8937f05ccf4852e76d03cce4e675c9a1b7b4982c7b72eef29931ac [INFO] running `Command { std: "docker" "start" "-a" "983ac164ce8937f05ccf4852e76d03cce4e675c9a1b7b4982c7b72eef29931ac", kill_on_drop: false }` [INFO] [stderr] Checking heck v0.4.1 [INFO] [stderr] Checking postgres-derive v0.4.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn derive_tosql(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let input = parse_macro_input!(input); [INFO] [stdout] | ----- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | [INFO] [stdout] 21 | / tosql::expand_derive_tosql(input) [INFO] [stdout] 22 | | .unwrap_or_else(|e| e.to_compile_error()) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn derive_fromsql(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let input = parse_macro_input!(input); [INFO] [stdout] | ----- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | [INFO] [stdout] 30 | / fromsql::expand_derive_fromsql(input) [INFO] [stdout] 31 | | .unwrap_or_else(|e| e.to_compile_error()) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/composites.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 18 | let ident = raw.ident.as_ref().unwrap().clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(Field { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | name, [INFO] [stdout] 36 | | ident, [INFO] [stdout] 37 | | type_: raw.ty.clone(), [INFO] [stdout] 38 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fromsql.rs:260:27 [INFO] [stdout] | [INFO] [stdout] 250 | let mut path_segment: PathSegment = Ident::new("FromSql", Span::call_site()).into(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | let mut seg_args = Punctuated::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | TypeParamBound::Trait(TraitBound { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 261 | | lifetimes: None, [INFO] [stdout] 262 | | modifier: TraitBoundModifier::None, [INFO] [stdout] 263 | | paren_token: None, [INFO] [stdout] 264 | | path: new_derive_path(path_segment), [INFO] [stdout] 265 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn derive_tosql(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let input = parse_macro_input!(input); [INFO] [stdout] | ----- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | [INFO] [stdout] 21 | / tosql::expand_derive_tosql(input) [INFO] [stdout] 22 | | .unwrap_or_else(|e| e.to_compile_error()) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn derive_fromsql(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let input = parse_macro_input!(input); [INFO] [stdout] | ----- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | [INFO] [stdout] 30 | / fromsql::expand_derive_fromsql(input) [INFO] [stdout] 31 | | .unwrap_or_else(|e| e.to_compile_error()) [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/composites.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 18 | let ident = raw.ident.as_ref().unwrap().clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(Field { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | name, [INFO] [stdout] 36 | | ident, [INFO] [stdout] 37 | | type_: raw.ty.clone(), [INFO] [stdout] 38 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fromsql.rs:260:27 [INFO] [stdout] | [INFO] [stdout] 250 | let mut path_segment: PathSegment = Ident::new("FromSql", Span::call_site()).into(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | let mut seg_args = Punctuated::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | TypeParamBound::Trait(TraitBound { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 261 | | lifetimes: None, [INFO] [stdout] 262 | | modifier: TraitBoundModifier::None, [INFO] [stdout] 263 | | paren_token: None, [INFO] [stdout] 264 | | path: new_derive_path(path_segment), [INFO] [stdout] 265 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `postgres-derive` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `postgres-derive` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "983ac164ce8937f05ccf4852e76d03cce4e675c9a1b7b4982c7b72eef29931ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "983ac164ce8937f05ccf4852e76d03cce4e675c9a1b7b4982c7b72eef29931ac", kill_on_drop: false }` [INFO] [stdout] 983ac164ce8937f05ccf4852e76d03cce4e675c9a1b7b4982c7b72eef29931ac