[INFO] fetching crate portmatching 0.4.0-rc.1... [INFO] checking portmatching-0.4.0-rc.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate portmatching 0.4.0-rc.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate portmatching 0.4.0-rc.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate portmatching 0.4.0-rc.1 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate portmatching 0.4.0-rc.1 [INFO] tweaked toml for crates.io crate portmatching 0.4.0-rc.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate portmatching 0.4.0-rc.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 678f8fa476ae952bad05454619ec8a7adb9731e5d70b7fac986fb17cda09ed4d [INFO] running `Command { std: "docker" "start" "-a" "678f8fa476ae952bad05454619ec8a7adb9731e5d70b7fac986fb17cda09ed4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "678f8fa476ae952bad05454619ec8a7adb9731e5d70b7fac986fb17cda09ed4d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "678f8fa476ae952bad05454619ec8a7adb9731e5d70b7fac986fb17cda09ed4d", kill_on_drop: false }` [INFO] [stdout] 678f8fa476ae952bad05454619ec8a7adb9731e5d70b7fac986fb17cda09ed4d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a3612d816fc815b0a9984a87a7e881ae3b6b0c181f21ccc16d9070aa40950fd7 [INFO] running `Command { std: "docker" "start" "-a" "a3612d816fc815b0a9984a87a7e881ae3b6b0c181f21ccc16d9070aa40950fd7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling semver v1.0.21 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling aho-corasick v1.1.2 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling toml_datetime v0.6.6 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling rstest_macros v0.21.0 [INFO] [stderr] Compiling indexmap v2.2.3 [INFO] [stderr] Checking half v2.3.1 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking bimap v0.6.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking union-find v0.4.2 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking similar v2.5.0 [INFO] [stderr] Checking context-iterators v0.2.0 [INFO] [stderr] Checking tempfile v3.10.0 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking proptest v1.4.0 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling delegate v0.12.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rstest v0.21.0 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stderr] Checking portmatching v0.4.0-rc.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking portgraph v0.12.2 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/automaton/builder.rs:59:22 [INFO] [stdout] | [INFO] [stdout] 57 | fn with_indexing_scheme(host_indexing: I) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Self { [INFO] [stdout] 59 | matcher: ConstraintAutomaton::with_indexing_scheme(host_indexing), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/automaton/builder.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 57 | fn with_indexing_scheme(host_indexing: I) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | make_det: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/automaton/builder.rs:62:29 [INFO] [stdout] | [INFO] [stdout] 57 | fn with_indexing_scheme(host_indexing: I) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | recently_added: HashSet::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/automaton/builder.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn set_det_heuristic(self, make_det: impl FnMut(&[&C]) -> bool + 'c) -> Self { [INFO] [stdout] | ---- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | make_det: Some(Box::new(make_det)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/automaton/builder.rs:87:60 [INFO] [stdout] | [INFO] [stdout] 83 | pub fn from_constraints(patterns: impl IntoIterator>) -> Self [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | Self::from_constraints_with_index_scheme(patterns, I::default()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/automaton/builder.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 93 | patterns: impl IntoIterator>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | host_indexing: I, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | ) -> Self { [INFO] [stdout] 96 | patterns.into_iter().fold( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/automaton/builder.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 93 | patterns: impl IntoIterator>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | host_indexing: I, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | Self::with_indexing_scheme(host_indexing), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/automaton/builder.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 119 | let siblings = { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | let mut no_path_siblings = HashSet::from_iter([node]); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | / no_path_siblings [INFO] [stdout] 144 | | .into_iter() [INFO] [stdout] 145 | | .map_into() [INFO] [stdout] 146 | | .filter(|&n| self.matcher.state_tuple(n) == state_tuple) [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/automaton/builder.rs:221:46 [INFO] [stdout] | [INFO] [stdout] 221 | .filter_map(|(cons, child)| Some((cons?, child))) [INFO] [stdout] | ------------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/automaton/builder.rs:414:36 [INFO] [stdout] | [INFO] [stdout] 413 | fn add_constraint(&mut self, state: StateID, constraint: C) -> StateID { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 414 | self.add_transition(state, Some(constraint)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/automaton/builder/modify.rs:69:37 [INFO] [stdout] | [INFO] [stdout] 67 | constraint: C, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | ) -> StateID { [INFO] [stdout] 69 | self.add_transition(parent, Some(constraint)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/automaton/traversal.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 30 | state: TraversalState, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let mut all_bindings = self [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | all_bindings.into_iter().flat_map(move |bindings| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/automaton/traversal.rs:88:24 [INFO] [stdout] | [INFO] [stdout] 61 | all_bindings.into_iter().flat_map(move |bindings| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let bindings_clone = bindings.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let mut valid_non_fails = non_fails [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | .chain(fail_transition.map(|state_id| TraversalState { state_id, bindings })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/automaton/traversal.rs:151:37 [INFO] [stdout] | [INFO] [stdout] 151 | .map(|&id| (id, state.bindings.clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/indexing/binding_builder.rs:31:27 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(keys: impl IntoIterator, bindings: M) -> Self { [INFO] [stdout] | -------------------------------------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | exclude_keys: HashSet::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/indexing/binding_builder.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 54 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | key: M::Key, [INFO] [stdout] 56 | values: impl IntoIterator, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | / values [INFO] [stdout] 62 | | .into_iter() [INFO] [stdout] 63 | | .map(|value| { [INFO] [stdout] 64 | | let mut new_self = self.clone(); [INFO] [stdout] 65 | | new_self.bindings.bind(key, value)?; [INFO] [stdout] 66 | | Ok(new_self) [INFO] [stdout] 67 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher/many_patterns/naive.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn from_patterns<'p, P>(patterns: impl IntoIterator) -> Self [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | matchers: patterns [INFO] [stdout] | _______________________^ [INFO] [stdout] 30 | | .into_iter() [INFO] [stdout] 31 | | .map(|p| SinglePatternMatcher::from_pattern(p)) [INFO] [stdout] 32 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher/many_patterns/naive.rs:46:23 [INFO] [stdout] | [INFO] [stdout] 38 | patterns: impl IntoIterator, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | host_indexing: I, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | matchers: patterns [INFO] [stdout] | _______________________^ [INFO] [stdout] 47 | | .into_iter() [INFO] [stdout] 48 | | .map(|p| SinglePatternMatcher::from_pattern_with_indexing(p, host_indexing.clone())) [INFO] [stdout] 49 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher/many_patterns/naive.rs:48:78 [INFO] [stdout] | [INFO] [stdout] 48 | .map(|p| SinglePatternMatcher::from_pattern_with_indexing(p, host_indexing.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher/many_patterns/naive.rs:86:23 [INFO] [stdout] | [INFO] [stdout] 84 | fn from_iter>>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Self { [INFO] [stdout] 86 | matchers: iter.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher/single_pattern.rs:52:28 [INFO] [stdout] | [INFO] [stdout] 49 | let constraints = pattern.to_constraint_vec(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | host_indexing: I::default(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher/single_pattern.rs:59:26 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn from_pattern_with_indexing(pattern: &impl Pattern, indexing: I) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Self { [INFO] [stdout] 59 | constraints: pattern.to_constraint_vec(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matcher/single_pattern.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 101 | .flat_map(|bindings| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | / self.host_indexing [INFO] [stdout] 103 | | .try_bind_all(bindings, keys.to_vec(), host) [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutex_tree.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 134 | constraints: impl IntoIterator + 'a, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | ) -> impl Iterator + 'a { [INFO] [stdout] 136 | / constraints [INFO] [stdout] 137 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutex_tree/build.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 63 | constraints: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | is_mutex: impl Fn(&C, &C) -> bool, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | ) -> Self { [INFO] [stdout] 66 | let mut constraints = constraints.into_iter(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let Some((first, first_ind)) = constraints.next() else { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let constraints = constraints [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | [(first, vec![first_ind])].into_iter().chain(constraints), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/toposort.rs:53:22 [INFO] [stdout] | [INFO] [stdout] 50 | fn from_iter>(iter: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let to_visit_next = iter.into_iter().collect_vec(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | Self { [INFO] [stdout] 53 | visited: HashSet::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/unique_stack.rs:95:27 [INFO] [stdout] | [INFO] [stdout] 95 | .map(|index| &self.elements[index].as_ref().unwrap().value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 27 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `portmatching` (lib) due to 28 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a3612d816fc815b0a9984a87a7e881ae3b6b0c181f21ccc16d9070aa40950fd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a3612d816fc815b0a9984a87a7e881ae3b6b0c181f21ccc16d9070aa40950fd7", kill_on_drop: false }` [INFO] [stdout] a3612d816fc815b0a9984a87a7e881ae3b6b0c181f21ccc16d9070aa40950fd7