[INFO] fetching crate portalgun 0.2.4... [INFO] checking portalgun-0.2.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate portalgun 0.2.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate portalgun 0.2.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate portalgun 0.2.4 [INFO] finished tweaking crates.io crate portalgun 0.2.4 [INFO] tweaked toml for crates.io crate portalgun 0.2.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate portalgun 0.2.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1b7d9fedbbb5c75b961568622b33a04e17936fcc965af341928cf0c0b9ce406d [INFO] running `Command { std: "docker" "start" "-a" "1b7d9fedbbb5c75b961568622b33a04e17936fcc965af341928cf0c0b9ce406d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1b7d9fedbbb5c75b961568622b33a04e17936fcc965af341928cf0c0b9ce406d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b7d9fedbbb5c75b961568622b33a04e17936fcc965af341928cf0c0b9ce406d", kill_on_drop: false }` [INFO] [stdout] 1b7d9fedbbb5c75b961568622b33a04e17936fcc965af341928cf0c0b9ce406d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 312a8146e8452a9d9bee87198f661ae8a44df0e2856bfec4a89b73b33cf37397 [INFO] running `Command { std: "docker" "start" "-a" "312a8146e8452a9d9bee87198f661ae8a44df0e2856bfec4a89b73b33cf37397", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Compiling rustls v0.21.10 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling rustix v0.38.30 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking http v0.2.11 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking indexmap v2.2.1 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling multer v2.1.0 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling mime v0.3.17 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking webpki-roots v0.25.3 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking iana-time-zone v0.1.59 [INFO] [stderr] Compiling semver v1.0.21 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking headers v0.3.9 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking askama_escape v0.10.3 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Compiling ring v0.17.7 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Compiling askama_parser v0.2.1 [INFO] [stderr] Compiling cli-table-derive v0.4.5 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking indicatif v0.15.0 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling pin-project-internal v1.1.4 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.4 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking rustls-webpki v0.100.3 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Checking webpki-roots v0.23.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking h2 v0.3.24 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking uuid v1.7.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking serde_path_to_error v0.1.15 [INFO] [stderr] Checking chrono v0.4.33 [INFO] [stderr] Checking os_info v3.7.0 [INFO] [stderr] Checking toml_edit v0.21.0 [INFO] [stderr] Checking cli-table v0.4.7 [INFO] [stderr] Compiling basic-toml v0.1.8 [INFO] [stderr] Checking portalgun_lib v0.2.2 [INFO] [stderr] Checking tungstenite v0.20.1 [INFO] [stderr] Checking toml v0.8.8 [INFO] [stderr] Checking tokio-tungstenite v0.20.1 [INFO] [stderr] Compiling askama_derive v0.12.5 [INFO] [stderr] Checking human-panic v1.2.3 [INFO] [stderr] Checking askama v0.12.1 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking warp v0.3.6 [INFO] [stderr] Checking reqwest v0.11.23 [INFO] [stderr] Checking oauth2 v4.4.2 [INFO] [stderr] Checking portalgun v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/main.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | setup_panic!(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `$crate::setup_panic` which comes from the expansion of the macro `setup_panic` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/main.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | setup_panic!(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `$crate::setup_panic` which comes from the expansion of the macro `setup_panic` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/main.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | setup_panic!(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `$crate::setup_panic` which comes from the expansion of the macro `setup_panic` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/main.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | setup_panic!(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `$crate::setup_panic` which comes from the expansion of the macro `setup_panic` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `tokio_rustls::rustls::RootCertStore::add_server_trust_anchors`: Please use `add_trust_anchors` instead [INFO] [stdout] --> src/local.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 48 | root_cert_store.add_server_trust_anchors(webpki_roots::TLS_SERVER_ROOTS.0.iter().map( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `tokio_rustls::rustls::RootCertStore::add_server_trust_anchors`: Please use `add_trust_anchors` instead [INFO] [stdout] --> src/local.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 48 | root_cert_store.add_server_trust_anchors(webpki_roots::TLS_SERVER_ROOTS.0.iter().map( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `is_replay` is never read [INFO] [stdout] --> src/introspect/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct Request { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 22 | is_replay: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Request` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/introspect/mod.rs:105:75 [INFO] [stdout] | [INFO] [stdout] 102 | let (request_tx, request_rx) = unbounded::>(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let (response_tx, response_rx) = unbounded::>(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | [INFO] [stdout] 105 | tokio::spawn(async move { collect_stream(id, request_rx, response_rx).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/introspect/mod.rs:306:9 [INFO] [stdout] | [INFO] [stdout] 303 | fn into_response(self) -> warp::reply::Response { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | / warp::http::Response::builder() [INFO] [stdout] 307 | | .status(warp::http::StatusCode::OK) [INFO] [stdout] 308 | | .header(warp::http::header::CONTENT_TYPE, "text/html") [INFO] [stdout] 309 | | .body(res.into()) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `is_replay` is never read [INFO] [stdout] --> src/introspect/mod.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct Request { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 22 | is_replay: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Request` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `portalgun` (bin "portalgun" test) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/introspect/mod.rs:105:75 [INFO] [stdout] | [INFO] [stdout] 102 | let (request_tx, request_rx) = unbounded::>(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let (response_tx, response_rx) = unbounded::>(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | [INFO] [stdout] 105 | tokio::spawn(async move { collect_stream(id, request_rx, response_rx).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/introspect/mod.rs:306:9 [INFO] [stdout] | [INFO] [stdout] 303 | fn into_response(self) -> warp::reply::Response { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | / warp::http::Response::builder() [INFO] [stdout] 307 | | .status(warp::http::StatusCode::OK) [INFO] [stdout] 308 | | .header(warp::http::header::CONTENT_TYPE, "text/html") [INFO] [stdout] 309 | | .body(res.into()) [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `portalgun` (bin "portalgun") due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "312a8146e8452a9d9bee87198f661ae8a44df0e2856bfec4a89b73b33cf37397", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "312a8146e8452a9d9bee87198f661ae8a44df0e2856bfec4a89b73b33cf37397", kill_on_drop: false }` [INFO] [stdout] 312a8146e8452a9d9bee87198f661ae8a44df0e2856bfec4a89b73b33cf37397