[INFO] fetching crate pore 0.1.17... [INFO] checking pore-0.1.17 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pore 0.1.17 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate pore 0.1.17 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pore 0.1.17 [INFO] finished tweaking crates.io crate pore 0.1.17 [INFO] tweaked toml for crates.io crate pore 0.1.17 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate pore 0.1.17 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6460bb75441e929bf5ae01dacaf7232dc7f3884bfabad564227479bf3ae26180 [INFO] running `Command { std: "docker" "start" "-a" "6460bb75441e929bf5ae01dacaf7232dc7f3884bfabad564227479bf3ae26180", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6460bb75441e929bf5ae01dacaf7232dc7f3884bfabad564227479bf3ae26180", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6460bb75441e929bf5ae01dacaf7232dc7f3884bfabad564227479bf3ae26180", kill_on_drop: false }` [INFO] [stdout] 6460bb75441e929bf5ae01dacaf7232dc7f3884bfabad564227479bf3ae26180 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b39aa31a31a98ba9e4b85ca3a3ec8b32348b39b188b1126324949edee7218ca8 [INFO] running `Command { std: "docker" "start" "-a" "b39aa31a31a98ba9e4b85ca3a3ec8b32348b39b188b1126324949edee7218ca8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling futures-core v0.3.29 [INFO] [stderr] Compiling serde v1.0.192 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling futures-task v0.3.29 [INFO] [stderr] Compiling futures-channel v0.3.29 [INFO] [stderr] Checking futures-sink v0.3.29 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling futures-util v0.3.29 [INFO] [stderr] Checking futures-io v0.3.29 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling openssl v0.10.59 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking quick-xml v0.17.2 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking hashbrown v0.14.2 [INFO] [stderr] Checking clap_builder v4.4.7 [INFO] [stderr] Checking base64 v0.21.5 [INFO] [stderr] Checking iana-time-zone v0.1.58 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking joinery v3.1.0 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Compiling indoc v1.0.9 [INFO] [stderr] Checking version-compare v0.1.1 [INFO] [stderr] Checking minidom v0.12.0 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.9 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking gettid v0.1.2 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Compiling jobserver v0.1.27 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking shellexpand v2.1.2 [INFO] [stderr] Checking filetime v0.2.22 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking tokio v1.33.0 [INFO] [stderr] Checking url v2.4.1 [INFO] [stderr] Compiling openssl-sys v0.9.95 [INFO] [stderr] Compiling libz-sys v1.1.12 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking indicatif v0.16.2 [INFO] [stderr] Compiling serde_derive v1.0.192 [INFO] [stderr] Compiling futures-macro v0.3.29 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking clap v4.4.7 [INFO] [stderr] Checking h2 v0.3.21 [INFO] [stderr] Checking futures-executor v0.3.29 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking futures v0.3.29 [INFO] [stderr] Checking git2 v0.18.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking serde_regex v1.1.0 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking tracing_facade v0.1.0 [INFO] [stderr] Checking tracing_chromium v0.1.0 [INFO] [stderr] Checking progpool v0.2.2 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.22 [INFO] [stderr] Checking pore v0.1.17 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/depot.rs:31:7 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct Depot { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 31 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Depot` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `remote` are never read [INFO] [stdout] --> src/manifest/mod.rs:67:7 [INFO] [stdout] | [INFO] [stdout] 66 | pub struct SuperProject { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 67 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 68 | pub remote: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SuperProject` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bug_url` is never read [INFO] [stdout] --> src/manifest/mod.rs:73:7 [INFO] [stdout] | [INFO] [stdout] 72 | pub struct ContactInfo { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 73 | pub bug_url: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ContactInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/tree.rs:313:7 [INFO] [stdout] | [INFO] [stdout] 312 | pub struct ProjectStatus { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 313 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ProjectStatus` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:484:5 [INFO] [stdout] | [INFO] [stdout] 444 | config: Arc, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 484 | Arc::clone(&config), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:488:5 [INFO] [stdout] | [INFO] [stdout] 444 | config: Arc, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 488 | FetchTarget::Upstream, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1201:9 [INFO] [stdout] | [INFO] [stdout] 906 | let config = match Config::from_path(&config_path) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 907 | Ok(config) => Arc::new(config), [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 908 | [INFO] [stdout] 909 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 938 | let mut pool = Pool::with_size(pool_size); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 939 | [INFO] [stdout] 940 | let update_checker = if config.update_check && atty::is(Stream::Stdout) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 946 | let command_action = || -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1201 | match command_action() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/depot.rs:334:5 [INFO] [stdout] | [INFO] [stdout] 319 | path: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | Depot::replace_dir(&mirror_tags, &repo_tags).context("failed to replace tags") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:339:8 [INFO] [stdout] | [INFO] [stdout] 329 | fn from_branch(branch: git2::Branch) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | let commit = branch [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 339 | Ok(BranchInfo { [INFO] [stdout] | ________^ [INFO] [stdout] 340 | | name: name.to_string(), [INFO] [stdout] 341 | | commit, [INFO] [stdout] 342 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:347:29 [INFO] [stdout] | [INFO] [stdout] 345 | fn from_ref(reference: git2::Reference) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | ensure!(reference.is_branch(), "expected reference to refer to a branch"); [INFO] [stdout] 347 | BranchInfo::from_branch(git2::Branch::wrap(reference)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:690:15 [INFO] [stdout] | [INFO] [stdout] 685 | let mut cmd = std::process::Command::new("ssh"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 690 | cmd.spawn().expect("failed to start ssh ControlMaster") [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:1267:8 [INFO] [stdout] | [INFO] [stdout] 1173 | config: Arc, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1179 | let projects: Vec> = projects.into_iter().map(Arc::new).collect(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1180 | [INFO] [stdout] 1181 | let mut job = Job::with_name("status"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1182 | let tree_root = Arc::new(self.path.clone()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1267 | Ok(pool.execute(job)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn create_symlink + Debug, U: AsRef + Debug>(target: T, symlink_path: U) -> Result<(), Error> { [INFO] [stdout] | --------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | match symlink(target, symlink_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pore` (bin "pore") due to 10 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/depot.rs:31:7 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct Depot { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 31 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Depot` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `remote` are never read [INFO] [stdout] --> src/manifest/mod.rs:67:7 [INFO] [stdout] | [INFO] [stdout] 66 | pub struct SuperProject { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 67 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 68 | pub remote: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SuperProject` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `bug_url` is never read [INFO] [stdout] --> src/manifest/mod.rs:73:7 [INFO] [stdout] | [INFO] [stdout] 72 | pub struct ContactInfo { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 73 | pub bug_url: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ContactInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/tree.rs:313:7 [INFO] [stdout] | [INFO] [stdout] 312 | pub struct ProjectStatus { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 313 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ProjectStatus` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:484:5 [INFO] [stdout] | [INFO] [stdout] 444 | config: Arc, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 484 | Arc::clone(&config), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:488:5 [INFO] [stdout] | [INFO] [stdout] 444 | config: Arc, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 488 | FetchTarget::Upstream, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:1201:9 [INFO] [stdout] | [INFO] [stdout] 906 | let config = match Config::from_path(&config_path) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 907 | Ok(config) => Arc::new(config), [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 908 | [INFO] [stdout] 909 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 938 | let mut pool = Pool::with_size(pool_size); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 939 | [INFO] [stdout] 940 | let update_checker = if config.update_check && atty::is(Stream::Stdout) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 946 | let command_action = || -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1201 | match command_action() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/depot.rs:334:5 [INFO] [stdout] | [INFO] [stdout] 319 | path: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | Depot::replace_dir(&mirror_tags, &repo_tags).context("failed to replace tags") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:339:8 [INFO] [stdout] | [INFO] [stdout] 329 | fn from_branch(branch: git2::Branch) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | let commit = branch [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 339 | Ok(BranchInfo { [INFO] [stdout] | ________^ [INFO] [stdout] 340 | | name: name.to_string(), [INFO] [stdout] 341 | | commit, [INFO] [stdout] 342 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:347:29 [INFO] [stdout] | [INFO] [stdout] 345 | fn from_ref(reference: git2::Reference) -> Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | ensure!(reference.is_branch(), "expected reference to refer to a branch"); [INFO] [stdout] 347 | BranchInfo::from_branch(git2::Branch::wrap(reference)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:690:15 [INFO] [stdout] | [INFO] [stdout] 685 | let mut cmd = std::process::Command::new("ssh"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 690 | cmd.spawn().expect("failed to start ssh ControlMaster") [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:1267:8 [INFO] [stdout] | [INFO] [stdout] 1173 | config: Arc, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1179 | let projects: Vec> = projects.into_iter().map(Arc::new).collect(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1180 | [INFO] [stdout] 1181 | let mut job = Job::with_name("status"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1182 | let tree_root = Arc::new(self.path.clone()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1267 | Ok(pool.execute(job)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn create_symlink + Debug, U: AsRef + Debug>(target: T, symlink_path: U) -> Result<(), Error> { [INFO] [stdout] | --------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | match symlink(target, symlink_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pore` (bin "pore" test) due to 10 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b39aa31a31a98ba9e4b85ca3a3ec8b32348b39b188b1126324949edee7218ca8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b39aa31a31a98ba9e4b85ca3a3ec8b32348b39b188b1126324949edee7218ca8", kill_on_drop: false }` [INFO] [stdout] b39aa31a31a98ba9e4b85ca3a3ec8b32348b39b188b1126324949edee7218ca8