[INFO] fetching crate pop3-client 0.2.1... [INFO] checking pop3-client-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pop3-client 0.2.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate pop3-client 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pop3-client 0.2.1 [INFO] finished tweaking crates.io crate pop3-client 0.2.1 [INFO] tweaked toml for crates.io crate pop3-client 0.2.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 67 packages to latest compatible versions [INFO] [stderr] Adding bindgen v0.69.4 (latest: v0.70.1) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding which v4.4.2 (latest: v6.0.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5d13169358d0f24e1354d0ea15ea7854d2474fb0d529af67e3dd9662687fcc9b [INFO] running `Command { std: "docker" "start" "-a" "5d13169358d0f24e1354d0ea15ea7854d2474fb0d529af67e3dd9662687fcc9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5d13169358d0f24e1354d0ea15ea7854d2474fb0d529af67e3dd9662687fcc9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5d13169358d0f24e1354d0ea15ea7854d2474fb0d529af67e3dd9662687fcc9b", kill_on_drop: false }` [INFO] [stdout] 5d13169358d0f24e1354d0ea15ea7854d2474fb0d529af67e3dd9662687fcc9b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9d03183300aae76ea3458119544a9dbf8792af3f5a4f8f586e0723e3482b2820 [INFO] running `Command { std: "docker" "start" "-a" "9d03183300aae76ea3458119544a9dbf8792af3f5a4f8f586e0723e3482b2820", kill_on_drop: false }` [INFO] [stderr] Checking pop3-client v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:185:17 [INFO] [stdout] | [INFO] [stdout] 184 | .and_then(|s1| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | / self.query(&password_query, false) [INFO] [stdout] 186 | | .map(|s2| { [INFO] [stdout] 187 | | let mut buf = BytesMut::with_capacity(64); [INFO] [stdout] 188 | | buf.put(&s1[..]); [INFO] [stdout] 189 | | buf.put(&s2[..]); [INFO] [stdout] 190 | | buf.freeze() [INFO] [stdout] 191 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 215 | pub fn quit(mut self) -> Result<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | self.query("QUIT\r\n", false).map(|_| ()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:479:25 [INFO] [stdout] | [INFO] [stdout] 478 | .map(|client| Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 479 | client: BufReader::new(client), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:483:36 [INFO] [stdout] | [INFO] [stdout] 483 | .and_then(|mut client| client.read_response(false).map(|_| client)) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:483:68 [INFO] [stdout] | [INFO] [stdout] 483 | .and_then(|mut client| client.read_response(false).map(|_| client)) [INFO] [stdout] | ---------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:541:9 [INFO] [stdout] | [INFO] [stdout] 539 | let mut response = BytesMut::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 540 | let mut buffer = vec![]; [INFO] [stdout] 541 | / self.client [INFO] [stdout] 542 | | .read_until(b'\n', &mut buffer) [INFO] [stdout] 543 | | .map_err(|e| e.to_string()) [INFO] [stdout] 544 | | .and_then(|x| { [INFO] [stdout] ... | [INFO] [stdout] 564 | | } [INFO] [stdout] 565 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:566:23 [INFO] [stdout] | [INFO] [stdout] 539 | let mut response = BytesMut::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 566 | .and_then(|s| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 567 | | if multiline { [INFO] [stdout] 568 | | response.put(&s[..]); [INFO] [stdout] 569 | | while !buffer.ends_with(b".\r\n") { [INFO] [stdout] ... | [INFO] [stdout] 593 | | } [INFO] [stdout] 594 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pop3-client` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:185:17 [INFO] [stdout] | [INFO] [stdout] 184 | .and_then(|s1| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | / self.query(&password_query, false) [INFO] [stdout] 186 | | .map(|s2| { [INFO] [stdout] 187 | | let mut buf = BytesMut::with_capacity(64); [INFO] [stdout] 188 | | buf.put(&s1[..]); [INFO] [stdout] 189 | | buf.put(&s2[..]); [INFO] [stdout] 190 | | buf.freeze() [INFO] [stdout] 191 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:216:9 [INFO] [stdout] | [INFO] [stdout] 215 | pub fn quit(mut self) -> Result<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | self.query("QUIT\r\n", false).map(|_| ()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:479:25 [INFO] [stdout] | [INFO] [stdout] 478 | .map(|client| Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 479 | client: BufReader::new(client), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:483:36 [INFO] [stdout] | [INFO] [stdout] 483 | .and_then(|mut client| client.read_response(false).map(|_| client)) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:483:68 [INFO] [stdout] | [INFO] [stdout] 483 | .and_then(|mut client| client.read_response(false).map(|_| client)) [INFO] [stdout] | ---------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:541:9 [INFO] [stdout] | [INFO] [stdout] 539 | let mut response = BytesMut::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 540 | let mut buffer = vec![]; [INFO] [stdout] 541 | / self.client [INFO] [stdout] 542 | | .read_until(b'\n', &mut buffer) [INFO] [stdout] 543 | | .map_err(|e| e.to_string()) [INFO] [stdout] 544 | | .and_then(|x| { [INFO] [stdout] ... | [INFO] [stdout] 564 | | } [INFO] [stdout] 565 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:566:23 [INFO] [stdout] | [INFO] [stdout] 539 | let mut response = BytesMut::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 566 | .and_then(|s| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 567 | | if multiline { [INFO] [stdout] 568 | | response.put(&s[..]); [INFO] [stdout] 569 | | while !buffer.ends_with(b".\r\n") { [INFO] [stdout] ... | [INFO] [stdout] 593 | | } [INFO] [stdout] 594 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pop3-client` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "9d03183300aae76ea3458119544a9dbf8792af3f5a4f8f586e0723e3482b2820", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d03183300aae76ea3458119544a9dbf8792af3f5a4f8f586e0723e3482b2820", kill_on_drop: false }` [INFO] [stdout] 9d03183300aae76ea3458119544a9dbf8792af3f5a4f8f586e0723e3482b2820