[INFO] fetching crate polkavm-linker 0.11.0... [INFO] checking polkavm-linker-0.11.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate polkavm-linker 0.11.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate polkavm-linker 0.11.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate polkavm-linker 0.11.0 [INFO] finished tweaking crates.io crate polkavm-linker 0.11.0 [INFO] tweaked toml for crates.io crate polkavm-linker 0.11.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 64 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding gimli v0.28.1 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.13.2 (latest: v0.14.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 720ca46ffa40570516df90eae3359ba915956085d4322b028860ed609ab4da92 [INFO] running `Command { std: "docker" "start" "-a" "720ca46ffa40570516df90eae3359ba915956085d4322b028860ed609ab4da92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "720ca46ffa40570516df90eae3359ba915956085d4322b028860ed609ab4da92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "720ca46ffa40570516df90eae3359ba915956085d4322b028860ed609ab4da92", kill_on_drop: false }` [INFO] [stdout] 720ca46ffa40570516df90eae3359ba915956085d4322b028860ed609ab4da92 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9b5e1eca93ea227337bbe15478ceb4c8700c67e2c731d30e73d173afc7c567e0 [INFO] running `Command { std: "docker" "start" "-a" "9b5e1eca93ea227337bbe15478ceb4c8700c67e2c731d30e73d173afc7c567e0", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking slice-group-by v0.3.1 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking polkavm-common v0.11.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regalloc2 v0.9.3 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking polkavm-linker v0.11.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dwarf.rs:258:9 [INFO] [stdout] | [INFO] [stdout] 251 | value: AttributeValue, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | / match name { [INFO] [stdout] 259 | | gimli::DW_AT_low_pc => match value.clone() { [INFO] [stdout] 260 | | AttributeValue { offset: Some(offset), .. } => { [INFO] [stdout] 261 | | let relocation_target = SectionTarget { [INFO] [stdout] ... | [INFO] [stdout] 487 | | _ => Ok(()), [INFO] [stdout] 488 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dwarf.rs:507:12 [INFO] [stdout] | [INFO] [stdout] 504 | let name = dwarf.attr_string(&unit.raw_unit, value.clone())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 505 | let name = name.to_string_lossy()?; [INFO] [stdout] 506 | let name = string_cache.dedup(&name); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 507 | Ok(Some(name)) [INFO] [stdout] | ^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dwarf.rs:532:12 [INFO] [stdout] | [INFO] [stdout] 528 | let mut parser = AttributeParser::new(self.depth + 1); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 532 | Ok(Some((target_unit, parser))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dwarf.rs:1346:12 [INFO] [stdout] | [INFO] [stdout] 1341 | let mut tree = unit.raw_unit.entries_tree(None)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1346 | Ok(self.subprograms.drain(..).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dwarf.rs:2166:14 [INFO] [stdout] | [INFO] [stdout] 2145 | let mut input = gimli::Section::reader(&dwarf.debug_info).clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2146 | let section_base = input.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2166 | Some(parse_attribute(§ion_base, &mut input, encoding, attribute).map(|value| (attribute.name(), value))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dwarf.rs:2329:8 [INFO] [stdout] | [INFO] [stdout] 2276 | let dwarf: gimli::Dwarf>> = gimli::Dwarf::load(&mut load_section)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2277 | let mut units = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2316 | let walker = DwarfWalker { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2328 | let location_map = walker.run()?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 2329 | Ok(DwarfInfo { location_map }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fast_range_map.rs:727:14 [INFO] [stdout] | [INFO] [stdout] 724 | let value = self.range_map.data.get_value(index).clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 727 | Some((chopped_key, value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/program_from_elf.rs:296:12 [INFO] [stdout] | [INFO] [stdout] 295 | fn map_target(self, map: impl Fn(T) -> Result) -> Result, E> { [INFO] [stdout] | ---- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | Ok(EndOfBlock { [INFO] [stdout] | ____________^ [INFO] [stdout] 297 | | source: self.source, [INFO] [stdout] 298 | | instruction: self.instruction.map_target(map)?, [INFO] [stdout] 299 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/program_from_elf.rs:738:12 [INFO] [stdout] | [INFO] [stdout] 737 | fn map_target(self, map: impl Fn(T) -> Result) -> Result, E> { [INFO] [stdout] | ---- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 738 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 739 | | BasicInst::LoadImmediate { dst, imm } => BasicInst::LoadImmediate { dst, imm }, [INFO] [stdout] 740 | | BasicInst::LoadAbsolute { kind, dst, target } => BasicInst::LoadAbsolute { kind, dst, target }, [INFO] [stdout] 741 | | BasicInst::StoreAbsolute { kind, src, target } => BasicInst::StoreAbsolute { kind, src, target }, [INFO] [stdout] ... | [INFO] [stdout] 751 | | BasicInst::Nop => BasicInst::Nop, [INFO] [stdout] 752 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/program_from_elf.rs:824:12 [INFO] [stdout] | [INFO] [stdout] 823 | fn map_target(self, map: impl Fn(T) -> Result) -> Result, E> { [INFO] [stdout] | ---- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 824 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 825 | | ControlInst::Jump { target } => ControlInst::Jump { target: map(target)? }, [INFO] [stdout] 826 | | ControlInst::Call { ra, target, target_return } => ControlInst::Call { [INFO] [stdout] 827 | | ra, [INFO] [stdout] ... | [INFO] [stdout] 856 | | ControlInst::Unimplemented => ControlInst::Unimplemented, [INFO] [stdout] 857 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `polkavm-linker` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "9b5e1eca93ea227337bbe15478ceb4c8700c67e2c731d30e73d173afc7c567e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b5e1eca93ea227337bbe15478ceb4c8700c67e2c731d30e73d173afc7c567e0", kill_on_drop: false }` [INFO] [stdout] 9b5e1eca93ea227337bbe15478ceb4c8700c67e2c731d30e73d173afc7c567e0