[INFO] fetching crate polars-json 0.42.0... [INFO] checking polars-json-0.42.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate polars-json 0.42.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate polars-json 0.42.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate polars-json 0.42.0 [INFO] finished tweaking crates.io crate polars-json 0.42.0 [INFO] tweaked toml for crates.io crate polars-json 0.42.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 113 packages to latest compatible versions [INFO] [stderr] Adding atoi_simd v0.15.6 (latest: v0.16.0) [INFO] [stderr] Adding chrono-tz v0.8.6 (latest: v0.9.0) [INFO] [stderr] Adding chrono-tz-build v0.2.1 (latest: v0.3.0) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d3cd14267fe3d38e24b5cd1e8cead1bcbd68dfd2c68c70811e81b415099a6aeb [INFO] running `Command { std: "docker" "start" "-a" "d3cd14267fe3d38e24b5cd1e8cead1bcbd68dfd2c68c70811e81b415099a6aeb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d3cd14267fe3d38e24b5cd1e8cead1bcbd68dfd2c68c70811e81b415099a6aeb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d3cd14267fe3d38e24b5cd1e8cead1bcbd68dfd2c68c70811e81b415099a6aeb", kill_on_drop: false }` [INFO] [stdout] d3cd14267fe3d38e24b5cd1e8cead1bcbd68dfd2c68c70811e81b415099a6aeb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 701dfddd4c718b4392cd565d547b89226534e203f79dad9ccfa14e711caa16b0 [INFO] running `Command { std: "docker" "start" "-a" "701dfddd4c718b4392cd565d547b89226534e203f79dad9ccfa14e711caa16b0", kill_on_drop: false }` [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling target-features v0.1.6 [INFO] [stderr] Compiling psm v0.1.22 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling stacker v0.1.17 [INFO] [stderr] Compiling smartstring v1.0.1 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Compiling polars-utils v0.42.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling ref-cast v1.0.23 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking polars-error v0.42.0 [INFO] [stderr] Checking raw-cpuid v11.1.0 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Compiling ref-cast-impl v1.0.23 [INFO] [stderr] Compiling polars-arrow v0.42.0 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking streaming-iterator v0.1.9 [INFO] [stderr] Checking atoi_simd v0.15.6 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking fast-float v0.2.0 [INFO] [stderr] Checking ethnum v1.5.0 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling multiversion-macros v0.7.4 [INFO] [stderr] Checking multiversion v0.7.4 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking halfbrown v0.2.5 [INFO] [stderr] Checking value-trait v0.8.1 [INFO] [stderr] Checking simd-json v0.13.10 [INFO] [stderr] Checking polars-json v0.42.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/deserialize.rs:126:38 [INFO] [stdout] | [INFO] [stdout] 94 | data_type: ArrowDataType, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let values = _deserialize(&inner, child.clone()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | [INFO] [stdout] 126 | ListArray::::new(data_type, offsets.into(), values, validity.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/deserialize.rs:126:62 [INFO] [stdout] | [INFO] [stdout] 94 | data_type: ArrowDataType, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let values = _deserialize(&inner, child.clone()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | [INFO] [stdout] 126 | ListArray::::new(data_type, offsets.into(), values, validity.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/deserialize.rs:168:22 [INFO] [stdout] | [INFO] [stdout] 131 | data_type: ArrowDataType, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let mut values = fields [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let values = fields [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | StructArray::new(data_type.clone(), values, validity.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/deserialize.rs:168:49 [INFO] [stdout] | [INFO] [stdout] 131 | data_type: ArrowDataType, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let mut values = fields [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let values = fields [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | StructArray::new(data_type.clone(), values, validity.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/deserialize.rs:153:61 [INFO] [stdout] | [INFO] [stdout] 153 | .for_each(|(_, (_, inner))| inner.push(&JSON_NULL_VALUE)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/deserialize.rs:182:14 [INFO] [stdout] | [INFO] [stdout] 173 | data_type: ArrowDataType, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let mut array = MutablePrimitiveArray::::with_capacity(rows.len()).to(data_type); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | f(&mut array, rows); [INFO] [stdout] 182 | Box::new(A::from(array)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/deserialize.rs:246:14 [INFO] [stdout] | [INFO] [stdout] 244 | let mut array = M::with_capacity(rows.len()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | f(&mut array, rows); [INFO] [stdout] 246 | Box::new(A::from(array)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/infer_schema.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 28 | let fields = inner [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(ArrowDataType::Struct(fields)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/infer_schema.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|(key, value)| infer(value).map(|dt| (key, dt))) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/infer_schema.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 31 | .map(|maybe_dt| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let (key, dt) = maybe_dt?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Ok(Field::new(key.as_ref(), dt, true)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/infer_schema.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 40 | let types = values [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let dt = if !types.is_empty() { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let types = types.into_iter().collect::>(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Ok(ArrowDataType::LargeList(Box::new(Field::new( [INFO] [stdout] | ________^ [INFO] [stdout] 54 | | ITEM_NAME, dt, true, [INFO] [stdout] 55 | | )))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/infer_schema.rs:113:34 [INFO] [stdout] | [INFO] [stdout] 111 | .map(|(name, dts)| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let dts = dts.into_iter().collect::>(); [INFO] [stdout] 113 | Field::new(name, coerce_data_type(&dts), true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/infer_schema.rs:137:46 [INFO] [stdout] | [INFO] [stdout] 137 | .reduce(|a, b| coerce_data_type(&[a, b])) [INFO] [stdout] | - - ^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/write/serialize.rs:201:14 [INFO] [stdout] | [INFO] [stdout] 194 | let mut serializers = array [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | Box::new(BufStreamingIterator::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 202 | | ZipValidity::new_with_validity(0..array.len(), array.validity()), [INFO] [stdout] 203 | | move |maybe, buf| { [INFO] [stdout] 204 | | if maybe.is_some() { [INFO] [stdout] ... | [INFO] [stdout] 222 | | vec![], [INFO] [stdout] 223 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/write/serialize.rs:272:14 [INFO] [stdout] | [INFO] [stdout] 270 | let mut serializer = new_serializer(array.values().as_ref(), offset, take); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 271 | [INFO] [stdout] 272 | Box::new(BufStreamingIterator::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 273 | | ZipValidity::new(0..array.len(), array.validity().map(|x| x.iter())), [INFO] [stdout] 274 | | move |ix, buf| { [INFO] [stdout] 275 | | if ix.is_some() { [INFO] [stdout] ... | [INFO] [stdout] 291 | | vec![], [INFO] [stdout] 292 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ndjson/deserialize.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 26 | fn _deserializer(s: &mut str, data_type: ArrowDataType) -> PolarsResult> { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let slice = unsafe { s.as_bytes_mut() }; [INFO] [stdout] 28 | let out = simd_json::to_borrowed_value(slice) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | .map_err(|e| PolarsError::ComputeError(format!("json parsing error: '{e}'").into()))?; [INFO] [stdout] 30 | Ok(if let BorrowedValue::Array(rows) = out { [INFO] [stdout] | ____________^ [INFO] [stdout] 31 | | super::super::json::deserialize::_deserialize(&rows, data_type.clone()) [INFO] [stdout] 32 | | } else { [INFO] [stdout] 33 | | unreachable!() [INFO] [stdout] 34 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ndjson/file.rs:123:8 [INFO] [stdout] | [INFO] [stdout] 115 | let mut data_types = PlIndexSet::default(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(data_types.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/deserialize.rs:126:38 [INFO] [stdout] | [INFO] [stdout] 94 | data_type: ArrowDataType, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let values = _deserialize(&inner, child.clone()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | [INFO] [stdout] 126 | ListArray::::new(data_type, offsets.into(), values, validity.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/deserialize.rs:126:62 [INFO] [stdout] | [INFO] [stdout] 94 | data_type: ArrowDataType, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let values = _deserialize(&inner, child.clone()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | [INFO] [stdout] 126 | ListArray::::new(data_type, offsets.into(), values, validity.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/deserialize.rs:168:22 [INFO] [stdout] | [INFO] [stdout] 131 | data_type: ArrowDataType, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let mut values = fields [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let values = fields [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | StructArray::new(data_type.clone(), values, validity.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/deserialize.rs:168:49 [INFO] [stdout] | [INFO] [stdout] 131 | data_type: ArrowDataType, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let mut values = fields [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let values = fields [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | StructArray::new(data_type.clone(), values, validity.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/deserialize.rs:153:61 [INFO] [stdout] | [INFO] [stdout] 153 | .for_each(|(_, (_, inner))| inner.push(&JSON_NULL_VALUE)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/deserialize.rs:182:14 [INFO] [stdout] | [INFO] [stdout] 173 | data_type: ArrowDataType, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let mut array = MutablePrimitiveArray::::with_capacity(rows.len()).to(data_type); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | f(&mut array, rows); [INFO] [stdout] 182 | Box::new(A::from(array)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/deserialize.rs:246:14 [INFO] [stdout] | [INFO] [stdout] 244 | let mut array = M::with_capacity(rows.len()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | f(&mut array, rows); [INFO] [stdout] 246 | Box::new(A::from(array)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/infer_schema.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 28 | let fields = inner [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(ArrowDataType::Struct(fields)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/infer_schema.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 30 | .map(|(key, value)| infer(value).map(|dt| (key, dt))) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/infer_schema.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 31 | .map(|maybe_dt| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let (key, dt) = maybe_dt?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Ok(Field::new(key.as_ref(), dt, true)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/infer_schema.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 40 | let types = values [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let dt = if !types.is_empty() { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let types = types.into_iter().collect::>(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Ok(ArrowDataType::LargeList(Box::new(Field::new( [INFO] [stdout] | ________^ [INFO] [stdout] 54 | | ITEM_NAME, dt, true, [INFO] [stdout] 55 | | )))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/infer_schema.rs:113:34 [INFO] [stdout] | [INFO] [stdout] 111 | .map(|(name, dts)| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let dts = dts.into_iter().collect::>(); [INFO] [stdout] 113 | Field::new(name, coerce_data_type(&dts), true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/infer_schema.rs:137:46 [INFO] [stdout] | [INFO] [stdout] 137 | .reduce(|a, b| coerce_data_type(&[a, b])) [INFO] [stdout] | - - ^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/write/serialize.rs:201:14 [INFO] [stdout] | [INFO] [stdout] 194 | let mut serializers = array [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | Box::new(BufStreamingIterator::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 202 | | ZipValidity::new_with_validity(0..array.len(), array.validity()), [INFO] [stdout] 203 | | move |maybe, buf| { [INFO] [stdout] 204 | | if maybe.is_some() { [INFO] [stdout] ... | [INFO] [stdout] 222 | | vec![], [INFO] [stdout] 223 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json/write/serialize.rs:272:14 [INFO] [stdout] | [INFO] [stdout] 270 | let mut serializer = new_serializer(array.values().as_ref(), offset, take); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 271 | [INFO] [stdout] 272 | Box::new(BufStreamingIterator::new( [INFO] [stdout] | ______________^ [INFO] [stdout] 273 | | ZipValidity::new(0..array.len(), array.validity().map(|x| x.iter())), [INFO] [stdout] 274 | | move |ix, buf| { [INFO] [stdout] 275 | | if ix.is_some() { [INFO] [stdout] ... | [INFO] [stdout] 291 | | vec![], [INFO] [stdout] 292 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ndjson/deserialize.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 26 | fn _deserializer(s: &mut str, data_type: ArrowDataType) -> PolarsResult> { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let slice = unsafe { s.as_bytes_mut() }; [INFO] [stdout] 28 | let out = simd_json::to_borrowed_value(slice) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | .map_err(|e| PolarsError::ComputeError(format!("json parsing error: '{e}'").into()))?; [INFO] [stdout] 30 | Ok(if let BorrowedValue::Array(rows) = out { [INFO] [stdout] | ____________^ [INFO] [stdout] 31 | | super::super::json::deserialize::_deserialize(&rows, data_type.clone()) [INFO] [stdout] 32 | | } else { [INFO] [stdout] 33 | | unreachable!() [INFO] [stdout] 34 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ndjson/file.rs:123:8 [INFO] [stdout] | [INFO] [stdout] 115 | let mut data_types = PlIndexSet::default(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(data_types.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ndjson/file.rs:144:8 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn infer_iter>(rows: impl Iterator) -> PolarsResult { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | let mut data_types = IndexSet::<_, PlRandomState>::default(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(crate::json::infer_schema::coerce_data_type(&v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ndjson/write.rs:113:14 [INFO] [stdout] | [INFO] [stdout] 112 | let item = self.iterator.next().transpose()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Some(item.and_then(|x| { [INFO] [stdout] | ______________^ [INFO] [stdout] 114 | | self.writer.write_all(x)?; [INFO] [stdout] 115 | | Ok(()) [INFO] [stdout] 116 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ndjson/file.rs:144:8 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn infer_iter>(rows: impl Iterator) -> PolarsResult { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | let mut data_types = IndexSet::<_, PlRandomState>::default(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(crate::json::infer_schema::coerce_data_type(&v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ndjson/write.rs:113:14 [INFO] [stdout] | [INFO] [stdout] 112 | let item = self.iterator.next().transpose()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Some(item.and_then(|x| { [INFO] [stdout] | ______________^ [INFO] [stdout] 114 | | self.writer.write_all(x)?; [INFO] [stdout] 115 | | Ok(()) [INFO] [stdout] 116 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `polars-json` (lib) due to 20 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `polars-json` (lib test) due to 20 previous errors [INFO] running `Command { std: "docker" "inspect" "701dfddd4c718b4392cd565d547b89226534e203f79dad9ccfa14e711caa16b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "701dfddd4c718b4392cd565d547b89226534e203f79dad9ccfa14e711caa16b0", kill_on_drop: false }` [INFO] [stdout] 701dfddd4c718b4392cd565d547b89226534e203f79dad9ccfa14e711caa16b0