[INFO] fetching crate polars-algo 0.35.4... [INFO] checking polars-algo-0.35.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate polars-algo 0.35.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate polars-algo 0.35.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate polars-algo 0.35.4 [INFO] finished tweaking crates.io crate polars-algo 0.35.4 [INFO] tweaked toml for crates.io crate polars-algo 0.35.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 110 packages to latest compatible versions [INFO] [stderr] Adding atoi_simd v0.15.6 (latest: v0.16.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding memmap2 v0.7.1 (latest: v0.9.4) [INFO] [stderr] Adding polars-arrow v0.35.4 (latest: v0.42.0) [INFO] [stderr] Adding polars-core v0.35.4 (latest: v0.42.0) [INFO] [stderr] Adding polars-error v0.35.4 (latest: v0.42.0) [INFO] [stderr] Adding polars-io v0.35.4 (latest: v0.42.0) [INFO] [stderr] Adding polars-lazy v0.35.4 (latest: v0.42.0) [INFO] [stderr] Adding polars-ops v0.35.4 (latest: v0.42.0) [INFO] [stderr] Adding polars-plan v0.35.4 (latest: v0.42.0) [INFO] [stderr] Adding polars-row v0.35.4 (latest: v0.42.0) [INFO] [stderr] Adding polars-time v0.35.4 (latest: v0.42.0) [INFO] [stderr] Adding polars-utils v0.35.4 (latest: v0.42.0) [INFO] [stderr] Adding strum_macros v0.25.3 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] daf9142bccb8abeed0e3dc04982b7d7f386fce18fbef5444bac5d847bf0ea32c [INFO] running `Command { std: "docker" "start" "-a" "daf9142bccb8abeed0e3dc04982b7d7f386fce18fbef5444bac5d847bf0ea32c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "daf9142bccb8abeed0e3dc04982b7d7f386fce18fbef5444bac5d847bf0ea32c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "daf9142bccb8abeed0e3dc04982b7d7f386fce18fbef5444bac5d847bf0ea32c", kill_on_drop: false }` [INFO] [stdout] daf9142bccb8abeed0e3dc04982b7d7f386fce18fbef5444bac5d847bf0ea32c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2fe6c1a7654a602f99122071a611f82fd599b0fe903a0049ee8cf1886f9dcce5 [INFO] running `Command { std: "docker" "start" "-a" "2fe6c1a7654a602f99122071a611f82fd599b0fe903a0049ee8cf1886f9dcce5", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling target-features v0.1.6 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling smartstring v1.0.1 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling polars-utils v0.35.4 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking foreign_vec v0.1.0 [INFO] [stderr] Checking ethnum v1.5.0 [INFO] [stderr] Checking atoi_simd v0.15.6 [INFO] [stderr] Checking streaming-iterator v0.1.9 [INFO] [stderr] Checking fast-float v0.2.0 [INFO] [stderr] Compiling polars-core v0.35.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking xxhash-rust v0.8.12 [INFO] [stderr] Compiling polars-ops v0.35.4 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking memmap2 v0.7.1 [INFO] [stderr] Compiling polars-plan v0.35.4 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Compiling polars-lazy v0.35.4 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking argminmax v0.6.2 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking now v0.1.3 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking polars-error v0.35.4 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling multiversion-macros v0.7.4 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking multiversion v0.7.4 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking polars-arrow v0.35.4 [INFO] [stderr] Checking polars-row v0.35.4 [INFO] [stderr] Checking polars-io v0.35.4 [INFO] [stderr] Checking polars-time v0.35.4 [INFO] [stderr] Checking polars-algo v0.35.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algo.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 9 | let s = s.cast(&DataType::Float64)?.sort(false); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | let bins = if let Some(bins_in) = bins { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let (min_value, max_value): (Expr, AnyValue) = match s.dtype() { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let mut bins = bins.extend_constant(max_value, 1)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let cuts_df = df![ [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let cuts_df = cuts_df [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let cuts = cuts_df [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let out = s.clone().into_frame().join_asof( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let out = out [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | / cuts.left_join(&out, [category_str], [category_str])? [INFO] [stdout] 99 | | .fill_null(FillNullStrategy::Zero)? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `polars-algo` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algo.rs:98:5 [INFO] [stdout] | [INFO] [stdout] 9 | let s = s.cast(&DataType::Float64)?.sort(false); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | let bins = if let Some(bins_in) = bins { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let (min_value, max_value): (Expr, AnyValue) = match s.dtype() { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let mut bins = bins.extend_constant(max_value, 1)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let cuts_df = df![ [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let cuts_df = cuts_df [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let cuts = cuts_df [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let out = s.clone().into_frame().join_asof( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let out = out [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | / cuts.left_join(&out, [category_str], [category_str])? [INFO] [stdout] 99 | | .fill_null(FillNullStrategy::Zero)? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `polars-algo` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "2fe6c1a7654a602f99122071a611f82fd599b0fe903a0049ee8cf1886f9dcce5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2fe6c1a7654a602f99122071a611f82fd599b0fe903a0049ee8cf1886f9dcce5", kill_on_drop: false }` [INFO] [stdout] 2fe6c1a7654a602f99122071a611f82fd599b0fe903a0049ee8cf1886f9dcce5