[INFO] fetching crate png 0.17.13... [INFO] checking png-0.17.13 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate png 0.17.13 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate png 0.17.13 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate png 0.17.13 [INFO] finished tweaking crates.io crate png 0.17.13 [INFO] tweaked toml for crates.io crate png 0.17.13 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate png 0.17.13 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 08e7227e6ee80ef6c9edb3a4b48701d9b47a626c67b5e48f6c96f634ae39806b [INFO] running `Command { std: "docker" "start" "-a" "08e7227e6ee80ef6c9edb3a4b48701d9b47a626c67b5e48f6c96f634ae39806b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "08e7227e6ee80ef6c9edb3a4b48701d9b47a626c67b5e48f6c96f634ae39806b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "08e7227e6ee80ef6c9edb3a4b48701d9b47a626c67b5e48f6c96f634ae39806b", kill_on_drop: false }` [INFO] [stdout] 08e7227e6ee80ef6c9edb3a4b48701d9b47a626c67b5e48f6c96f634ae39806b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ab7ecc9c766eea945166e1f6674c986ee8be4cdf72c060ceb741258c930c4e58 [INFO] running `Command { std: "docker" "start" "-a" "ab7ecc9c766eea945166e1f6674c986ee8be4cdf72c060ceb741258c930c4e58", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling pkg-config v0.3.28 [INFO] [stderr] Compiling xml-rs v0.8.19 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking libloading v0.8.1 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking fdeflate v0.3.3 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking xcursor v0.3.5 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Checking foreign-types-shared v0.3.1 [INFO] [stderr] Checking safe_arch v0.5.2 [INFO] [stderr] Checking tiny-skia-path v0.7.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking raw-window-handle v0.4.3 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking png v0.17.10 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling servo-fontconfig-sys v5.1.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.16.1 [INFO] [stderr] Compiling crossfont v0.5.2 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Compiling glutin_glx_sys v0.1.8 [INFO] [stderr] Compiling glutin_egl_sys v0.1.6 [INFO] [stderr] Checking tiny-skia v0.7.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling glium v0.32.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking takeable-option v0.5.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking png v0.17.13 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `fuzzing` [INFO] [stdout] --> src/decoder/stream.rs:29:38 [INFO] [stdout] | [INFO] [stdout] 29 | const CHECKSUM_DISABLED: bool = cfg!(fuzzing); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(fuzzing)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(fuzzing)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling freetype-sys v0.13.1 [INFO] [stderr] Compiling expat-sys v2.1.6 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/mod.rs:150:27 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn new_with_limits(r: R, limits: Limits) -> Decoder { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | let mut decoder = StreamingDecoder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | read_decoder: ReadDecoder { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 151 | | reader: BufReader::with_capacity(CHUNCK_BUFFER_SIZE, r), [INFO] [stdout] 152 | | decoder, [INFO] [stdout] 153 | | at_eof: false, [INFO] [stdout] 154 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder/mod.rs:165:27 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn new_with_options(r: R, decode_options: DecodeOptions) -> Decoder { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let mut decoder = StreamingDecoder::new_with_options(decode_options); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | read_decoder: ReadDecoder { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 166 | | reader: BufReader::with_capacity(CHUNCK_BUFFER_SIZE, r), [INFO] [stdout] 167 | | decoder, [INFO] [stdout] 168 | | at_eof: false, [INFO] [stdout] 169 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder.rs:183:12 [INFO] [stdout] | [INFO] [stdout] 172 | pub fn with_info(w: W, info: Info<'a>) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | Ok(Encoder { [INFO] [stdout] | ____________^ [INFO] [stdout] 184 | | w, [INFO] [stdout] 185 | | info, [INFO] [stdout] 186 | | options: Options::default(), [INFO] [stdout] 187 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder.rs:280:9 [INFO] [stdout] | [INFO] [stdout] 279 | pub fn write_header(self) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 280 | Writer::new(self.w, PartialInfo::new(&self.info), self.options).init(&self.info) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder.rs:1039:27 [INFO] [stdout] | [INFO] [stdout] 1038 | pub fn into_stream_writer_with_size(self, size: usize) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1039 | StreamWriter::new(ChunkOutput::Owned(self), size) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/encoder.rs:1350:12 [INFO] [stdout] | [INFO] [stdout] 1329 | fn new(writer: ChunkOutput<'a, W>, buf_len: usize) -> Result> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1345 | let mut chunk_writer = ChunkWriter::new(writer, buf_len); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1348 | let zlib = ZlibEncoder::new(chunk_writer, compression.to_options()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1349 | [INFO] [stdout] 1350 | Ok(StreamWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 1351 | | writer: Wrapper::Zlib(zlib), [INFO] [stdout] 1352 | | index: 0, [INFO] [stdout] 1353 | | prev_buf, [INFO] [stdout] ... | [INFO] [stdout] 1363 | | compression, [INFO] [stdout] 1364 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `png` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "ab7ecc9c766eea945166e1f6674c986ee8be4cdf72c060ceb741258c930c4e58", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ab7ecc9c766eea945166e1f6674c986ee8be4cdf72c060ceb741258c930c4e58", kill_on_drop: false }` [INFO] [stdout] ab7ecc9c766eea945166e1f6674c986ee8be4cdf72c060ceb741258c930c4e58