[INFO] fetching crate pnav 0.1.0... [INFO] checking pnav-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pnav 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate pnav 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pnav 0.1.0 [INFO] finished tweaking crates.io crate pnav 0.1.0 [INFO] tweaked toml for crates.io crate pnav 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate pnav 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a4895b990ea0b2119443858ca3fcaf3fc99dc5ceab37534ccf6ca5fbaa716fcd [INFO] running `Command { std: "docker" "start" "-a" "a4895b990ea0b2119443858ca3fcaf3fc99dc5ceab37534ccf6ca5fbaa716fcd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a4895b990ea0b2119443858ca3fcaf3fc99dc5ceab37534ccf6ca5fbaa716fcd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4895b990ea0b2119443858ca3fcaf3fc99dc5ceab37534ccf6ca5fbaa716fcd", kill_on_drop: false }` [INFO] [stdout] a4895b990ea0b2119443858ca3fcaf3fc99dc5ceab37534ccf6ca5fbaa716fcd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a6119c81273dcfaf851efe55e8a283a478edd32f9ab9197f34bb9cef7430b5b6 [INFO] running `Command { std: "docker" "start" "-a" "a6119c81273dcfaf851efe55e8a283a478edd32f9ab9197f34bb9cef7430b5b6", kill_on_drop: false }` [INFO] [stderr] Checking pnav v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/lib.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/lib.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `Settings` [INFO] [stdout] --> src/manipulate_pnavrc.rs:55:25 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn write_pnavrc(Settings: Settings) {} [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_Settings` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/lib.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn run(args: Vec) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `path_to_input_database` and `current_project_code` are never read [INFO] [stdout] --> src/manipulate_pnavrc.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Settings <'a> { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 8 | pnavrc_file_path: &'a str, [INFO] [stdout] 9 | pub path_to_input_database: &'a str, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 10 | pub current_project_code: &'a str, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Settings` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `write_pnavrc` is never used [INFO] [stdout] --> src/manipulate_pnavrc.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl<'a> Settings<'a> { [INFO] [stdout] | --------------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn write_pnavrc(Settings: Settings) {} [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Settings` should have a snake case name [INFO] [stdout] --> src/manipulate_pnavrc.rs:55:25 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn write_pnavrc(Settings: Settings) {} [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `settings` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Settings` should have a snake case name [INFO] [stdout] --> src/manipulate_pnavrc.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | let mut Settings = Settings::new("002001"); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `Settings` [INFO] [stdout] --> src/manipulate_pnavrc.rs:55:25 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn write_pnavrc(Settings: Settings) {} [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_Settings` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `args` [INFO] [stdout] --> src/lib.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn run(args: Vec) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_args` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `path_to_input_database` and `current_project_code` are never read [INFO] [stdout] --> src/manipulate_pnavrc.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct Settings <'a> { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 8 | pnavrc_file_path: &'a str, [INFO] [stdout] 9 | pub path_to_input_database: &'a str, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 10 | pub current_project_code: &'a str, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Settings` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `write_pnavrc` is never used [INFO] [stdout] --> src/manipulate_pnavrc.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl<'a> Settings<'a> { [INFO] [stdout] | --------------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 55 | pub fn write_pnavrc(Settings: Settings) {} [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Settings` should have a snake case name [INFO] [stdout] --> src/manipulate_pnavrc.rs:55:25 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn write_pnavrc(Settings: Settings) {} [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `settings` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Settings` should have a snake case name [INFO] [stdout] --> src/manipulate_pnavrc.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | let mut Settings = Settings::new("002001"); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case (notice the capitalization): `settings` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/manipulate_pnavrc.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | Settings.read_pnavrc(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 60 | let _ = Settings.read_pnavrc(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigate_folders.rs:32:11 [INFO] [stdout] | [INFO] [stdout] 21 | let root_dir = fs::read_dir(input_root_path)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let mut input_dir: Vec = root_dir.map(|x| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | match input_dir.pop() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/manipulate_pnavrc.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | Settings.read_pnavrc(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 60 | let _ = Settings.read_pnavrc(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/navigate_folders.rs:32:11 [INFO] [stdout] | [INFO] [stdout] 21 | let root_dir = fs::read_dir(input_root_path)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let mut input_dir: Vec = root_dir.map(|x| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | match input_dir.pop() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pnav` (lib) due to 2 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `pnav` (lib test) due to 2 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a6119c81273dcfaf851efe55e8a283a478edd32f9ab9197f34bb9cef7430b5b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a6119c81273dcfaf851efe55e8a283a478edd32f9ab9197f34bb9cef7430b5b6", kill_on_drop: false }` [INFO] [stdout] a6119c81273dcfaf851efe55e8a283a478edd32f9ab9197f34bb9cef7430b5b6