[INFO] fetching crate pmtree 2.0.0... [INFO] checking pmtree-2.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pmtree 2.0.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate pmtree 2.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pmtree 2.0.0 [INFO] finished tweaking crates.io crate pmtree 2.0.0 [INFO] tweaked toml for crates.io crate pmtree 2.0.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 47 packages to latest compatible versions [INFO] [stderr] Adding ark-serialize v0.3.0 (latest: v0.4.2) [INFO] [stderr] Adding ark-std v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hex-literal v0.3.4 (latest: v0.4.1) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding rayon v1.7.0 (latest: v1.10.0) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 851b7299cc9c3a807141174593e53cd2a70ff405e55edec16de3a9568ead037d [INFO] running `Command { std: "docker" "start" "-a" "851b7299cc9c3a807141174593e53cd2a70ff405e55edec16de3a9568ead037d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "851b7299cc9c3a807141174593e53cd2a70ff405e55edec16de3a9568ead037d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "851b7299cc9c3a807141174593e53cd2a70ff405e55edec16de3a9568ead037d", kill_on_drop: false }` [INFO] [stdout] 851b7299cc9c3a807141174593e53cd2a70ff405e55edec16de3a9568ead037d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eec66d9168c30fc8aa0be54f071b386c4236742088a04c355e17a47f671d2703 [INFO] running `Command { std: "docker" "start" "-a" "eec66d9168c30fc8aa0be54f071b386c4236742088a04c355e17a47f671d2703", kill_on_drop: false }` [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Compiling hex-literal v0.3.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking sled v0.34.7 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ark-std v0.3.0 [INFO] [stderr] Checking ark-serialize v0.3.0 [INFO] [stderr] Checking pmtree v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(depth: usize, db_config: D::Config) -> PmtreeResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | // Create new db instance [INFO] [stdout] 57 | let mut db = D::new(db_config)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | db, [INFO] [stdout] 83 | | depth, [INFO] [stdout] 84 | | next_index, [INFO] [stdout] 85 | | cache, [INFO] [stdout] 86 | | root, [INFO] [stdout] 87 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn load(db_config: D::Config) -> PmtreeResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | // Load existing db instance [INFO] [stdout] 93 | let db = D::load(db_config)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 120 | | db, [INFO] [stdout] 121 | | depth, [INFO] [stdout] 122 | | next_index, [INFO] [stdout] 123 | | cache, [INFO] [stdout] 124 | | root, [INFO] [stdout] 125 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 214 | leaves: I, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | leaves.into_iter().collect::>().as_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:244:59 [INFO] [stdout] | [INFO] [stdout] 244 | .install(|| Self::batch_recalculate(root_key, Arc::clone(&subtree), self.depth)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:321:52 [INFO] [stdout] | [INFO] [stdout] 321 | || Self::batch_recalculate(left_child, Arc::clone(&subtree), depth), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:322:53 [INFO] [stdout] | [INFO] [stdout] 322 | || Self::batch_recalculate(right_child, Arc::clone(&subtree), depth), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pmtree` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(depth: usize, db_config: D::Config) -> PmtreeResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | // Create new db instance [INFO] [stdout] 57 | let mut db = D::new(db_config)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | db, [INFO] [stdout] 83 | | depth, [INFO] [stdout] 84 | | next_index, [INFO] [stdout] 85 | | cache, [INFO] [stdout] 86 | | root, [INFO] [stdout] 87 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn load(db_config: D::Config) -> PmtreeResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | // Load existing db instance [INFO] [stdout] 93 | let db = D::load(db_config)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 120 | | db, [INFO] [stdout] 121 | | depth, [INFO] [stdout] 122 | | next_index, [INFO] [stdout] 123 | | cache, [INFO] [stdout] 124 | | root, [INFO] [stdout] 125 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 214 | leaves: I, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | leaves.into_iter().collect::>().as_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:244:59 [INFO] [stdout] | [INFO] [stdout] 244 | .install(|| Self::batch_recalculate(root_key, Arc::clone(&subtree), self.depth)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:321:52 [INFO] [stdout] | [INFO] [stdout] 321 | || Self::batch_recalculate(left_child, Arc::clone(&subtree), depth), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:322:53 [INFO] [stdout] | [INFO] [stdout] 322 | || Self::batch_recalculate(right_child, Arc::clone(&subtree), depth), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pmtree` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "eec66d9168c30fc8aa0be54f071b386c4236742088a04c355e17a47f671d2703", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eec66d9168c30fc8aa0be54f071b386c4236742088a04c355e17a47f671d2703", kill_on_drop: false }` [INFO] [stdout] eec66d9168c30fc8aa0be54f071b386c4236742088a04c355e17a47f671d2703