[INFO] fetching crate pm-remez 0.1.0... [INFO] checking pm-remez-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pm-remez 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate pm-remez 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pm-remez 0.1.0 [INFO] finished tweaking crates.io crate pm-remez 0.1.0 [INFO] tweaked toml for crates.io crate pm-remez 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 209 packages to latest compatible versions [INFO] [stderr] Adding approx v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding dirs v3.0.2 (latest: v5.0.1) [INFO] [stderr] Adding dirs-sys v0.3.7 (latest: v0.4.1) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding ndarray v0.15.6 (latest: v0.16.1) [INFO] [stderr] Adding ocipkg v0.2.9 (latest: v0.3.9) [INFO] [stderr] Adding pyo3 v0.21.2 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-build-config v0.21.2 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-ffi v0.21.2 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-macros v0.21.2 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-macros-backend v0.21.2 (latest: v0.22.2) [INFO] [stderr] Adding rustls-native-certs v0.7.3 (latest: v0.8.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2944ee98aca2d86649dfae9be645b18c6b244db74dc0106f2036c2115d7edb8c [INFO] running `Command { std: "docker" "start" "-a" "2944ee98aca2d86649dfae9be645b18c6b244db74dc0106f2036c2115d7edb8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2944ee98aca2d86649dfae9be645b18c6b244db74dc0106f2036c2115d7edb8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2944ee98aca2d86649dfae9be645b18c6b244db74dc0106f2036c2115d7edb8c", kill_on_drop: false }` [INFO] [stdout] 2944ee98aca2d86649dfae9be645b18c6b244db74dc0106f2036c2115d7edb8c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e5141c0d9e91a44b66922d2ad5fc627847353f3117101cd5d84acdf6bc25d573 [INFO] running `Command { std: "docker" "start" "-a" "e5141c0d9e91a44b66922d2ad5fc627847353f3117101cd5d84acdf6bc25d573", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Compiling rustfft v6.2.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking cblas-sys v0.1.4 [INFO] [stderr] Checking lapack-sys v0.14.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking transpose v0.2.3 [INFO] [stderr] Checking primal-check v0.3.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling katexit v0.1.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking cauchy v0.4.0 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Checking lax v0.16.0 [INFO] [stderr] Checking ndarray-linalg v0.16.0 [INFO] [stderr] Checking pm-remez v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/barycentric.rs:28:30 [INFO] [stdout] | [INFO] [stdout] 19 | key: F, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | x.iter().enumerate().map(move |(k, xk)| { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 29 | | let mut prod = one; [INFO] [stdout] 30 | | for a in 0..stride { [INFO] [stdout] 31 | | for j in (a..x.len()).step_by(stride) { [INFO] [stdout] ... | [INFO] [stdout] 37 | | prod.recip() [INFO] [stdout] 38 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/extrema.rs:202:8 [INFO] [stdout] | [INFO] [stdout] 123 | desired: D, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | weights: W, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let mut colleague = Array2::::zeros((s, s)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let colleague = T::array_to_lapack(colleague); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | let eig = colleague.eigvals().map_err(Error::EigenvaluesError)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | Ok(eig.into_iter().filter_map(move |z| { [INFO] [stdout] | ________^ [INFO] [stdout] 203 | | if Float::abs(z.im()) < threshold { [INFO] [stdout] 204 | | let x0 = T::from_lapack(&::from_real(z.re())); [INFO] [stdout] 205 | | if limits.contains(&x0) { [INFO] [stdout] ... | [INFO] [stdout] 215 | | } [INFO] [stdout] 216 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/requirements.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 100 | desired_response: Setting, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | weight: Setting, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(BandSetting { [INFO] [stdout] | ____________^ [INFO] [stdout] 105 | | band, [INFO] [stdout] 106 | | desired_response, [INFO] [stdout] 107 | | weight, [INFO] [stdout] 108 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/requirements.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn function(f: Box T>) -> Setting { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | Setting(SettingData::Function { f }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:319:12 [INFO] [stdout] | [INFO] [stdout] 316 | desired_response: D, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | weights: W, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 318 | ) -> Result { [INFO] [stdout] 319 | Ok(PMParameters { [INFO] [stdout] | ____________^ [INFO] [stdout] 320 | | num_taps, [INFO] [stdout] 321 | | bands, [INFO] [stdout] 322 | | symmetry: Symmetry::Even, [INFO] [stdout] ... | [INFO] [stdout] 327 | | flatness_threshold: T::from(1e-3).unwrap(), [INFO] [stdout] 328 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pm-remez` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "e5141c0d9e91a44b66922d2ad5fc627847353f3117101cd5d84acdf6bc25d573", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5141c0d9e91a44b66922d2ad5fc627847353f3117101cd5d84acdf6bc25d573", kill_on_drop: false }` [INFO] [stdout] e5141c0d9e91a44b66922d2ad5fc627847353f3117101cd5d84acdf6bc25d573