[INFO] fetching crate ply-rs 0.1.3... [INFO] checking ply-rs-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ply-rs 0.1.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate ply-rs 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ply-rs 0.1.3 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate ply-rs 0.1.3 [INFO] tweaked toml for crates.io crate ply-rs 0.1.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate ply-rs 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1277ad09da3f9482f95c5817f912a8b0056fe490d2e6d8ed42b74d6cc8d21979 [INFO] running `Command { std: "docker" "start" "-a" "1277ad09da3f9482f95c5817f912a8b0056fe490d2e6d8ed42b74d6cc8d21979", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1277ad09da3f9482f95c5817f912a8b0056fe490d2e6d8ed42b74d6cc8d21979", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1277ad09da3f9482f95c5817f912a8b0056fe490d2e6d8ed42b74d6cc8d21979", kill_on_drop: false }` [INFO] [stdout] 1277ad09da3f9482f95c5817f912a8b0056fe490d2e6d8ed42b74d6cc8d21979 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b5dc7e8662bbbd185cdef851b167fbdae6a16b362302ede74fd0bea2626b9621 [INFO] running `Command { std: "docker" "start" "-a" "b5dc7e8662bbbd185cdef851b167fbdae6a16b362302ede74fd0bea2626b9621", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.76 [INFO] [stderr] Compiling serde v1.0.115 [INFO] [stderr] Compiling proc-macro2 v1.0.19 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling syn v1.0.39 [INFO] [stderr] Compiling serde_json v1.0.57 [INFO] [stderr] Compiling serde_derive v1.0.115 [INFO] [stderr] Compiling adler v0.2.3 [INFO] [stderr] Compiling gimli v0.22.0 [INFO] [stderr] Compiling pulldown-cmark v0.2.0 [INFO] [stderr] Compiling miniz_oxide v0.4.1 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling rustc-demangle v0.1.16 [INFO] [stderr] Compiling object v0.20.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling itoa v0.4.6 [INFO] [stderr] Compiling rand v0.4.6 [INFO] [stderr] Compiling remove_dir_all v0.5.3 [INFO] [stderr] Compiling walkdir v2.3.1 [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Compiling glob v0.2.11 [INFO] [stderr] Compiling bytecount v0.4.0 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling addr2line v0.13.0 [INFO] [stderr] Checking semver-parser v0.7.0 [INFO] [stderr] Compiling peg-runtime v0.6.3 [INFO] [stderr] Compiling backtrace v0.3.50 [INFO] [stderr] Compiling peg-macros v0.6.3 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking linked-hash-map v0.5.3 [INFO] [stderr] Checking peg v0.6.3 [INFO] [stderr] Compiling cargo_metadata v0.6.4 [INFO] [stderr] Checking skeptic v0.13.4 [INFO] [stderr] Compiling ply-rs v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/parser/mod.rs:179:42 [INFO] [stdout] | [INFO] [stdout] 179 | Ok(l @ Line::MagicNumber) => (l), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 179 - Ok(l @ Line::MagicNumber) => (l), [INFO] [stdout] 179 + Ok(l @ Line::MagicNumber) => l, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/parser/mod.rs:199:44 [INFO] [stdout] | [INFO] [stdout] 199 | Ok(Line::Format(ref t)) => ( [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 200 | | if header_form_ver.is_none() { [INFO] [stdout] | |____________________^ [INFO] [stdout] ... [INFO] [stdout] 216 | } [INFO] [stdout] | ______________________^ [INFO] [stdout] 217 | | ), [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 199 ~ Ok(Line::Format(ref t)) => if header_form_ver.is_none() { [INFO] [stdout] 200 | header_form_ver = Some(t.clone()); [INFO] [stdout] ... [INFO] [stdout] 214 | } [INFO] [stdout] 215 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/parser/mod.rs:218:45 [INFO] [stdout] | [INFO] [stdout] 218 | Ok(Line::ObjInfo(ref o)) => ( [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 219 | | header_obj_infos.push(o.clone()) [INFO] [stdout] | | ____________________^________________________________^ [INFO] [stdout] | ||____________________| [INFO] [stdout] | | [INFO] [stdout] 220 | | ), [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 218 - Ok(Line::ObjInfo(ref o)) => ( [INFO] [stdout] 219 - header_obj_infos.push(o.clone()) [INFO] [stdout] 218 + Ok(Line::ObjInfo(ref o)) => header_obj_infos.push(o.clone()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/parser/mod.rs:221:45 [INFO] [stdout] | [INFO] [stdout] 221 | Ok(Line::Comment(ref c)) => ( [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 222 | | header_comments.push(c.clone()) [INFO] [stdout] | | ____________________^_______________________________^ [INFO] [stdout] | ||____________________| [INFO] [stdout] | | [INFO] [stdout] 223 | | ), [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 221 - Ok(Line::Comment(ref c)) => ( [INFO] [stdout] 222 - header_comments.push(c.clone()) [INFO] [stdout] 221 + Ok(Line::Comment(ref c)) => header_comments.push(c.clone()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/parser/mod.rs:227:42 [INFO] [stdout] | [INFO] [stdout] 227 | Ok(Line::Property(p)) => ( [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 228 | | if header_elements.is_empty() { [INFO] [stdout] | |____________________^ [INFO] [stdout] ... [INFO] [stdout] 238 | } [INFO] [stdout] | ______________________^ [INFO] [stdout] 239 | | ), [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 227 ~ Ok(Line::Property(p)) => if header_elements.is_empty() { [INFO] [stdout] 228 | return parse_ascii_error( [INFO] [stdout] ... [INFO] [stdout] 236 | header_elements.add(e); [INFO] [stdout] 237 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/parser/mod.rs:179:42 [INFO] [stdout] | [INFO] [stdout] 179 | Ok(l @ Line::MagicNumber) => (l), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 179 - Ok(l @ Line::MagicNumber) => (l), [INFO] [stdout] 179 + Ok(l @ Line::MagicNumber) => l, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/parser/mod.rs:199:44 [INFO] [stdout] | [INFO] [stdout] 199 | Ok(Line::Format(ref t)) => ( [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 200 | | if header_form_ver.is_none() { [INFO] [stdout] | |____________________^ [INFO] [stdout] ... [INFO] [stdout] 216 | } [INFO] [stdout] | ______________________^ [INFO] [stdout] 217 | | ), [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 199 ~ Ok(Line::Format(ref t)) => if header_form_ver.is_none() { [INFO] [stdout] 200 | header_form_ver = Some(t.clone()); [INFO] [stdout] ... [INFO] [stdout] 214 | } [INFO] [stdout] 215 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/parser/mod.rs:218:45 [INFO] [stdout] | [INFO] [stdout] 218 | Ok(Line::ObjInfo(ref o)) => ( [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 219 | | header_obj_infos.push(o.clone()) [INFO] [stdout] | | ____________________^________________________________^ [INFO] [stdout] | ||____________________| [INFO] [stdout] | | [INFO] [stdout] 220 | | ), [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 218 - Ok(Line::ObjInfo(ref o)) => ( [INFO] [stdout] 219 - header_obj_infos.push(o.clone()) [INFO] [stdout] 218 + Ok(Line::ObjInfo(ref o)) => header_obj_infos.push(o.clone()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/parser/mod.rs:221:45 [INFO] [stdout] | [INFO] [stdout] 221 | Ok(Line::Comment(ref c)) => ( [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 222 | | header_comments.push(c.clone()) [INFO] [stdout] | | ____________________^_______________________________^ [INFO] [stdout] | ||____________________| [INFO] [stdout] | | [INFO] [stdout] 223 | | ), [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 221 - Ok(Line::Comment(ref c)) => ( [INFO] [stdout] 222 - header_comments.push(c.clone()) [INFO] [stdout] 221 + Ok(Line::Comment(ref c)) => header_comments.push(c.clone()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/parser/mod.rs:227:42 [INFO] [stdout] | [INFO] [stdout] 227 | Ok(Line::Property(p)) => ( [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 228 | | if header_elements.is_empty() { [INFO] [stdout] | |____________________^ [INFO] [stdout] ... [INFO] [stdout] 238 | } [INFO] [stdout] | ______________________^ [INFO] [stdout] 239 | | ), [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 227 ~ Ok(Line::Property(p)) => if header_elements.is_empty() { [INFO] [stdout] 228 | return parse_ascii_error( [INFO] [stdout] ... [INFO] [stdout] 236 | header_elements.add(e); [INFO] [stdout] 237 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 16 | fn parse_ascii_rethrow(location: &LocationTracker, line_str: &str, e: E, message: &str) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Err(io::Error::new( [INFO] [stdout] | _________^ [INFO] [stdout] 18 | | ErrorKind::InvalidInput, [INFO] [stdout] 19 | | format!("Line {}: {}\n\tString: '{}'\n\tError: {:?}", location.line_index, message, line_str, e) [INFO] [stdout] 20 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:251:12 [INFO] [stdout] | [INFO] [stdout] 188 | let mut header_elements = KeyMap::::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | Ok(Header{ [INFO] [stdout] | ____________^ [INFO] [stdout] 252 | | encoding: encoding, [INFO] [stdout] 253 | | version: version, [INFO] [stdout] 254 | | obj_infos: header_obj_infos, [INFO] [stdout] 255 | | comments: header_comments, [INFO] [stdout] 256 | | elements: header_elements [INFO] [stdout] 257 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ply-rs` (lib) due to 3 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 16 | fn parse_ascii_rethrow(location: &LocationTracker, line_str: &str, e: E, message: &str) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Err(io::Error::new( [INFO] [stdout] | _________^ [INFO] [stdout] 18 | | ErrorKind::InvalidInput, [INFO] [stdout] 19 | | format!("Line {}: {}\n\tString: '{}'\n\tError: {:?}", location.line_index, message, line_str, e) [INFO] [stdout] 20 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:251:12 [INFO] [stdout] | [INFO] [stdout] 188 | let mut header_elements = KeyMap::::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | Ok(Header{ [INFO] [stdout] | ____________^ [INFO] [stdout] 252 | | encoding: encoding, [INFO] [stdout] 253 | | version: version, [INFO] [stdout] 254 | | obj_infos: header_obj_infos, [INFO] [stdout] 255 | | comments: header_comments, [INFO] [stdout] 256 | | elements: header_elements [INFO] [stdout] 257 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/parser/mod.rs:630:37 [INFO] [stdout] | [INFO] [stdout] 630 | assert!(properties.is_ok(), format!("error: {:?}", properties)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 630 - assert!(properties.is_ok(), format!("error: {:?}", properties)); [INFO] [stdout] 630 + assert!(properties.is_ok(), "error: {:?}", properties); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ply-rs` (lib test) due to 3 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b5dc7e8662bbbd185cdef851b167fbdae6a16b362302ede74fd0bea2626b9621", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b5dc7e8662bbbd185cdef851b167fbdae6a16b362302ede74fd0bea2626b9621", kill_on_drop: false }` [INFO] [stdout] b5dc7e8662bbbd185cdef851b167fbdae6a16b362302ede74fd0bea2626b9621