[INFO] fetching crate plthook 0.2.2... [INFO] checking plthook-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate plthook 0.2.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate plthook 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate plthook 0.2.2 [INFO] finished tweaking crates.io crate plthook 0.2.2 [INFO] tweaked toml for crates.io crate plthook 0.2.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate plthook 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e7e8e00ce7b0b91600d35cfaca66d3ac4e767ec8fd2b678cfae76e2ea7c72c68 [INFO] running `Command { std: "docker" "start" "-a" "e7e8e00ce7b0b91600d35cfaca66d3ac4e767ec8fd2b678cfae76e2ea7c72c68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e7e8e00ce7b0b91600d35cfaca66d3ac4e767ec8fd2b678cfae76e2ea7c72c68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e7e8e00ce7b0b91600d35cfaca66d3ac4e767ec8fd2b678cfae76e2ea7c72c68", kill_on_drop: false }` [INFO] [stdout] e7e8e00ce7b0b91600d35cfaca66d3ac4e767ec8fd2b678cfae76e2ea7c72c68 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 489f0cea869e3e6b6ed4967f0eacd859f7baee5d80a47d11ddd877d3e918419b [INFO] running `Command { std: "docker" "start" "-a" "489f0cea869e3e6b6ed4967f0eacd859f7baee5d80a47d11ddd877d3e918419b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling cc v1.0.69 [INFO] [stderr] Compiling plthook v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 200 | let symbol_name = match CString::new(symbol_name) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | Ok(s) => s, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | Ok(Replacement { [INFO] [stdout] | ____________^ [INFO] [stdout] 218 | | restore_ref: Some(RestoreRef { [INFO] [stdout] 219 | | object: Rc::clone(&self.0), [INFO] [stdout] 220 | | symbol_name, [INFO] [stdout] 221 | | }), [INFO] [stdout] 222 | | address: old_addr.assume_init(), [INFO] [stdout] 223 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:80:14 [INFO] [stdout] | [INFO] [stdout] 77 | let name = unsafe { CStr::from_ptr(name.assume_init()).into() }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | Some(Symbol { name, func_address }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `plthook` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 200 | let symbol_name = match CString::new(symbol_name) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | Ok(s) => s, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | Ok(Replacement { [INFO] [stdout] | ____________^ [INFO] [stdout] 218 | | restore_ref: Some(RestoreRef { [INFO] [stdout] 219 | | object: Rc::clone(&self.0), [INFO] [stdout] 220 | | symbol_name, [INFO] [stdout] 221 | | }), [INFO] [stdout] 222 | | address: old_addr.assume_init(), [INFO] [stdout] 223 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/symbols.rs:80:14 [INFO] [stdout] | [INFO] [stdout] 77 | let name = unsafe { CStr::from_ptr(name.assume_init()).into() }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | Some(Symbol { name, func_address }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `plthook` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "489f0cea869e3e6b6ed4967f0eacd859f7baee5d80a47d11ddd877d3e918419b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "489f0cea869e3e6b6ed4967f0eacd859f7baee5d80a47d11ddd877d3e918419b", kill_on_drop: false }` [INFO] [stdout] 489f0cea869e3e6b6ed4967f0eacd859f7baee5d80a47d11ddd877d3e918419b