[INFO] fetching crate plotlib 0.5.1... [INFO] checking plotlib-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate plotlib 0.5.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate plotlib 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate plotlib 0.5.1 [INFO] finished tweaking crates.io crate plotlib 0.5.1 [INFO] tweaked toml for crates.io crate plotlib 0.5.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate plotlib 0.5.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 702bf0ca923dd2b08a9710dc8dccf71b1677fa3936fbf622c559a726dc3db3ff [INFO] running `Command { std: "docker" "start" "-a" "702bf0ca923dd2b08a9710dc8dccf71b1677fa3936fbf622c559a726dc3db3ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "702bf0ca923dd2b08a9710dc8dccf71b1677fa3936fbf622c559a726dc3db3ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "702bf0ca923dd2b08a9710dc8dccf71b1677fa3936fbf622c559a726dc3db3ff", kill_on_drop: false }` [INFO] [stdout] 702bf0ca923dd2b08a9710dc8dccf71b1677fa3936fbf622c559a726dc3db3ff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7ead207e96d841d715cfce273018800ed3a6c2e154ec7fe32b579cd90c3f32d4 [INFO] running `Command { std: "docker" "start" "-a" "7ead207e96d841d715cfce273018800ed3a6c2e154ec7fe32b579cd90c3f32d4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling libc v0.2.67 [INFO] [stderr] Compiling syn v1.0.16 [INFO] [stderr] Compiling failure_derive v0.1.7 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking svg v0.7.1 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Compiling backtrace-sys v0.1.34 [INFO] [stderr] Checking backtrace v0.3.45 [INFO] [stderr] Compiling synstructure v0.12.3 [INFO] [stderr] Checking failure v0.1.7 [INFO] [stderr] Checking plotlib v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/utils.rs:23:47 [INFO] [stdout] | [INFO] [stdout] 23 | 0 => (s[(s.len() / 2) - 1] / 2.) + (s[(s.len() / 2)] / 2.), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 23 - 0 => (s[(s.len() / 2) - 1] / 2.) + (s[(s.len() / 2)] / 2.), [INFO] [stdout] 23 + 0 => (s[(s.len() / 2) - 1] / 2.) + (s[s.len() / 2] / 2.), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/utils.rs:23:47 [INFO] [stdout] | [INFO] [stdout] 23 | 0 => (s[(s.len() / 2) - 1] / 2.) + (s[(s.len() / 2)] / 2.), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 23 - 0 => (s[(s.len() / 2) - 1] / 2.) + (s[(s.len() / 2)] / 2.), [INFO] [stdout] 23 + 0 => (s[(s.len() / 2) - 1] / 2.) + (s[s.len() / 2] / 2.), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `line_style` [INFO] [stdout] --> src/repr/plot.rs:182:38 [INFO] [stdout] | [INFO] [stdout] 182 | let face_lines = if let Some(line_style) = &self.line_style { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_line_style` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `line_style` [INFO] [stdout] --> src/repr/plot.rs:182:38 [INFO] [stdout] | [INFO] [stdout] 182 | let face_lines = if let Some(line_style) = &self.line_style { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_line_style` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg_render.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 18 | fn vertical_line(xpos: f64, ymin: f64, ymax: f64, color: S) -> node::element::Line [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | / node::element::Line::new() [INFO] [stdout] 23 | | .set("x1", xpos) [INFO] [stdout] 24 | | .set("x2", xpos) [INFO] [stdout] 25 | | .set("y1", ymin) [INFO] [stdout] 26 | | .set("y2", ymax) [INFO] [stdout] 27 | | .set("stroke", color.as_ref()) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg_render.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 31 | fn horizontal_line(ypos: f64, xmin: f64, xmax: f64, color: S) -> node::element::Line [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | / node::element::Line::new() [INFO] [stdout] 36 | | .set("x1", xmin) [INFO] [stdout] 37 | | .set("x2", xmax) [INFO] [stdout] 38 | | .set("y1", ypos) [INFO] [stdout] 39 | | .set("y2", ypos) [INFO] [stdout] 40 | | .set("stroke", color.as_ref()) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg_render.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 45 | let axis_line = horizontal_line(0.0, 0.0, face_width, "black"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | [INFO] [stdout] 47 | let mut ticks = node::element::Group::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let mut labels = node::element::Group::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let label = node::element::Text::new() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | / node::element::Group::new() [INFO] [stdout] 78 | | .add(ticks) [INFO] [stdout] 79 | | .add(axis_line) [INFO] [stdout] 80 | | .add(labels) [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg_render.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 85 | let axis_line = vertical_line(0.0, 0.0, -face_height, "black"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | [INFO] [stdout] 87 | let mut ticks = node::element::Group::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let mut labels = node::element::Group::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | let label = node::element::Text::new() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | / node::element::Group::new() [INFO] [stdout] 135 | | .add(ticks) [INFO] [stdout] 136 | | .add(axis_line) [INFO] [stdout] 137 | | .add(labels) [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg_render.rs:182:5 [INFO] [stdout] | [INFO] [stdout] 142 | let axis_line = node::element::Line::new() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let mut ticks = node::element::Group::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let mut labels = node::element::Group::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let label = node::element::Text::new() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | / node::element::Group::new() [INFO] [stdout] 183 | | .add(ticks) [INFO] [stdout] 184 | | .add(axis_line) [INFO] [stdout] 185 | | .add(labels) [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `plotlib` (lib) due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg_render.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 18 | fn vertical_line(xpos: f64, ymin: f64, ymax: f64, color: S) -> node::element::Line [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | / node::element::Line::new() [INFO] [stdout] 23 | | .set("x1", xpos) [INFO] [stdout] 24 | | .set("x2", xpos) [INFO] [stdout] 25 | | .set("y1", ymin) [INFO] [stdout] 26 | | .set("y2", ymax) [INFO] [stdout] 27 | | .set("stroke", color.as_ref()) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg_render.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 31 | fn horizontal_line(ypos: f64, xmin: f64, xmax: f64, color: S) -> node::element::Line [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | / node::element::Line::new() [INFO] [stdout] 36 | | .set("x1", xmin) [INFO] [stdout] 37 | | .set("x2", xmax) [INFO] [stdout] 38 | | .set("y1", ypos) [INFO] [stdout] 39 | | .set("y2", ypos) [INFO] [stdout] 40 | | .set("stroke", color.as_ref()) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg_render.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 45 | let axis_line = horizontal_line(0.0, 0.0, face_width, "black"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | [INFO] [stdout] 47 | let mut ticks = node::element::Group::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let mut labels = node::element::Group::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let label = node::element::Text::new() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | / node::element::Group::new() [INFO] [stdout] 78 | | .add(ticks) [INFO] [stdout] 79 | | .add(axis_line) [INFO] [stdout] 80 | | .add(labels) [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg_render.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 85 | let axis_line = vertical_line(0.0, 0.0, -face_height, "black"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | [INFO] [stdout] 87 | let mut ticks = node::element::Group::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let mut labels = node::element::Group::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | let label = node::element::Text::new() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | / node::element::Group::new() [INFO] [stdout] 135 | | .add(ticks) [INFO] [stdout] 136 | | .add(axis_line) [INFO] [stdout] 137 | | .add(labels) [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/svg_render.rs:182:5 [INFO] [stdout] | [INFO] [stdout] 142 | let axis_line = node::element::Line::new() [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let mut ticks = node::element::Group::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | let mut labels = node::element::Group::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let label = node::element::Text::new() [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | / node::element::Group::new() [INFO] [stdout] 183 | | .add(ticks) [INFO] [stdout] 184 | | .add(axis_line) [INFO] [stdout] 185 | | .add(labels) [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `plotlib` (lib test) due to 6 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7ead207e96d841d715cfce273018800ed3a6c2e154ec7fe32b579cd90c3f32d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ead207e96d841d715cfce273018800ed3a6c2e154ec7fe32b579cd90c3f32d4", kill_on_drop: false }` [INFO] [stdout] 7ead207e96d841d715cfce273018800ed3a6c2e154ec7fe32b579cd90c3f32d4