[INFO] fetching crate plex 0.3.1... [INFO] checking plex-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate plex 0.3.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate plex 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate plex 0.3.1 [INFO] finished tweaking crates.io crate plex 0.3.1 [INFO] tweaked toml for crates.io crate plex 0.3.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate plex 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 87c429519d84975238bf0b104ee3135b8f19ec46c55a5eff8319b5471582589b [INFO] running `Command { std: "docker" "start" "-a" "87c429519d84975238bf0b104ee3135b8f19ec46c55a5eff8319b5471582589b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "87c429519d84975238bf0b104ee3135b8f19ec46c55a5eff8319b5471582589b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87c429519d84975238bf0b104ee3135b8f19ec46c55a5eff8319b5471582589b", kill_on_drop: false }` [INFO] [stdout] 87c429519d84975238bf0b104ee3135b8f19ec46c55a5eff8319b5471582589b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 01bc2c0c0a64cee506e385c0ef9ffe1ebbd388499ce6f4db9c5c0e92aa440ae9 [INFO] running `Command { std: "docker" "start" "-a" "01bc2c0c0a64cee506e385c0ef9ffe1ebbd388499ce6f4db9c5c0e92aa440ae9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking winnow v0.6.11 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling trybuild v1.0.96 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking lalr v0.0.2 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking redfa v0.0.3 [INFO] [stderr] Checking quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking toml_edit v0.22.14 [INFO] [stderr] Checking plex v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lexer.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 126 | let lifetime; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | Ok(Lexer { [INFO] [stdout] | ____________^ [INFO] [stdout] 128 | | vis: input.parse()?, [INFO] [stdout] 129 | | name: { [INFO] [stdout] 130 | | input.parse::()?; [INFO] [stdout] ... | [INFO] [stdout] 155 | | rules: parse_rules(input)?, [INFO] [stdout] 156 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 20 | fn most_frequent>(it: I) -> Option { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let mut freq = BTreeMap::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | freq.into_iter().max_by_key(|&(_, f)| f).map(|(x, _)| x) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:91:27 [INFO] [stdout] | [INFO] [stdout] 91 | .map(|(i, k)| (k, Ident::new(&format!("reduce_{}", i), Span::call_site()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:98:31 [INFO] [stdout] | [INFO] [stdout] 98 | .map(|(i, lhs)| (lhs, Ident::new(&format!("goto_{}", i), Span::call_site()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:486:12 [INFO] [stdout] | [INFO] [stdout] 485 | let span_ty; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 486 | Ok(Parser { [INFO] [stdout] | ____________^ [INFO] [stdout] 487 | | vis: input.parse()?, [INFO] [stdout] 488 | | name: { [INFO] [stdout] 489 | | input.parse::()?; [INFO] [stdout] ... | [INFO] [stdout] 527 | | }, [INFO] [stdout] 528 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:699:26 [INFO] [stdout] | [INFO] [stdout] 655 | let mut expr = act.action.clone().into_token_stream(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 656 | let mut args = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 699 | (expr, args, act.head().span()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `plex` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "01bc2c0c0a64cee506e385c0ef9ffe1ebbd388499ce6f4db9c5c0e92aa440ae9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01bc2c0c0a64cee506e385c0ef9ffe1ebbd388499ce6f4db9c5c0e92aa440ae9", kill_on_drop: false }` [INFO] [stdout] 01bc2c0c0a64cee506e385c0ef9ffe1ebbd388499ce6f4db9c5c0e92aa440ae9