[INFO] fetching crate please 0.2.1... [INFO] checking please-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate please 0.2.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate please 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate please 0.2.1 [INFO] finished tweaking crates.io crate please 0.2.1 [INFO] tweaked toml for crates.io crate please 0.2.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 61 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding diesel v1.4.8 (latest: v2.2.3) [INFO] [stderr] Adding diesel_derives v1.4.1 (latest: v2.2.3) [INFO] [stderr] Adding dotenv v0.13.0 (latest: v0.15.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding pq-sys v0.4.8 (latest: v0.6.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 899aff8f466b1d0d3471b144eaaa97fed1055943389a57b192c2233c515c5810 [INFO] running `Command { std: "docker" "start" "-a" "899aff8f466b1d0d3471b144eaaa97fed1055943389a57b192c2233c515c5810", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "899aff8f466b1d0d3471b144eaaa97fed1055943389a57b192c2233c515c5810", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "899aff8f466b1d0d3471b144eaaa97fed1055943389a57b192c2233c515c5810", kill_on_drop: false }` [INFO] [stdout] 899aff8f466b1d0d3471b144eaaa97fed1055943389a57b192c2233c515c5810 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dc40ad313eafe6ee59f07fd1eb82e82c9960936952ad6de3f99b7518e61307a3 [INFO] running `Command { std: "docker" "start" "-a" "dc40ad313eafe6ee59f07fd1eb82e82c9960936952ad6de3f99b7518e61307a3", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Compiling pq-sys v0.4.8 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling diesel_derives v1.4.1 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking dotenv v0.13.0 [INFO] [stderr] Checking diesel v1.4.8 [INFO] [stderr] Checking please v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:195:32 [INFO] [stdout] | [INFO] [stdout] 195 | fn cause(&self) -> Option<&Error> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 195 | fn cause(&self) -> Option<&dyn Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:195:32 [INFO] [stdout] | [INFO] [stdout] 195 | fn cause(&self) -> Option<&Error> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 195 | fn cause(&self) -> Option<&dyn Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:180:56 [INFO] [stdout] | [INFO] [stdout] 180 | &PleaseError::Expired => Display::fmt(self.description(), f), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:189:48 [INFO] [stdout] | [INFO] [stdout] 189 | &PleaseError::Provider(ref e) => e.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:190:45 [INFO] [stdout] | [INFO] [stdout] 190 | &PleaseError::Query(ref e) => e.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:180:56 [INFO] [stdout] | [INFO] [stdout] 180 | &PleaseError::Expired => Display::fmt(self.description(), f), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:189:48 [INFO] [stdout] | [INFO] [stdout] 189 | &PleaseError::Provider(ref e) => e.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:190:45 [INFO] [stdout] | [INFO] [stdout] 190 | &PleaseError::Query(ref e) => e.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id`, `creation`, `expiry`, `title`, and `refresh_count` are never read [INFO] [stdout] --> src/lib.rs:148:5 [INFO] [stdout] | [INFO] [stdout] 147 | struct PleaseId { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 148 | id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] 149 | creation: NaiveDateTime, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 150 | expiry: NaiveDateTime, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 151 | title: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 152 | refresh_count: i32, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PleaseId` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib.rs:157:22 [INFO] [stdout] | [INFO] [stdout] 157 | pub struct ExpiredId(PleaseId); [INFO] [stdout] | --------- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ExpiredId` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:214:22 [INFO] [stdout] | [INFO] [stdout] 213 | fn from(other: diesel::result::Error) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | ErrorWrapper(PleaseError::Query(other).into(), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:219:22 [INFO] [stdout] | [INFO] [stdout] 218 | fn from(other: PleaseError

) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | ErrorWrapper(other.into(), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:252:9 [INFO] [stdout] | [INFO] [stdout] 248 | fn transaction_internal>, F: FnOnce(&P::Connection) -> Result>(provider: &P, f: F) -> Result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:252:29 [INFO] [stdout] | [INFO] [stdout] 248 | ...saction_internal>, F: FnOnce(&P::Connection) -> Result>(provider: &P, f: F) -> Result { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | ...n.transaction(|| f(&conn).map_err(|e| ErrorWrapper(e, PhantomData))) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:275:12 [INFO] [stdout] | [INFO] [stdout] 264 | pub fn new(provider: P, title: &str) -> PleaseResult { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | Ok(PleaseHandle { provider, id }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 292 | pub fn new_with_connection(provider: P, title: &str, conn: &C) -> QueryResult [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | Ok(PleaseHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 304 | | provider, [INFO] [stdout] 305 | | id, [INFO] [stdout] 306 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:346:52 [INFO] [stdout] | [INFO] [stdout] 339 | pub fn transaction(&mut self, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | Self::transaction_internal(&self.provider, |conn| { [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 347 | | // We simultaneously refresh the ID, *and* validate that [INFO] [stdout] 348 | | // it hasn't expired. [INFO] [stdout] 349 | | let num_rows = diesel::update( [INFO] [stdout] ... | [INFO] [stdout] 361 | | } [INFO] [stdout] 362 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `please` (lib) due to 8 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `id`, `creation`, `expiry`, `title`, and `refresh_count` are never read [INFO] [stdout] --> src/lib.rs:148:5 [INFO] [stdout] | [INFO] [stdout] 147 | struct PleaseId { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 148 | id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] 149 | creation: NaiveDateTime, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 150 | expiry: NaiveDateTime, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 151 | title: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 152 | refresh_count: i32, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PleaseId` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib.rs:157:22 [INFO] [stdout] | [INFO] [stdout] 157 | pub struct ExpiredId(PleaseId); [INFO] [stdout] | --------- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `ExpiredId` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:214:22 [INFO] [stdout] | [INFO] [stdout] 213 | fn from(other: diesel::result::Error) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | ErrorWrapper(PleaseError::Query(other).into(), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:219:22 [INFO] [stdout] | [INFO] [stdout] 218 | fn from(other: PleaseError

) -> Self { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | ErrorWrapper(other.into(), PhantomData) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:252:9 [INFO] [stdout] | [INFO] [stdout] 248 | fn transaction_internal>, F: FnOnce(&P::Connection) -> Result>(provider: &P, f: F) -> Result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:252:29 [INFO] [stdout] | [INFO] [stdout] 248 | ...saction_internal>, F: FnOnce(&P::Connection) -> Result>(provider: &P, f: F) -> Result { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | ...n.transaction(|| f(&conn).map_err(|e| ErrorWrapper(e, PhantomData))) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:275:12 [INFO] [stdout] | [INFO] [stdout] 264 | pub fn new(provider: P, title: &str) -> PleaseResult { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | Ok(PleaseHandle { provider, id }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 292 | pub fn new_with_connection(provider: P, title: &str, conn: &C) -> QueryResult [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | Ok(PleaseHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 304 | | provider, [INFO] [stdout] 305 | | id, [INFO] [stdout] 306 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:346:52 [INFO] [stdout] | [INFO] [stdout] 339 | pub fn transaction(&mut self, f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | Self::transaction_internal(&self.provider, |conn| { [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 347 | | // We simultaneously refresh the ID, *and* validate that [INFO] [stdout] 348 | | // it hasn't expired. [INFO] [stdout] 349 | | let num_rows = diesel::update( [INFO] [stdout] ... | [INFO] [stdout] 361 | | } [INFO] [stdout] 362 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:446:9 [INFO] [stdout] | [INFO] [stdout] 443 | let conn = TestConnectionProvider.get() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 446 | / conn.transaction(|| { [INFO] [stdout] 447 | | PleaseHandle::new_with_connection(TestConnectionProvider, name, &conn) [INFO] [stdout] 448 | | }).expect("Failed to run transaction") [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `please` (lib test) due to 9 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "dc40ad313eafe6ee59f07fd1eb82e82c9960936952ad6de3f99b7518e61307a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc40ad313eafe6ee59f07fd1eb82e82c9960936952ad6de3f99b7518e61307a3", kill_on_drop: false }` [INFO] [stdout] dc40ad313eafe6ee59f07fd1eb82e82c9960936952ad6de3f99b7518e61307a3