[INFO] fetching crate pkstl 0.1.0... [INFO] checking pkstl-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pkstl 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate pkstl 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pkstl 0.1.0 [INFO] finished tweaking crates.io crate pkstl 0.1.0 [INFO] tweaked toml for crates.io crate pkstl 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 59 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding ansi_term v0.11.0 (latest: v0.12.1) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding ctor v0.1.26 (latest: v0.2.8) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding pretty_assertions v0.6.1 (latest: v1.4.0) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding serde_cbor v0.10.2 (latest: v0.11.2) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 660b63fae7401130d9f346c028d94527d8a513359ddb5bd913f92416fc290ade [INFO] running `Command { std: "docker" "start" "-a" "660b63fae7401130d9f346c028d94527d8a513359ddb5bd913f92416fc290ade", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "660b63fae7401130d9f346c028d94527d8a513359ddb5bd913f92416fc290ade", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "660b63fae7401130d9f346c028d94527d8a513359ddb5bd913f92416fc290ade", kill_on_drop: false }` [INFO] [stdout] 660b63fae7401130d9f346c028d94527d8a513359ddb5bd913f92416fc290ade [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 075015049d0edc4878262964fb3219e41c494487cedad137c6eddf6da853beaa [INFO] running `Command { std: "docker" "start" "-a" "075015049d0edc4878262964fb3219e41c494487cedad137c6eddf6da853beaa", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Compiling clear_on_drop v0.2.5 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking chacha20-poly1305-aead v0.1.2 [INFO] [stderr] Checking pretty_assertions v0.6.1 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking backtrace v0.3.73 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking pkstl v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variants `B32` and `B64` are never constructed [INFO] [stdout] --> src/agreement.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 26 | pub enum SharedSecretLen { [INFO] [stdout] | --------------- variants in this enum [INFO] [stdout] 27 | B32, [INFO] [stdout] | ^^^ [INFO] [stdout] 28 | B48, [INFO] [stdout] 29 | B64, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SharedSecretLen` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agreement.rs:119:31 [INFO] [stdout] | [INFO] [stdout] 119 | |key_material| Ok(derive(key_material, salt, shared_secret_len)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/complete.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 49 | let msl_clone = self.minimal_secure_layer.try_clone()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | Ok(SecureLayer { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | minimal_secure_layer: msl_clone, [INFO] [stdout] 53 | | sig_key_pair: None, [INFO] [stdout] 54 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/complete.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 188 | let mut deflate_decoder = DeflateDecoder::new(Vec::with_capacity(bin_zip_msg.len() * 5)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | deflate_decoder.finish().map_err(Error::ZipError) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pkstl` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variant `B32` is never constructed [INFO] [stdout] --> src/agreement.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 26 | pub enum SharedSecretLen { [INFO] [stdout] | --------------- variant in this enum [INFO] [stdout] 27 | B32, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SharedSecretLen` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agreement.rs:119:31 [INFO] [stdout] | [INFO] [stdout] 119 | |key_material| Ok(derive(key_material, salt, shared_secret_len)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/complete.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 49 | let msl_clone = self.minimal_secure_layer.try_clone()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | Ok(SecureLayer { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | minimal_secure_layer: msl_clone, [INFO] [stdout] 53 | | sig_key_pair: None, [INFO] [stdout] 54 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/complete.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 188 | let mut deflate_decoder = DeflateDecoder::new(Vec::with_capacity(bin_zip_msg.len() * 5)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | deflate_decoder.finish().map_err(Error::ZipError) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pkstl` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "075015049d0edc4878262964fb3219e41c494487cedad137c6eddf6da853beaa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "075015049d0edc4878262964fb3219e41c494487cedad137c6eddf6da853beaa", kill_on_drop: false }` [INFO] [stdout] 075015049d0edc4878262964fb3219e41c494487cedad137c6eddf6da853beaa