[INFO] fetching crate pks 0.2.13... [INFO] checking pks-0.2.13 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pks 0.2.13 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate pks 0.2.13 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-3-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate pks 0.2.13 [INFO] finished tweaking crates.io crate pks 0.2.13 [INFO] tweaked toml for crates.io crate pks 0.2.13 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate pks 0.2.13 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5e4db8f5192a416f4e17eafa923bf89d94e568d1c133736e87d09cc24f75c823 [INFO] running `Command { std: "docker" "start" "-a" "5e4db8f5192a416f4e17eafa923bf89d94e568d1c133736e87d09cc24f75c823", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5e4db8f5192a416f4e17eafa923bf89d94e568d1c133736e87d09cc24f75c823", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e4db8f5192a416f4e17eafa923bf89d94e568d1c133736e87d09cc24f75c823", kill_on_drop: false }` [INFO] [stdout] 5e4db8f5192a416f4e17eafa923bf89d94e568d1c133736e87d09cc24f75c823 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2fb17d120b8e1032cda0108154dd494461e66cb7d61a1ebddb02b1e0a2495ad2 [INFO] running `Command { std: "docker" "start" "-a" "2fb17d120b8e1032cda0108154dd494461e66cb7d61a1ebddb02b1e0a2495ad2", kill_on_drop: false }` [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling serde v1.0.208 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling hashbrown v0.12.3 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Compiling fsio v0.1.3 [INFO] [stderr] Compiling lib-ruby-parser v4.0.6+ruby-3.1.2 [INFO] [stderr] Compiling serde_json v1.0.125 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Compiling envmnt v0.8.4 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking lib-ruby-parser-ast v0.55.0 [INFO] [stderr] Checking alloc-from-pool v1.0.5 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking ruby_inflector v0.0.8 [INFO] [stderr] Checking fnmatch-regex2 v0.3.0 [INFO] [stderr] Checking strip-ansi-escapes v0.2.0 [INFO] [stderr] Compiling ci_info v0.10.2 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking jwalk v0.8.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking serde_magnus v0.7.0 [INFO] [stderr] Checking line-col v0.2.1 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking path-clean v1.0.1 [INFO] [stderr] Compiling nias v0.5.0 [INFO] [stderr] Checking sdd v3.0.2 [INFO] [stderr] Compiling assert_cmd v2.0.16 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking scc v2.1.16 [INFO] [stderr] Checking predicates v3.1.2 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Compiling serde_derive v1.0.208 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling serial_test_derive v3.1.1 [INFO] [stderr] Compiling rusty-hook v0.11.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serial_test v3.1.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking pks v0.2.13 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `filepath` and `file_name_digest` are never read [INFO] [stdout] --> src/packs/caching/mod.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct EmptyCacheEntry { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] 15 | pub filepath: PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 16 | pub file_contents_digest: String, [INFO] [stdout] 17 | pub file_name_digest: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EmptyCacheEntry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/caching/per_file_cache.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 57 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | anyhow::Error::new(e).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/configuration.rs:148:8 [INFO] [stdout] | [INFO] [stdout] 108 | raw_config: RawConfiguration, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | walk_directory_result: WalkDirectoryResult, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | included_files, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | included_packs, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let pack_set = PackSet::build(included_packs, owning_package_yml_for_file)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let ignored_definitions = raw_config.ignored_definitions; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | Ok(Configuration { [INFO] [stdout] | ________^ [INFO] [stdout] 149 | | included_files, [INFO] [stdout] 150 | | absolute_root, [INFO] [stdout] 151 | | cache_enabled, [INFO] [stdout] ... | [INFO] [stdout] 168 | | disable_enforce_visibility: false, [INFO] [stdout] 169 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/pack.rs:207:13 [INFO] [stdout] | [INFO] [stdout] 206 | let mut file = File::open(package_yml_absolute_path).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | anyhow::Error::new(e).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/pack.rs:214:13 [INFO] [stdout] | [INFO] [stdout] 213 | file.read_to_string(&mut yaml_contents).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | anyhow::Error::new(e).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/pack.rs:417:9 [INFO] [stdout] | [INFO] [stdout] 416 | std::fs::create_dir_all(pack_dir).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 417 | anyhow::Error::new(e).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/pack.rs:424:9 [INFO] [stdout] | [INFO] [stdout] 423 | std::fs::write(&pack.yml, serialized_pack).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 424 | anyhow::Error::new(e) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/raw_configuration.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 95 | let mut file = File::open(&absolute_path_to_packwerk_yml).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | anyhow::Error::new(e).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/raw_configuration.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 103 | std::io::Read::read_to_string(&mut file, &mut contents).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | anyhow::Error::new(e).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/raw_configuration.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 110 | let configuration = serde_yaml::from_str(&contents).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | anyhow::Error::new(e).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/raw_configuration.rs:183:38 [INFO] [stdout] | [INFO] [stdout] 179 | fn visit_seq(self, seq: S) -> Result [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | Deserialize::deserialize(value::SeqAccessDeserializer::new(seq)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/walk_directory.rs:196:8 [INFO] [stdout] | [INFO] [stdout] 43 | let mut included_files: HashSet = HashSet::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let mut included_packs: HashSet = HashSet::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let all_excluded_dirs_set = build_glob_set(&all_excluded_dirs); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let excluded_dirs_ref = Arc::new(all_excluded_dirs_set); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | [INFO] [stdout] 69 | let absolute_root_ref = Arc::new(absolute_root.clone()); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | [INFO] [stdout] 71 | let includes_set = build_glob_set(&raw.include); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let excludes_set = build_glob_set(&raw.exclude); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let package_paths_set = build_glob_set(&raw.package_paths); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let walk_dir = WalkDirGeneric::::new(&absolute_root) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | Ok(WalkDirectoryResult { [INFO] [stdout] | ________^ [INFO] [stdout] 197 | | included_files, [INFO] [stdout] 198 | | included_packs, [INFO] [stdout] 199 | | owning_package_yml_for_file, [INFO] [stdout] 200 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/pack_set.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 34 | packs: HashSet, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let packs: Vec = packs [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let mut indexed_packs_by_name: HashMap = HashMap::new(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let mut all_violations = HashSet::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let indexed_packs = indexed_packs_by_name; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(PackSet { [INFO] [stdout] | ____________^ [INFO] [stdout] 72 | | indexed_packs, [INFO] [stdout] 73 | | packs, [INFO] [stdout] 74 | | all_violations, [INFO] [stdout] 75 | | owning_pack_name_for_file, [INFO] [stdout] 76 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pks` (lib) due to 13 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `filepath` and `file_name_digest` are never read [INFO] [stdout] --> src/packs/caching/mod.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct EmptyCacheEntry { [INFO] [stdout] | --------------- fields in this struct [INFO] [stdout] 15 | pub filepath: PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 16 | pub file_contents_digest: String, [INFO] [stdout] 17 | pub file_name_digest: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EmptyCacheEntry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/caching/per_file_cache.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 57 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | anyhow::Error::new(e).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/checker/common_test.rs:129:31 [INFO] [stdout] | [INFO] [stdout] 121 | let mut packs = vec![root_pack, test_checker.referencing_pack.clone()]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | pack_set: PackSet::build( [INFO] [stdout] | _______________________________^ [INFO] [stdout] 130 | | HashSet::from_iter(packs), [INFO] [stdout] 131 | | HashMap::new(), [INFO] [stdout] 132 | | ) [INFO] [stdout] 133 | | .unwrap(), [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/checker/common_test.rs:134:23 [INFO] [stdout] | [INFO] [stdout] 121 | let mut packs = vec![root_pack, test_checker.referencing_pack.clone()]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | ..Configuration::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/configuration.rs:148:8 [INFO] [stdout] | [INFO] [stdout] 108 | raw_config: RawConfiguration, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | walk_directory_result: WalkDirectoryResult, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | included_files, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | included_packs, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let pack_set = PackSet::build(included_packs, owning_package_yml_for_file)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let ignored_definitions = raw_config.ignored_definitions; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | Ok(Configuration { [INFO] [stdout] | ________^ [INFO] [stdout] 149 | | included_files, [INFO] [stdout] 150 | | absolute_root, [INFO] [stdout] 151 | | cache_enabled, [INFO] [stdout] ... | [INFO] [stdout] 168 | | disable_enforce_visibility: false, [INFO] [stdout] 169 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/pack.rs:207:13 [INFO] [stdout] | [INFO] [stdout] 206 | let mut file = File::open(package_yml_absolute_path).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | anyhow::Error::new(e).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/pack.rs:214:13 [INFO] [stdout] | [INFO] [stdout] 213 | file.read_to_string(&mut yaml_contents).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | anyhow::Error::new(e).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/pack.rs:417:9 [INFO] [stdout] | [INFO] [stdout] 416 | std::fs::create_dir_all(pack_dir).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 417 | anyhow::Error::new(e).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/pack.rs:424:9 [INFO] [stdout] | [INFO] [stdout] 423 | std::fs::write(&pack.yml, serialized_pack).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 424 | anyhow::Error::new(e) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/raw_configuration.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 95 | let mut file = File::open(&absolute_path_to_packwerk_yml).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | anyhow::Error::new(e).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/raw_configuration.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 103 | std::io::Read::read_to_string(&mut file, &mut contents).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | anyhow::Error::new(e).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/raw_configuration.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 110 | let configuration = serde_yaml::from_str(&contents).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | anyhow::Error::new(e).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/raw_configuration.rs:183:38 [INFO] [stdout] | [INFO] [stdout] 179 | fn visit_seq(self, seq: S) -> Result [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | Deserialize::deserialize(value::SeqAccessDeserializer::new(seq)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/walk_directory.rs:196:8 [INFO] [stdout] | [INFO] [stdout] 43 | let mut included_files: HashSet = HashSet::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let mut included_packs: HashSet = HashSet::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let all_excluded_dirs_set = build_glob_set(&all_excluded_dirs); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | let excluded_dirs_ref = Arc::new(all_excluded_dirs_set); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | [INFO] [stdout] 69 | let absolute_root_ref = Arc::new(absolute_root.clone()); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | [INFO] [stdout] 71 | let includes_set = build_glob_set(&raw.include); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let excludes_set = build_glob_set(&raw.exclude); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let package_paths_set = build_glob_set(&raw.package_paths); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let walk_dir = WalkDirGeneric::::new(&absolute_root) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | Ok(WalkDirectoryResult { [INFO] [stdout] | ________^ [INFO] [stdout] 197 | | included_files, [INFO] [stdout] 198 | | included_packs, [INFO] [stdout] 199 | | owning_package_yml_for_file, [INFO] [stdout] 200 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/constant_dependencies.rs:202:23 [INFO] [stdout] | [INFO] [stdout] 183 | let defining_pack = Pack { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let referencing_pack_bar = Pack { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | let referencing_pack_baz = Pack { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let root_pack = Pack { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | pack_set: PackSet::build( [INFO] [stdout] | _______________________^ [INFO] [stdout] 203 | | HashSet::from_iter(vec![ [INFO] [stdout] 204 | | root_pack, [INFO] [stdout] 205 | | defining_pack, [INFO] [stdout] ... | [INFO] [stdout] 210 | | ) [INFO] [stdout] 211 | | .unwrap(), [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/constant_dependencies.rs:212:15 [INFO] [stdout] | [INFO] [stdout] 183 | let defining_pack = Pack { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let referencing_pack_bar = Pack { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | let referencing_pack_baz = Pack { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let root_pack = Pack { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | ..Configuration::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/pack_set.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 34 | packs: HashSet, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let packs: Vec = packs [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let mut indexed_packs_by_name: HashMap = HashMap::new(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let mut all_violations = HashSet::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let indexed_packs = indexed_packs_by_name; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(PackSet { [INFO] [stdout] | ____________^ [INFO] [stdout] 72 | | indexed_packs, [INFO] [stdout] 73 | | packs, [INFO] [stdout] 74 | | all_violations, [INFO] [stdout] 75 | | owning_pack_name_for_file, [INFO] [stdout] 76 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs/pack_set.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 140 | let foo_pack = Pack { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let root_pack = Pack { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | let mut packs = HashSet::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | PackSet::build(packs, HashMap::new()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packs.rs:440:13 [INFO] [stdout] | [INFO] [stdout] 425 | let configuration = configuration::get( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 440 | / configuration [INFO] [stdout] 441 | | .pack_set [INFO] [stdout] 442 | | .for_file(&absolute_file_path) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 29 | let configuration = configuration::get(&absolute_root)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | Ok(get_zeitwerk_constant_resolver( [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | &configuration.pack_set, [INFO] [stdout] 33 | | &configuration.constant_resolver_configuration(), [INFO] [stdout] 34 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 71 | let root_pack = Pack { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let included_packs: HashSet = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let walk_directory_result = WalkDirectoryResult { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | / from_raw( [INFO] [stdout] 85 | | &default_absolute_root, [INFO] [stdout] 86 | | RawConfiguration::default(), [INFO] [stdout] 87 | | walk_directory_result, [INFO] [stdout] 88 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 20 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pks` (lib test) due to 21 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "2fb17d120b8e1032cda0108154dd494461e66cb7d61a1ebddb02b1e0a2495ad2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2fb17d120b8e1032cda0108154dd494461e66cb7d61a1ebddb02b1e0a2495ad2", kill_on_drop: false }` [INFO] [stdout] 2fb17d120b8e1032cda0108154dd494461e66cb7d61a1ebddb02b1e0a2495ad2