[INFO] fetching crate pkarr 2.2.0... [INFO] checking pkarr-2.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pkarr 2.2.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate pkarr 2.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pkarr 2.2.0 [INFO] finished tweaking crates.io crate pkarr 2.2.0 [INFO] tweaked toml for crates.io crate pkarr 2.2.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate pkarr 2.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1986b81ec9119f009f56ff1155043ef091ba0e84730f36511412788994d202b0 [INFO] running `Command { std: "docker" "start" "-a" "1986b81ec9119f009f56ff1155043ef091ba0e84730f36511412788994d202b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1986b81ec9119f009f56ff1155043ef091ba0e84730f36511412788994d202b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1986b81ec9119f009f56ff1155043ef091ba0e84730f36511412788994d202b0", kill_on_drop: false }` [INFO] [stdout] 1986b81ec9119f009f56ff1155043ef091ba0e84730f36511412788994d202b0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1dddc1f0e11256040bb1444413ba7ac1c7f14a2a048b37b1460d2ba0f81cd6ed [INFO] running `Command { std: "docker" "start" "-a" "1dddc1f0e11256040bb1444413ba7ac1c7f14a2a048b37b1460d2ba0f81cd6ed", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking simple-dns v0.6.2 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking z32 v1.1.1 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking self_cell v1.0.4 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling document-features v0.2.10 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Compiling serde_derive v1.0.207 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking clap v4.5.15 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.207 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking serde_json v1.0.125 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_bencode v0.2.4 [INFO] [stderr] Checking mainline v2.0.1 [INFO] [stderr] Checking assert-json-diff v2.0.2 [INFO] [stderr] Checking mockito v1.5.0 [INFO] [stderr] Checking pkarr v2.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signed_packet.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 41 | let mut bytes = BytesMut::with_capacity(encoded_packet.len() + 104); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(Self::try_new(bytes.into(), |bytes| { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | Packet::parse(&bytes[104..]) [INFO] [stdout] 50 | | })?) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signed_packet.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 102 | Ok(SignedPacket { [INFO] [stdout] | ____________^ [INFO] [stdout] 103 | | inner: Inner::try_from_bytes(bytes)?, [INFO] [stdout] 104 | | last_seen: system_time(), [INFO] [stdout] 105 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signed_packet.rs:130:35 [INFO] [stdout] | [INFO] [stdout] 125 | let mut bytes = BytesMut::with_capacity(payload.len() + 32); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | SignedPacket::from_bytes(&bytes.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signed_packet.rs:178:12 [INFO] [stdout] | [INFO] [stdout] 168 | let encoded_packet: Bytes = inner.build_bytes_vec_compressed()?.into(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | Ok(SignedPacket { [INFO] [stdout] | ____________^ [INFO] [stdout] 179 | | inner: Inner::try_from_parts( [INFO] [stdout] 180 | | &keypair.public_key(), [INFO] [stdout] 181 | | &signature, [INFO] [stdout] ... | [INFO] [stdout] 185 | | last_seen: system_time(), [INFO] [stdout] 186 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signed_packet.rs:372:17 [INFO] [stdout] | [INFO] [stdout] 365 | let packet = s.inner.borrow_owner().slice(104..); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 372 | None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pkarr` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signed_packet.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 41 | let mut bytes = BytesMut::with_capacity(encoded_packet.len() + 104); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(Self::try_new(bytes.into(), |bytes| { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | Packet::parse(&bytes[104..]) [INFO] [stdout] 50 | | })?) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signed_packet.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 102 | Ok(SignedPacket { [INFO] [stdout] | ____________^ [INFO] [stdout] 103 | | inner: Inner::try_from_bytes(bytes)?, [INFO] [stdout] 104 | | last_seen: system_time(), [INFO] [stdout] 105 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signed_packet.rs:130:35 [INFO] [stdout] | [INFO] [stdout] 125 | let mut bytes = BytesMut::with_capacity(payload.len() + 32); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | SignedPacket::from_bytes(&bytes.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signed_packet.rs:178:12 [INFO] [stdout] | [INFO] [stdout] 168 | let encoded_packet: Bytes = inner.build_bytes_vec_compressed()?.into(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | Ok(SignedPacket { [INFO] [stdout] | ____________^ [INFO] [stdout] 179 | | inner: Inner::try_from_parts( [INFO] [stdout] 180 | | &keypair.public_key(), [INFO] [stdout] 181 | | &signature, [INFO] [stdout] ... | [INFO] [stdout] 185 | | last_seen: system_time(), [INFO] [stdout] 186 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signed_packet.rs:372:17 [INFO] [stdout] | [INFO] [stdout] 365 | let packet = s.inner.borrow_owner().slice(104..); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 372 | None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signed_packet.rs:644:13 [INFO] [stdout] | [INFO] [stdout] 622 | let keypair = Keypair::random(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 641 | let signed = SignedPacket::from_packet(&keypair, &packet).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 644 | / signed [INFO] [stdout] 645 | | .resource_records("@") [INFO] [stdout] 646 | | .map(|r| r.rdata.clone()) [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pkarr` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "1dddc1f0e11256040bb1444413ba7ac1c7f14a2a048b37b1460d2ba0f81cd6ed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1dddc1f0e11256040bb1444413ba7ac1c7f14a2a048b37b1460d2ba0f81cd6ed", kill_on_drop: false }` [INFO] [stdout] 1dddc1f0e11256040bb1444413ba7ac1c7f14a2a048b37b1460d2ba0f81cd6ed