[INFO] fetching crate piz 0.5.1... [INFO] checking piz-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate piz 0.5.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate piz 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate piz 0.5.1 [INFO] finished tweaking crates.io crate piz 0.5.1 [INFO] tweaked toml for crates.io crate piz 0.5.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate piz 0.5.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fda1bd12354d968d664664a8ec026b363a6f820c91e7a27bb34805c6ee7c00ff [INFO] running `Command { std: "docker" "start" "-a" "fda1bd12354d968d664664a8ec026b363a6f820c91e7a27bb34805c6ee7c00ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fda1bd12354d968d664664a8ec026b363a6f820c91e7a27bb34805c6ee7c00ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fda1bd12354d968d664664a8ec026b363a6f820c91e7a27bb34805c6ee7c00ff", kill_on_drop: false }` [INFO] [stdout] fda1bd12354d968d664664a8ec026b363a6f820c91e7a27bb34805c6ee7c00ff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 495b7a8bff586ee6bf1567478aa2800d2b01e6e7837a4a8e48dd8306162b00e3 [INFO] running `Command { std: "docker" "start" "-a" "495b7a8bff586ee6bf1567478aa2800d2b01e6e7837a4a8e48dd8306162b00e3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Checking once_cell v1.14.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.11 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling regex-automata v0.1.10 [INFO] [stderr] Compiling crossbeam-epoch v0.9.10 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling itoa v0.4.8 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling ryu v1.0.11 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Compiling camino v1.1.1 [INFO] [stderr] Checking iana-time-zone v0.1.47 [INFO] [stderr] Checking miniz_oxide v0.5.4 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Compiling anyhow v1.0.64 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling csv-core v0.1.10 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking crossbeam-deque v0.8.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking chrono v0.4.22 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking stderrlog v0.5.3 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling thiserror-impl v1.0.34 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling bstr v0.2.17 [INFO] [stderr] Checking thiserror v1.0.34 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Compiling csv v1.1.6 [INFO] [stderr] Compiling codepage-437 v0.1.0 [INFO] [stderr] Checking piz v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `file_comment` is never read [INFO] [stdout] --> src/spec.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 123 | pub struct EndOfCentralDirectory<'a> { [INFO] [stdout] | --------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 130 | pub file_comment: &'a [u8], [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EndOfCentralDirectory` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/spec.rs:236:9 [INFO] [stdout] | [INFO] [stdout] 235 | pub struct Zip64EndOfCentralDirectory<'a> { [INFO] [stdout] | -------------------------- fields in this struct [INFO] [stdout] 236 | pub source_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 237 | pub minimum_extract_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 238 | pub disk_number: u32, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 239 | pub disk_with_central_directory: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 240 | pub entries_on_this_disk: u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 241 | pub entries: u64, [INFO] [stdout] 242 | pub central_directory_size: u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 243 | pub central_directory_offset: u64, [INFO] [stdout] 244 | pub extensible_data: &'a [u8], [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Zip64EndOfCentralDirectory` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `minimum_extract_version`, `internal_file_attributes`, and `file_comment` are never read [INFO] [stdout] --> src/spec.rs:343:9 [INFO] [stdout] | [INFO] [stdout] 341 | pub struct CentralDirectoryEntry<'a> { [INFO] [stdout] | --------------------- fields in this struct [INFO] [stdout] 342 | pub source_version: u16, [INFO] [stdout] 343 | pub minimum_extract_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 352 | pub internal_file_attributes: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 357 | pub file_comment: &'a [u8], [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CentralDirectoryEntry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `minimum_extract_version` is never read [INFO] [stdout] --> src/spec.rs:630:9 [INFO] [stdout] | [INFO] [stdout] 629 | pub struct LocalFileHeader<'a> { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 630 | pub minimum_extract_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LocalFileHeader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:410:9 [INFO] [stdout] | [INFO] [stdout] 395 | fn lookup>(&self, path: P) -> ZipResult<&'a FileMetadata<'a>> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 400 | other_result => other_result, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 410 | / parent_dir [INFO] [stdout] 411 | | .get(base) [INFO] [stdout] 412 | | .ok_or_else(|| ZipError::NoSuchFile(path.to_owned())) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `piz` (lib) due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `file_comment` is never read [INFO] [stdout] --> src/spec.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 123 | pub struct EndOfCentralDirectory<'a> { [INFO] [stdout] | --------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 130 | pub file_comment: &'a [u8], [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EndOfCentralDirectory` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/spec.rs:236:9 [INFO] [stdout] | [INFO] [stdout] 235 | pub struct Zip64EndOfCentralDirectory<'a> { [INFO] [stdout] | -------------------------- fields in this struct [INFO] [stdout] 236 | pub source_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 237 | pub minimum_extract_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 238 | pub disk_number: u32, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 239 | pub disk_with_central_directory: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 240 | pub entries_on_this_disk: u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 241 | pub entries: u64, [INFO] [stdout] 242 | pub central_directory_size: u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 243 | pub central_directory_offset: u64, [INFO] [stdout] 244 | pub extensible_data: &'a [u8], [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Zip64EndOfCentralDirectory` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `minimum_extract_version`, `internal_file_attributes`, and `file_comment` are never read [INFO] [stdout] --> src/spec.rs:343:9 [INFO] [stdout] | [INFO] [stdout] 341 | pub struct CentralDirectoryEntry<'a> { [INFO] [stdout] | --------------------- fields in this struct [INFO] [stdout] 342 | pub source_version: u16, [INFO] [stdout] 343 | pub minimum_extract_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 352 | pub internal_file_attributes: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 357 | pub file_comment: &'a [u8], [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CentralDirectoryEntry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `minimum_extract_version` is never read [INFO] [stdout] --> src/spec.rs:630:9 [INFO] [stdout] | [INFO] [stdout] 629 | pub struct LocalFileHeader<'a> { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 630 | pub minimum_extract_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LocalFileHeader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:410:9 [INFO] [stdout] | [INFO] [stdout] 395 | fn lookup>(&self, path: P) -> ZipResult<&'a FileMetadata<'a>> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 400 | other_result => other_result, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 410 | / parent_dir [INFO] [stdout] 411 | | .get(base) [INFO] [stdout] 412 | | .ok_or_else(|| ZipError::NoSuchFile(path.to_owned())) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `piz` (lib test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "495b7a8bff586ee6bf1567478aa2800d2b01e6e7837a4a8e48dd8306162b00e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "495b7a8bff586ee6bf1567478aa2800d2b01e6e7837a4a8e48dd8306162b00e3", kill_on_drop: false }` [INFO] [stdout] 495b7a8bff586ee6bf1567478aa2800d2b01e6e7837a4a8e48dd8306162b00e3