[INFO] fetching crate pixcil 0.7.0... [INFO] checking pixcil-0.7.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pixcil 0.7.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate pixcil 0.7.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pixcil 0.7.0 [INFO] finished tweaking crates.io crate pixcil 0.7.0 [INFO] tweaked toml for crates.io crate pixcil 0.7.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 45 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 18de4fa3c54c745da2f12cb91d875585317f1940deb0babbc9c1975d2467c5c9 [INFO] running `Command { std: "docker" "start" "-a" "18de4fa3c54c745da2f12cb91d875585317f1940deb0babbc9c1975d2467c5c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "18de4fa3c54c745da2f12cb91d875585317f1940deb0babbc9c1975d2467c5c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18de4fa3c54c745da2f12cb91d875585317f1940deb0babbc9c1975d2467c5c9", kill_on_drop: false }` [INFO] [stdout] 18de4fa3c54c745da2f12cb91d875585317f1940deb0babbc9c1975d2467c5c9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b0c8777e9f4edcb520fe0fd4b7d70f5818590101bb05a3329c46892c7c9412a [INFO] running `Command { std: "docker" "start" "-a" "1b0c8777e9f4edcb520fe0fd4b7d70f5818590101bb05a3329c46892c7c9412a", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking rle-decode-fast v1.0.3 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking dary_heap v0.3.6 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking libflate_lz77 v2.1.0 [INFO] [stderr] Checking libflate v2.1.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking orfail v1.1.0 [INFO] [stderr] Checking pagurus v0.7.4 [INFO] [stderr] Checking pixcil v0.7.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset.rs:316:12 [INFO] [stdout] | [INFO] [stdout] 310 | let go = decode_sprite(include_bytes!("../assets/icon-go.png")).or_fail()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 311 | let rotate = decode_sprite(include_bytes!("../assets/icon-rotate.png")).or_fail()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | let block = Size::square(64).to_region(); [INFO] [stdout] 313 | let pixel_size_op = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 317 | | undo: decode_sprite(include_bytes!("../assets/icon-undo.png")).or_fail()?, [INFO] [stdout] 318 | | redo: decode_sprite(include_bytes!("../assets/icon-redo.png")).or_fail()?, [INFO] [stdout] 319 | | zoom_in: decode_sprite(include_bytes!("../assets/icon-zoom-in.png")).or_fail()?, [INFO] [stdout] ... | [INFO] [stdout] 360 | | unit_pixel: pixel_size_op.clip(middle_block.shift_y(3)).or_fail()?, [INFO] [stdout] 361 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset.rs:429:12 [INFO] [stdout] | [INFO] [stdout] 377 | let basic = Button::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | let basic_deep = Button::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 387 | let basic_pressed = Button::new( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 393 | let slider_buttons = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | let slider_left = Button::new( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 406 | let slider_right = Button::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 416 | let middle_buttons = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 419 | let middle = Button::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 429 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 430 | | basic, [INFO] [stdout] 431 | | basic_deep, [INFO] [stdout] 432 | | basic_pressed, [INFO] [stdout] ... | [INFO] [stdout] 435 | | middle, [INFO] [stdout] 436 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset.rs:470:12 [INFO] [stdout] | [INFO] [stdout] 467 | let on = decode_sprite(include_bytes!("../assets/toggle-on.png")).or_fail()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 468 | let off = decode_sprite(include_bytes!("../assets/toggle-off.png")).or_fail()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 469 | let block = Region::new(Position::ORIGIN, Size::from_wh(64, 32)); [INFO] [stdout] 470 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 471 | | on_neutral: on.clip(block).or_fail()?, [INFO] [stdout] 472 | | on_focused: on.clip(block.shift_y(1)).or_fail()?, [INFO] [stdout] 473 | | off_neutral: off.clip(block).or_fail()?, [INFO] [stdout] 474 | | off_focused: off.clip(block.shift_y(1)).or_fail()?, [INFO] [stdout] 475 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset.rs:489:12 [INFO] [stdout] | [INFO] [stdout] 487 | let sprite = decode_sprite(include_bytes!("../assets/drag-hands.png")).or_fail()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 488 | let block = Region::new(Position::ORIGIN, Size::square(64)); [INFO] [stdout] 489 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 490 | | open: sprite.clip(block).or_fail()?, [INFO] [stdout] 491 | | close: sprite.clip(block.shift_x(1)).or_fail()?, [INFO] [stdout] 492 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 497 | let digits = decode_sprite(include_bytes!("../assets/digits-10x14.png")).or_fail()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 507 | Ok([ [INFO] [stdout] | ________^ [INFO] [stdout] 508 | | clip(&digits, base, 0, 0).or_fail()?, [INFO] [stdout] 509 | | clip(&digits, base, 0, 1).or_fail()?, [INFO] [stdout] 510 | | clip(&digits, base, 0, 2).or_fail()?, [INFO] [stdout] ... | [INFO] [stdout] 517 | | clip(&digits, base, 1, 4).or_fail()?, [INFO] [stdout] 518 | | ]) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset.rs:533:8 [INFO] [stdout] | [INFO] [stdout] 522 | let a_p = decode_sprite(include_bytes!("../assets/A-P-10x14.png")).or_fail()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 523 | let q_z = decode_sprite(include_bytes!("../assets/Q-Z-10x14.png")).or_fail()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 533 | Ok([ [INFO] [stdout] | ________^ [INFO] [stdout] 534 | | clip(&a_p, block, 0, 0).or_fail()?, [INFO] [stdout] 535 | | clip(&a_p, block, 0, 1).or_fail()?, [INFO] [stdout] 536 | | clip(&a_p, block, 0, 2).or_fail()?, [INFO] [stdout] ... | [INFO] [stdout] 560 | | clip(&q_z, block, 2, 2).or_fail()?, [INFO] [stdout] 561 | | ]) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/marker/lasso.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 25 | let stroke = self.stroke.marked_pixels(app).collect::>(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let region = PixelRegion::from_positions(stroke.iter().copied()); [INFO] [stdout] 27 | let mut pixels = region.pixels().collect::>(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Box::new(pixels.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serialize.rs:223:24 [INFO] [stdout] | [INFO] [stdout] 223 | (0..n).map(|_| T::deserialize(reader).or_fail()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pixcil` (lib test) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset.rs:316:12 [INFO] [stdout] | [INFO] [stdout] 310 | let go = decode_sprite(include_bytes!("../assets/icon-go.png")).or_fail()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 311 | let rotate = decode_sprite(include_bytes!("../assets/icon-rotate.png")).or_fail()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | let block = Size::square(64).to_region(); [INFO] [stdout] 313 | let pixel_size_op = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 317 | | undo: decode_sprite(include_bytes!("../assets/icon-undo.png")).or_fail()?, [INFO] [stdout] 318 | | redo: decode_sprite(include_bytes!("../assets/icon-redo.png")).or_fail()?, [INFO] [stdout] 319 | | zoom_in: decode_sprite(include_bytes!("../assets/icon-zoom-in.png")).or_fail()?, [INFO] [stdout] ... | [INFO] [stdout] 360 | | unit_pixel: pixel_size_op.clip(middle_block.shift_y(3)).or_fail()?, [INFO] [stdout] 361 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset.rs:429:12 [INFO] [stdout] | [INFO] [stdout] 377 | let basic = Button::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | let basic_deep = Button::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 387 | let basic_pressed = Button::new( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 393 | let slider_buttons = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | let slider_left = Button::new( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 406 | let slider_right = Button::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 416 | let middle_buttons = [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 419 | let middle = Button::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 429 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 430 | | basic, [INFO] [stdout] 431 | | basic_deep, [INFO] [stdout] 432 | | basic_pressed, [INFO] [stdout] ... | [INFO] [stdout] 435 | | middle, [INFO] [stdout] 436 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset.rs:470:12 [INFO] [stdout] | [INFO] [stdout] 467 | let on = decode_sprite(include_bytes!("../assets/toggle-on.png")).or_fail()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 468 | let off = decode_sprite(include_bytes!("../assets/toggle-off.png")).or_fail()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 469 | let block = Region::new(Position::ORIGIN, Size::from_wh(64, 32)); [INFO] [stdout] 470 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 471 | | on_neutral: on.clip(block).or_fail()?, [INFO] [stdout] 472 | | on_focused: on.clip(block.shift_y(1)).or_fail()?, [INFO] [stdout] 473 | | off_neutral: off.clip(block).or_fail()?, [INFO] [stdout] 474 | | off_focused: off.clip(block.shift_y(1)).or_fail()?, [INFO] [stdout] 475 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset.rs:489:12 [INFO] [stdout] | [INFO] [stdout] 487 | let sprite = decode_sprite(include_bytes!("../assets/drag-hands.png")).or_fail()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 488 | let block = Region::new(Position::ORIGIN, Size::square(64)); [INFO] [stdout] 489 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 490 | | open: sprite.clip(block).or_fail()?, [INFO] [stdout] 491 | | close: sprite.clip(block.shift_x(1)).or_fail()?, [INFO] [stdout] 492 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 497 | let digits = decode_sprite(include_bytes!("../assets/digits-10x14.png")).or_fail()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 507 | Ok([ [INFO] [stdout] | ________^ [INFO] [stdout] 508 | | clip(&digits, base, 0, 0).or_fail()?, [INFO] [stdout] 509 | | clip(&digits, base, 0, 1).or_fail()?, [INFO] [stdout] 510 | | clip(&digits, base, 0, 2).or_fail()?, [INFO] [stdout] ... | [INFO] [stdout] 517 | | clip(&digits, base, 1, 4).or_fail()?, [INFO] [stdout] 518 | | ]) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/asset.rs:533:8 [INFO] [stdout] | [INFO] [stdout] 522 | let a_p = decode_sprite(include_bytes!("../assets/A-P-10x14.png")).or_fail()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 523 | let q_z = decode_sprite(include_bytes!("../assets/Q-Z-10x14.png")).or_fail()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 533 | Ok([ [INFO] [stdout] | ________^ [INFO] [stdout] 534 | | clip(&a_p, block, 0, 0).or_fail()?, [INFO] [stdout] 535 | | clip(&a_p, block, 0, 1).or_fail()?, [INFO] [stdout] 536 | | clip(&a_p, block, 0, 2).or_fail()?, [INFO] [stdout] ... | [INFO] [stdout] 560 | | clip(&q_z, block, 2, 2).or_fail()?, [INFO] [stdout] 561 | | ]) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/marker/lasso.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 25 | let stroke = self.stroke.marked_pixels(app).collect::>(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let region = PixelRegion::from_positions(stroke.iter().copied()); [INFO] [stdout] 27 | let mut pixels = region.pixels().collect::>(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | Box::new(pixels.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serialize.rs:223:24 [INFO] [stdout] | [INFO] [stdout] 223 | (0..n).map(|_| T::deserialize(reader).or_fail()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pixcil` (lib) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "1b0c8777e9f4edcb520fe0fd4b7d70f5818590101bb05a3329c46892c7c9412a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b0c8777e9f4edcb520fe0fd4b7d70f5818590101bb05a3329c46892c7c9412a", kill_on_drop: false }` [INFO] [stdout] 1b0c8777e9f4edcb520fe0fd4b7d70f5818590101bb05a3329c46892c7c9412a