[INFO] fetching crate piston_meta 2.0.1... [INFO] checking piston_meta-2.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate piston_meta 2.0.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate piston_meta 2.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate piston_meta 2.0.1 [INFO] finished tweaking crates.io crate piston_meta 2.0.1 [INFO] tweaked toml for crates.io crate piston_meta 2.0.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate piston_meta 2.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7d9f2eef2c3666e8f81c9bb5efc8068b3a37f79ad98b05510986901895c1b6be [INFO] running `Command { std: "docker" "start" "-a" "7d9f2eef2c3666e8f81c9bb5efc8068b3a37f79ad98b05510986901895c1b6be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7d9f2eef2c3666e8f81c9bb5efc8068b3a37f79ad98b05510986901895c1b6be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d9f2eef2c3666e8f81c9bb5efc8068b3a37f79ad98b05510986901895c1b6be", kill_on_drop: false }` [INFO] [stdout] 7d9f2eef2c3666e8f81c9bb5efc8068b3a37f79ad98b05510986901895c1b6be [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e25ba3bf3a209147df439271475af64b1b211e40aab817caa21c9f9873a78cfd [INFO] running `Command { std: "docker" "start" "-a" "e25ba3bf3a209147df439271475af64b1b211e40aab817caa21c9f9873a78cfd", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking range v1.0.0 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Checking read_token v1.0.0 [INFO] [stderr] Checking piston_meta v2.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/lib.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 167 | pub use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:225:11 [INFO] [stdout] | [INFO] [stdout] 222 | let mut tokens = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | match bootstrap::convert(&tokens, &mut ignored_meta_data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:176:12 [INFO] [stdout] | [INFO] [stdout] 152 | let mut name = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let mut text = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | let name = match name { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | None => { return Err(()); } [INFO] [stdout] 170 | Some(x) => x [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | }; [INFO] [stdout] 172 | let text = match text { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | None => { return Err(()); } [INFO] [stdout] 174 | Some(x) => x [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | }; [INFO] [stdout] 176 | Ok((convert.subtract(start), (name, text))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:206:12 [INFO] [stdout] | [INFO] [stdout] 189 | let mut args: Vec = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | Ok((convert.subtract(start), Rule::Sequence(Sequence { [INFO] [stdout] | ____________^ [INFO] [stdout] 207 | | debug_id: *debug_id, [INFO] [stdout] 208 | | args: args [INFO] [stdout] 209 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:443:12 [INFO] [stdout] | [INFO] [stdout] 424 | let mut property = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 443 | Ok((convert.subtract(start), [INFO] [stdout] | ____________^ [INFO] [stdout] 444 | | Rule::Text(Text { [INFO] [stdout] 445 | | debug_id: *debug_id, [INFO] [stdout] 446 | | allow_empty: allow_empty, [INFO] [stdout] 447 | | property: property, [INFO] [stdout] 448 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:482:12 [INFO] [stdout] | [INFO] [stdout] 462 | let mut property = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 482 | Ok((convert.subtract(start), [INFO] [stdout] | ____________^ [INFO] [stdout] 483 | | Rule::Number(Number { [INFO] [stdout] 484 | | debug_id: *debug_id, [INFO] [stdout] 485 | | property: property, [INFO] [stdout] 486 | | allow_underscore: underscore, [INFO] [stdout] 487 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:561:12 [INFO] [stdout] | [INFO] [stdout] 544 | let mut args: Vec = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 561 | Ok((convert.subtract(start), [INFO] [stdout] | ____________^ [INFO] [stdout] 562 | | Rule::Select(Select { [INFO] [stdout] 563 | | debug_id: *debug_id, [INFO] [stdout] 564 | | args: args [INFO] [stdout] 565 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:585:12 [INFO] [stdout] | [INFO] [stdout] 578 | let (range, rule) = read_rule( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 585 | Ok((convert.subtract(start), [INFO] [stdout] | ____________^ [INFO] [stdout] 586 | | Rule::Optional(Box::new(Optional { [INFO] [stdout] 587 | | debug_id: *debug_id, [INFO] [stdout] 588 | | rule: rule, [INFO] [stdout] 589 | | })))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:609:12 [INFO] [stdout] | [INFO] [stdout] 602 | let (range, rule) = read_rule( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 609 | Ok((convert.subtract(start), [INFO] [stdout] | ____________^ [INFO] [stdout] 610 | | Rule::Not(Box::new(Not { [INFO] [stdout] 611 | | debug_id: *debug_id, [INFO] [stdout] 612 | | rule: rule, [INFO] [stdout] 613 | | })))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:658:15 [INFO] [stdout] | [INFO] [stdout] 628 | let mut by = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 629 | let mut rule = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 658 | match (by, rule) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:694:12 [INFO] [stdout] | [INFO] [stdout] 687 | let (range, rule) = read_rule( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 694 | Ok((convert.subtract(start), [INFO] [stdout] | ____________^ [INFO] [stdout] 695 | | Rule::Lines(Box::new(Lines { [INFO] [stdout] 696 | | debug_id: *debug_id, [INFO] [stdout] 697 | | rule, [INFO] [stdout] 698 | | indent, [INFO] [stdout] 699 | | })))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:732:15 [INFO] [stdout] | [INFO] [stdout] 712 | let mut rule = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 732 | match (rule, optional) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:871:15 [INFO] [stdout] | [INFO] [stdout] 847 | let mut name = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 848 | let mut rule = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 871 | match (name, rule) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta_rules/node.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 65 | let mut opt_error = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | range, [INFO] [stdout] 78 | | if let Some(ref prop) = self.property { [INFO] [stdout] 79 | | read_data( [INFO] [stdout] ... | [INFO] [stdout] 87 | | opt_error [INFO] [stdout] 88 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta_rules/repeat.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 42 | let mut opt_error = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok((read_token.subtract(start), state, opt_error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta_rules/rule.rs:77:64 [INFO] [stdout] | [INFO] [stdout] 77 | w.parse(read_token).map(|r| (r, state.clone(), None)) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta_rules/separate_by.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 47 | let mut opt_error = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | Ok((read_token.subtract(start), state, opt_error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta_rules/sequence.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 40 | let mut opt_error = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok((read_token.subtract(start), state, opt_error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_error_handler.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn error(&mut self, range_err: Range) { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | self.write(&mut stderr(), range_err).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `piston_meta` (lib) due to 19 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:225:11 [INFO] [stdout] | [INFO] [stdout] 222 | let mut tokens = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 225 | match bootstrap::convert(&tokens, &mut ignored_meta_data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:176:12 [INFO] [stdout] | [INFO] [stdout] 152 | let mut name = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let mut text = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | let name = match name { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | None => { return Err(()); } [INFO] [stdout] 170 | Some(x) => x [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | }; [INFO] [stdout] 172 | let text = match text { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | None => { return Err(()); } [INFO] [stdout] 174 | Some(x) => x [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | }; [INFO] [stdout] 176 | Ok((convert.subtract(start), (name, text))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:206:12 [INFO] [stdout] | [INFO] [stdout] 189 | let mut args: Vec = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | Ok((convert.subtract(start), Rule::Sequence(Sequence { [INFO] [stdout] | ____________^ [INFO] [stdout] 207 | | debug_id: *debug_id, [INFO] [stdout] 208 | | args: args [INFO] [stdout] 209 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:443:12 [INFO] [stdout] | [INFO] [stdout] 424 | let mut property = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 443 | Ok((convert.subtract(start), [INFO] [stdout] | ____________^ [INFO] [stdout] 444 | | Rule::Text(Text { [INFO] [stdout] 445 | | debug_id: *debug_id, [INFO] [stdout] 446 | | allow_empty: allow_empty, [INFO] [stdout] 447 | | property: property, [INFO] [stdout] 448 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:482:12 [INFO] [stdout] | [INFO] [stdout] 462 | let mut property = None; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 482 | Ok((convert.subtract(start), [INFO] [stdout] | ____________^ [INFO] [stdout] 483 | | Rule::Number(Number { [INFO] [stdout] 484 | | debug_id: *debug_id, [INFO] [stdout] 485 | | property: property, [INFO] [stdout] 486 | | allow_underscore: underscore, [INFO] [stdout] 487 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:561:12 [INFO] [stdout] | [INFO] [stdout] 544 | let mut args: Vec = vec![]; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 561 | Ok((convert.subtract(start), [INFO] [stdout] | ____________^ [INFO] [stdout] 562 | | Rule::Select(Select { [INFO] [stdout] 563 | | debug_id: *debug_id, [INFO] [stdout] 564 | | args: args [INFO] [stdout] 565 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:585:12 [INFO] [stdout] | [INFO] [stdout] 578 | let (range, rule) = read_rule( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 585 | Ok((convert.subtract(start), [INFO] [stdout] | ____________^ [INFO] [stdout] 586 | | Rule::Optional(Box::new(Optional { [INFO] [stdout] 587 | | debug_id: *debug_id, [INFO] [stdout] 588 | | rule: rule, [INFO] [stdout] 589 | | })))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:609:12 [INFO] [stdout] | [INFO] [stdout] 602 | let (range, rule) = read_rule( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 609 | Ok((convert.subtract(start), [INFO] [stdout] | ____________^ [INFO] [stdout] 610 | | Rule::Not(Box::new(Not { [INFO] [stdout] 611 | | debug_id: *debug_id, [INFO] [stdout] 612 | | rule: rule, [INFO] [stdout] 613 | | })))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:658:15 [INFO] [stdout] | [INFO] [stdout] 628 | let mut by = None; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 629 | let mut rule = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 658 | match (by, rule) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:694:12 [INFO] [stdout] | [INFO] [stdout] 687 | let (range, rule) = read_rule( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 694 | Ok((convert.subtract(start), [INFO] [stdout] | ____________^ [INFO] [stdout] 695 | | Rule::Lines(Box::new(Lines { [INFO] [stdout] 696 | | debug_id: *debug_id, [INFO] [stdout] 697 | | rule, [INFO] [stdout] 698 | | indent, [INFO] [stdout] 699 | | })))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:732:15 [INFO] [stdout] | [INFO] [stdout] 712 | let mut rule = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 732 | match (rule, optional) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bootstrap/convert.rs:871:15 [INFO] [stdout] | [INFO] [stdout] 847 | let mut name = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 848 | let mut rule = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 871 | match (name, rule) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta_rules/node.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 65 | let mut opt_error = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 77 | | range, [INFO] [stdout] 78 | | if let Some(ref prop) = self.property { [INFO] [stdout] 79 | | read_data( [INFO] [stdout] ... | [INFO] [stdout] 87 | | opt_error [INFO] [stdout] 88 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta_rules/repeat.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 42 | let mut opt_error = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok((read_token.subtract(start), state, opt_error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta_rules/repeat.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 78 | let mut tokens = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let s = TokenizerState::new(); [INFO] [stdout] 80 | let token: Arc = Arc::new("(a)".into()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | let rule = Repeat { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let res = rule.parse(&mut tokens, &s, &ReadToken::new(&text, 0), &[], indent_settings); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | assert_eq!(res, Err(Range::new(0, 0).wrap( [INFO] [stdout] | _________________________^ [INFO] [stdout] 94 | | ParseError::ExpectedTag(token.clone(), 1)))) [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta_rules/repeat.rs:116:25 [INFO] [stdout] | [INFO] [stdout] 101 | let mut tokens = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let s = TokenizerState::new(); [INFO] [stdout] 103 | let token: Arc = Arc::new("(a)".into()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let rule = Repeat { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let res = rule.parse(&mut tokens, &s, &ReadToken::new(&text, 0), &[], indent_settings); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | assert_eq!(res, Ok((Range::new(0, 9), TokenizerState(0), [INFO] [stdout] | _________________________^ [INFO] [stdout] 117 | | Some(Range::new(9, 0).wrap( [INFO] [stdout] 118 | | ParseError::ExpectedTag(token.clone(), 1)))))) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta_rules/rule.rs:77:64 [INFO] [stdout] | [INFO] [stdout] 77 | w.parse(read_token).map(|r| (r, state.clone(), None)) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta_rules/separate_by.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 47 | let mut opt_error = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | Ok((read_token.subtract(start), state, opt_error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta_rules/sequence.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 40 | let mut opt_error = None; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok((read_token.subtract(start), state, opt_error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse_error_handler.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 155 | pub fn error(&mut self, range_err: Range) { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | self.write(&mut stderr(), range_err).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/optimize.rs:196:27 [INFO] [stdout] | [INFO] [stdout] 196 | Rule::Tag(Tag { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 197 | | debug_id: 0, [INFO] [stdout] 198 | | not: false, [INFO] [stdout] 199 | | inverted: false, [INFO] [stdout] 200 | | property: None, [INFO] [stdout] 201 | | text: Arc::new(n.into()) [INFO] [stdout] 202 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `piston_meta` (lib test) due to 22 previous errors [INFO] running `Command { std: "docker" "inspect" "e25ba3bf3a209147df439271475af64b1b211e40aab817caa21c9f9873a78cfd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e25ba3bf3a209147df439271475af64b1b211e40aab817caa21c9f9873a78cfd", kill_on_drop: false }` [INFO] [stdout] e25ba3bf3a209147df439271475af64b1b211e40aab817caa21c9f9873a78cfd