[INFO] fetching crate pipe_watcher 2.1.2... [INFO] checking pipe_watcher-2.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pipe_watcher 2.1.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate pipe_watcher 2.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pipe_watcher 2.1.2 [INFO] finished tweaking crates.io crate pipe_watcher 2.1.2 [INFO] tweaked toml for crates.io crate pipe_watcher 2.1.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate pipe_watcher 2.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9b143f5ac3c7a26dba624605c2ebc29c6c758072d7ccd191b1eac64829597c30 [INFO] running `Command { std: "docker" "start" "-a" "9b143f5ac3c7a26dba624605c2ebc29c6c758072d7ccd191b1eac64829597c30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9b143f5ac3c7a26dba624605c2ebc29c6c758072d7ccd191b1eac64829597c30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b143f5ac3c7a26dba624605c2ebc29c6c758072d7ccd191b1eac64829597c30", kill_on_drop: false }` [INFO] [stdout] 9b143f5ac3c7a26dba624605c2ebc29c6c758072d7ccd191b1eac64829597c30 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4fe4f3305765f36e1d1922b1f86a95ed7e71f806452f9326673b6721170925ca [INFO] running `Command { std: "docker" "start" "-a" "4fe4f3305765f36e1d1922b1f86a95ed7e71f806452f9326673b6721170925ca", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.88 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking nix v0.19.1 [INFO] [stderr] Checking getch v0.2.1 [INFO] [stderr] Checking ipipe v0.8.2 [INFO] [stderr] Checking pipe_watcher v2.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:57:6 [INFO] [stdout] | [INFO] [stdout] 54 | fn pipe_write_thread(mut pipe: Pipe) -> (JoinHandle<()>, Sender) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | { [INFO] [stdout] 56 | let (tx, rx): (Sender, Receiver) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | (thread::spawn(move || [INFO] [stdout] | ______^ [INFO] [stdout] 58 | | { [INFO] [stdout] 59 | | loop [INFO] [stdout] 60 | | { [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] 73 | | }), tx) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 78 | let open_threads = std::env::args().skip(1).map(|name| [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | / open_threads.into_iter().filter_map(|thread| [INFO] [stdout] 84 | | { [INFO] [stdout] 85 | | match thread.join() [INFO] [stdout] 86 | | { [INFO] [stdout] ... | [INFO] [stdout] 89 | | } [INFO] [stdout] 90 | | }).collect() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:85:15 [INFO] [stdout] | [INFO] [stdout] 83 | open_threads.into_iter().filter_map(|thread| [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | { [INFO] [stdout] 85 | match thread.join() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pipe_watcher` (bin "pipe_writer") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:57:6 [INFO] [stdout] | [INFO] [stdout] 54 | fn pipe_write_thread(mut pipe: Pipe) -> (JoinHandle<()>, Sender) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | { [INFO] [stdout] 56 | let (tx, rx): (Sender, Receiver) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | (thread::spawn(move || [INFO] [stdout] | ______^ [INFO] [stdout] 58 | | { [INFO] [stdout] 59 | | loop [INFO] [stdout] 60 | | { [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] 73 | | }), tx) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 78 | let open_threads = std::env::args().skip(1).map(|name| [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | / open_threads.into_iter().filter_map(|thread| [INFO] [stdout] 84 | | { [INFO] [stdout] 85 | | match thread.join() [INFO] [stdout] 86 | | { [INFO] [stdout] ... | [INFO] [stdout] 89 | | } [INFO] [stdout] 90 | | }).collect() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:85:15 [INFO] [stdout] | [INFO] [stdout] 83 | open_threads.into_iter().filter_map(|thread| [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | { [INFO] [stdout] 85 | match thread.join() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pipe_watcher` (bin "pipe_writer" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "4fe4f3305765f36e1d1922b1f86a95ed7e71f806452f9326673b6721170925ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4fe4f3305765f36e1d1922b1f86a95ed7e71f806452f9326673b6721170925ca", kill_on_drop: false }` [INFO] [stdout] 4fe4f3305765f36e1d1922b1f86a95ed7e71f806452f9326673b6721170925ca