[INFO] fetching crate pinot-client-rust 1.0.0... [INFO] checking pinot-client-rust-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pinot-client-rust 1.0.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate pinot-client-rust 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pinot-client-rust 1.0.0 [INFO] finished tweaking crates.io crate pinot-client-rust 1.0.0 [INFO] tweaked toml for crates.io crate pinot-client-rust 1.0.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate pinot-client-rust 1.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8822cf41a9f9f7e3205c1e06d2f94461ef9741067b552ae711075abec70e7fc6 [INFO] running `Command { std: "docker" "start" "-a" "8822cf41a9f9f7e3205c1e06d2f94461ef9741067b552ae711075abec70e7fc6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8822cf41a9f9f7e3205c1e06d2f94461ef9741067b552ae711075abec70e7fc6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8822cf41a9f9f7e3205c1e06d2f94461ef9741067b552ae711075abec70e7fc6", kill_on_drop: false }` [INFO] [stdout] 8822cf41a9f9f7e3205c1e06d2f94461ef9741067b552ae711075abec70e7fc6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ac46f75aabb71ea20c1880d2eab63e61edcfd9048e1bd953417926d92cfe88f6 [INFO] running `Command { std: "docker" "start" "-a" "ac46f75aabb71ea20c1880d2eab63e61edcfd9048e1bd953417926d92cfe88f6", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.122 [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling syn v1.0.91 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Checking slab v0.4.6 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Checking tracing-core v0.1.25 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling openssl v0.10.38 [INFO] [stderr] Compiling native-tls v0.2.10 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling httparse v1.7.0 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Checking http v0.2.6 [INFO] [stderr] Compiling num-bigint v0.4.3 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling num-rational v0.4.0 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Compiling encoding_rs v0.8.31 [INFO] [stderr] Compiling async-trait v0.1.53 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Compiling openssl-sys v0.9.72 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking ipnet v2.4.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking snowflake v1.3.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking num-complex v0.4.0 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Checking num v0.4.0 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling tracing-attributes v0.1.20 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling zookeeper_derive v0.4.1 [INFO] [stderr] Checking zookeeper v0.6.1 [INFO] [stderr] Checking tokio v1.18.2 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking tracing v0.1.33 [INFO] [stderr] Checking tokio-util v0.7.1 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Checking h2 v0.3.13 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking bimap v0.6.2 [INFO] [stderr] Checking hyper v0.14.18 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.10 [INFO] [stderr] Checking pinot-client-rust v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 51 | extra_http_header: Option, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | ) -> Result> { [INFO] [stdout] 53 | let tansport = JsonHttpClientTransport::new( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(Connection::new(tansport, broker_selector)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 64 | extra_http_header: Option, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | ) -> Result>> { [INFO] [stdout] 66 | let tansport = JsonHttpClientTransport::new( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let zk_conn = connect_to_zookeeper(zk_config)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let external_view_zk_path = format_external_view_zk_path(zk_config); [INFO] [stdout] 73 | let dynamic_broker_selector = auto_refreshing_dynamic_broker_selector( [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | zk_conn, external_view_zk_path, Duration::from_millis(100))?; [INFO] [stdout] 75 | Ok(Connection::new(tansport, dynamic_broker_selector)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dynamic_broker_selector.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 74 | tx: Sender<()>, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | / log_and_discard_error_node_watcher( [INFO] [stdout] 80 | | "Refresh dynamic broker external view", [INFO] [stdout] 81 | | on_node_status_changed( [INFO] [stdout] 82 | | move |_| tx.send(()).map_err(|e| [INFO] [stdout] ... | [INFO] [stdout] 85 | | ), [INFO] [stdout] 86 | | ), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dynamic_broker_selector.rs:97:24 [INFO] [stdout] | [INFO] [stdout] 91 | zk_conn: ZooKeeper, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | external_view_zk_path: String, [INFO] [stdout] 93 | dynamic_broker_selector: Arc, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | timeout: std::time::Duration, [INFO] [stdout] 95 | rx: Receiver<()>, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | ) -> JoinHandle<()> { [INFO] [stdout] 97 | std::thread::spawn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 98 | | looping_receiver("Refresh dynamic broker selector", timeout, rx, |_| { [INFO] [stdout] 99 | | let external_view = get_external_view(&zk_conn, &external_view_zk_path)?; [INFO] [stdout] 100 | | dynamic_broker_selector.refresh_external_view(&external_view)?; [INFO] [stdout] 101 | | Ok(()) [INFO] [stdout] 102 | | }) [INFO] [stdout] 103 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json_http_client_transport.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 88 | extra_headers: http::HeaderMap, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | / client [INFO] [stdout] 92 | | .post(url) [INFO] [stdout] 93 | | .json(&json_value) [INFO] [stdout] 94 | | .headers(extra_headers) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/mod.rs:42:45 [INFO] [stdout] | [INFO] [stdout] 42 | #[derive(Copy, Clone, Debug, PartialEq, Eq, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/data.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | deserialize_data(&data_type, raw_data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/data.rs:169:35 [INFO] [stdout] | [INFO] [stdout] 169 | #[derive(Clone, Debug, PartialEq, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/sql.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 22 | let table: Option> = match raw.result_table { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | Ok(SqlResponse { [INFO] [stdout] | ____________^ [INFO] [stdout] 27 | | table, [INFO] [stdout] 28 | | stats: Some(ResponseStats { [INFO] [stdout] 29 | | trace_info: raw.trace_info, [INFO] [stdout] ... | [INFO] [stdout] 43 | | }), [INFO] [stdout] 44 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/sql.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 54 | let table: Option> = match raw.result_table { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(SqlResponse { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | table, [INFO] [stdout] 60 | | stats: None, [INFO] [stdout] 61 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/sql.rs:122:12 [INFO] [stdout] | [INFO] [stdout] 118 | let rows = raw.rows [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | Ok(Table::new(schema, rows)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 14 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | deserialize_floats_from_json(raw_value).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 25 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | deserialize_float_from_json(raw_value).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 65 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | deserialize_doubles_from_json(raw_value).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 76 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | deserialize_double_from_json(raw_value).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 116 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | deserialize_timestamps_from_json(Deserialize::deserialize(deserializer)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 127 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | deserialize_timestamp_from_json(raw_date).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:177:5 [INFO] [stdout] | [INFO] [stdout] 171 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | deserialize_bytes_array_from_json(raw_value).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:188:5 [INFO] [stdout] | [INFO] [stdout] 182 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | deserialize_bytes_from_json(raw_value).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 216 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | deserialize_json_from_json(raw_value).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:381:9 [INFO] [stdout] | [INFO] [stdout] 373 | seed: K, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 381 | seed.deserialize(Value::String(column_name.to_string())).map(Some) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pinot-client-rust` (lib) due to 22 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broker_selector.rs:26:37 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(return_function: F) -> Self where F: 'static + Fn(&str) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Self { return_function: Arc::new(Box::new(return_function)) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client_transport.rs:51:38 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(sql_return_function: SqlFn, pql_return_function: PqlFn) -> Self [INFO] [stdout] | -------------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | sql_return_function: Arc::new(Box::new(sql_return_function)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client_transport.rs:52:38 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn new(sql_return_function: SqlFn, pql_return_function: PqlFn) -> Self [INFO] [stdout] | -------------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | pql_return_function: Arc::new(Box::new(pql_return_function)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:58:8 [INFO] [stdout] | [INFO] [stdout] 51 | extra_http_header: Option, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | ) -> Result> { [INFO] [stdout] 53 | let tansport = JsonHttpClientTransport::new( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(Connection::new(tansport, broker_selector)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 64 | extra_http_header: Option, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | ) -> Result>> { [INFO] [stdout] 66 | let tansport = JsonHttpClientTransport::new( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let zk_conn = connect_to_zookeeper(zk_config)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let external_view_zk_path = format_external_view_zk_path(zk_config); [INFO] [stdout] 73 | let dynamic_broker_selector = auto_refreshing_dynamic_broker_selector( [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | zk_conn, external_view_zk_path, Duration::from_millis(100))?; [INFO] [stdout] 75 | Ok(Connection::new(tansport, dynamic_broker_selector)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dynamic_broker_selector.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 74 | tx: Sender<()>, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | / log_and_discard_error_node_watcher( [INFO] [stdout] 80 | | "Refresh dynamic broker external view", [INFO] [stdout] 81 | | on_node_status_changed( [INFO] [stdout] 82 | | move |_| tx.send(()).map_err(|e| [INFO] [stdout] ... | [INFO] [stdout] 85 | | ), [INFO] [stdout] 86 | | ), [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dynamic_broker_selector.rs:97:24 [INFO] [stdout] | [INFO] [stdout] 91 | zk_conn: ZooKeeper, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | external_view_zk_path: String, [INFO] [stdout] 93 | dynamic_broker_selector: Arc, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | timeout: std::time::Duration, [INFO] [stdout] 95 | rx: Receiver<()>, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | ) -> JoinHandle<()> { [INFO] [stdout] 97 | std::thread::spawn(move || { [INFO] [stdout] | ________________________^ [INFO] [stdout] 98 | | looping_receiver("Refresh dynamic broker selector", timeout, rx, |_| { [INFO] [stdout] 99 | | let external_view = get_external_view(&zk_conn, &external_view_zk_path)?; [INFO] [stdout] 100 | | dynamic_broker_selector.refresh_external_view(&external_view)?; [INFO] [stdout] 101 | | Ok(()) [INFO] [stdout] 102 | | }) [INFO] [stdout] 103 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dynamic_broker_selector.rs:606:15 [INFO] [stdout] | [INFO] [stdout] 605 | let dynamic_broker_selector = DynamicBrokerSelector::new(&external_view); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 606 | match dynamic_broker_selector.select_random_broker().unwrap_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dynamic_broker_selector.rs:652:15 [INFO] [stdout] | [INFO] [stdout] 651 | let dynamic_broker_selector = DynamicBrokerSelector::new(&external_view); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 652 | match dynamic_broker_selector [INFO] [stdout] | _______________^ [INFO] [stdout] 653 | | .select_random_broker_by_table_name("table") [INFO] [stdout] 654 | | .unwrap_err() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dynamic_broker_selector.rs:683:15 [INFO] [stdout] | [INFO] [stdout] 674 | let dynamic_broker_selector = DynamicBrokerSelector::new(&external_view); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 683 | match dynamic_broker_selector [INFO] [stdout] | _______________^ [INFO] [stdout] 684 | | .select_random_broker_by_table_name("") [INFO] [stdout] 685 | | .unwrap_err() [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dynamic_broker_selector.rs:737:15 [INFO] [stdout] | [INFO] [stdout] 728 | let dynamic_broker_selector = DynamicBrokerSelector::new(&external_view); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 729 | let select_all_broker = dynamic_broker_selector.select_broker(""); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 730 | let select_table_broker = dynamic_broker_selector.select_broker("baseballStats"); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 737 | match select_table_broker.unwrap_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/json_http_client_transport.rs:91:5 [INFO] [stdout] | [INFO] [stdout] 88 | extra_headers: http::HeaderMap, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | / client [INFO] [stdout] 92 | | .post(url) [INFO] [stdout] 93 | | .json(&json_value) [INFO] [stdout] 94 | | .headers(extra_headers) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/mod.rs:42:45 [INFO] [stdout] | [INFO] [stdout] 42 | #[derive(Copy, Clone, Debug, PartialEq, Eq, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/data.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | deserialize_data(&data_type, raw_data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/data.rs:169:35 [INFO] [stdout] | [INFO] [stdout] 169 | #[derive(Clone, Debug, PartialEq, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/sql.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 22 | let table: Option> = match raw.result_table { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | Ok(SqlResponse { [INFO] [stdout] | ____________^ [INFO] [stdout] 27 | | table, [INFO] [stdout] 28 | | stats: Some(ResponseStats { [INFO] [stdout] 29 | | trace_info: raw.trace_info, [INFO] [stdout] ... | [INFO] [stdout] 43 | | }), [INFO] [stdout] 44 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/sql.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 54 | let table: Option> = match raw.result_table { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | Ok(SqlResponse { [INFO] [stdout] | ____________^ [INFO] [stdout] 59 | | table, [INFO] [stdout] 60 | | stats: None, [INFO] [stdout] 61 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/sql.rs:122:12 [INFO] [stdout] | [INFO] [stdout] 118 | let rows = raw.rows [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | Ok(Table::new(schema, rows)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 14 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | deserialize_floats_from_json(raw_value).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 25 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | deserialize_float_from_json(raw_value).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 65 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | deserialize_doubles_from_json(raw_value).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 76 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | deserialize_double_from_json(raw_value).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 116 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | deserialize_timestamps_from_json(Deserialize::deserialize(deserializer)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 127 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | deserialize_timestamp_from_json(raw_date).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:177:5 [INFO] [stdout] | [INFO] [stdout] 171 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | deserialize_bytes_array_from_json(raw_value).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:188:5 [INFO] [stdout] | [INFO] [stdout] 182 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | deserialize_bytes_from_json(raw_value).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 216 | deserializer: D [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | deserialize_json_from_json(raw_value).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/response/deserialise.rs:381:9 [INFO] [stdout] | [INFO] [stdout] 373 | seed: K, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 381 | seed.deserialize(Value::String(column_name.to_string())).map(Some) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/response/mod.rs:143:41 [INFO] [stdout] | [INFO] [stdout] 143 | "message": error_message.clone(), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/simple_broker_selector.rs:57:15 [INFO] [stdout] | [INFO] [stdout] 56 | let simple_broker_selector = SimpleBrokerSelector::new(vec![]); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | match simple_broker_selector.unwrap_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zookeeper.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 124 | let copy = state.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | copy.write().unwrap().push(event) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zookeeper.rs:152:29 [INFO] [stdout] | [INFO] [stdout] 152 | "test", |_| Err(Error::NoAvailableBroker)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zookeeper.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | DynamicBrokerSelectorError::PoisonedConcurrentAllBrokerListWrite.into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 32 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pinot-client-rust` (lib test) due to 33 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "ac46f75aabb71ea20c1880d2eab63e61edcfd9048e1bd953417926d92cfe88f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac46f75aabb71ea20c1880d2eab63e61edcfd9048e1bd953417926d92cfe88f6", kill_on_drop: false }` [INFO] [stdout] ac46f75aabb71ea20c1880d2eab63e61edcfd9048e1bd953417926d92cfe88f6