[INFO] fetching crate pinned_sync 0.0.1... [INFO] checking pinned_sync-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pinned_sync 0.0.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate pinned_sync 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pinned_sync 0.0.1 [INFO] finished tweaking crates.io crate pinned_sync 0.0.1 [INFO] tweaked toml for crates.io crate pinned_sync 0.0.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 16 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 95d5ef192ce7386c27c28562b15c9b3aedcdaf3efa7a5531d3efb4ad230d817f [INFO] running `Command { std: "docker" "start" "-a" "95d5ef192ce7386c27c28562b15c9b3aedcdaf3efa7a5531d3efb4ad230d817f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "95d5ef192ce7386c27c28562b15c9b3aedcdaf3efa7a5531d3efb4ad230d817f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95d5ef192ce7386c27c28562b15c9b3aedcdaf3efa7a5531d3efb4ad230d817f", kill_on_drop: false }` [INFO] [stdout] 95d5ef192ce7386c27c28562b15c9b3aedcdaf3efa7a5531d3efb4ad230d817f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a4117a6680dd2a41ada6538b45d31eae94997515e1f18b3554aeadf15e05fae0 [INFO] running `Command { std: "docker" "start" "-a" "a4117a6680dd2a41ada6538b45d31eae94997515e1f18b3554aeadf15e05fae0", kill_on_drop: false }` [INFO] [stderr] Checking pinned_sync v0.0.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/condvar.rs:241:15 [INFO] [stdout] | [INFO] [stdout] 237 | lock: MutexGuard<'a, T>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | match lock.map(|guard| unsafe { [INFO] [stdout] | _______________^ [INFO] [stdout] 242 | | let (ok, guard) = self.inner().wait_timeout(guard, dur); [INFO] [stdout] 243 | | timeout = !ok; [INFO] [stdout] 244 | | guard [INFO] [stdout] 245 | | }) { [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutex.rs:67:20 [INFO] [stdout] | [INFO] [stdout] 65 | pub const fn uninit(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | Self { [INFO] [stdout] 67 | inner: sys::Mutex::uninit(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutex.rs:70:19 [INFO] [stdout] | [INFO] [stdout] 65 | pub const fn uninit(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | data: UnsafeCell::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutex.rs:131:50 [INFO] [stdout] | [INFO] [stdout] 130 | let guard = self.inner().lock(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | poison::map_result(self.poison.borrow(), |poison| MutexGuard { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 132 | | guard, [INFO] [stdout] 133 | | mutex: self, [INFO] [stdout] 134 | | poison, [INFO] [stdout] 135 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutex.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 157 | let guard = self.inner().try_lock().ok_or(TryLockError::WouldBlock)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | Ok(poison::map_result(self.poison.borrow(), |poison| { [INFO] [stdout] | ____________^ [INFO] [stdout] 159 | | MutexGuard { [INFO] [stdout] 160 | | guard, [INFO] [stdout] 161 | | mutex: self, [INFO] [stdout] 162 | | poison, [INFO] [stdout] 163 | | } [INFO] [stdout] 164 | | })?) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutex.rs:188:45 [INFO] [stdout] | [INFO] [stdout] 183 | pub fn into_inner(self) -> LockResult [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let Self { data, poison, .. } = self; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | poison::map_result(poison.borrow(), |_| data.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mutex.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 223 | pub(crate) fn map(self, f: impl FnOnce(sys::MutexGuard<'a>) -> sys::MutexGuard<'a>) -> LockResult { [INFO] [stdout] | ---- ---------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | let (guard, mutex, poison) = unsafe { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | let guard = ptr::read(&self.guard); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | let guard = f(guard); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | [INFO] [stdout] 234 | / Self { [INFO] [stdout] 235 | | guard, [INFO] [stdout] 236 | | mutex, [INFO] [stdout] 237 | | poison, [INFO] [stdout] 238 | | }.repoison() [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rwlock.rs:60:20 [INFO] [stdout] | [INFO] [stdout] 58 | pub const fn uninit(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | Self { [INFO] [stdout] 60 | inner: sys::RwLock::uninit(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rwlock.rs:63:19 [INFO] [stdout] | [INFO] [stdout] 58 | pub const fn uninit(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | data: UnsafeCell::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rwlock.rs:123:50 [INFO] [stdout] | [INFO] [stdout] 122 | let guard = self.inner().read(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | poison::map_result(self.poison.borrow(), |_| RwLockReadGuard { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 124 | | _guard: guard, [INFO] [stdout] 125 | | lock: self, [INFO] [stdout] 126 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rwlock.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 152 | let guard = self.inner().try_read().ok_or(TryLockError::WouldBlock)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | Ok(poison::map_result(self.poison.borrow(), |_| { [INFO] [stdout] | ____________^ [INFO] [stdout] 154 | | RwLockReadGuard { [INFO] [stdout] 155 | | _guard: guard, [INFO] [stdout] 156 | | lock: self, [INFO] [stdout] 157 | | } [INFO] [stdout] 158 | | })?) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rwlock.rs:184:50 [INFO] [stdout] | [INFO] [stdout] 183 | let guard = self.inner().write(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | poison::map_result(self.poison.borrow(), |poison| RwLockWriteGuard { [INFO] [stdout] | __________________________________________________^ [INFO] [stdout] 185 | | _guard: guard, [INFO] [stdout] 186 | | lock: self, [INFO] [stdout] 187 | | poison, [INFO] [stdout] 188 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rwlock.rs:215:12 [INFO] [stdout] | [INFO] [stdout] 214 | let guard = self.inner().try_write().ok_or(TryLockError::WouldBlock)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | Ok(poison::map_result(self.poison.borrow(), |poison| { [INFO] [stdout] | ____________^ [INFO] [stdout] 216 | | RwLockWriteGuard { [INFO] [stdout] 217 | | _guard: guard, [INFO] [stdout] 218 | | lock: self, [INFO] [stdout] 219 | | poison, [INFO] [stdout] 220 | | } [INFO] [stdout] 221 | | })?) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rwlock.rs:245:45 [INFO] [stdout] | [INFO] [stdout] 240 | pub fn into_inner(self) -> LockResult [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | let Self { data, poison, .. } = self; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | poison::map_result(poison.borrow(), |_| data.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sys_common/init_assert.rs:29:45 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn init(&self, f: F) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | unsafe { self.init_with(|p| p.write(f())) } [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking rand v0.8.5 [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pinned_sync` (lib) due to 16 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a4117a6680dd2a41ada6538b45d31eae94997515e1f18b3554aeadf15e05fae0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4117a6680dd2a41ada6538b45d31eae94997515e1f18b3554aeadf15e05fae0", kill_on_drop: false }` [INFO] [stdout] a4117a6680dd2a41ada6538b45d31eae94997515e1f18b3554aeadf15e05fae0