[INFO] fetching crate pink-trombone 0.2.1... [INFO] checking pink-trombone-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pink-trombone 0.2.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate pink-trombone 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pink-trombone 0.2.1 [INFO] finished tweaking crates.io crate pink-trombone 0.2.1 [INFO] tweaked toml for crates.io crate pink-trombone 0.2.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate pink-trombone 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d2b6a9201e904141b75fa7b762c9b86fc480c41ac6a7da3903c9f95ff8d85f28 [INFO] running `Command { std: "docker" "start" "-a" "d2b6a9201e904141b75fa7b762c9b86fc480c41ac6a7da3903c9f95ff8d85f28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d2b6a9201e904141b75fa7b762c9b86fc480c41ac6a7da3903c9f95ff8d85f28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d2b6a9201e904141b75fa7b762c9b86fc480c41ac6a7da3903c9f95ff8d85f28", kill_on_drop: false }` [INFO] [stdout] d2b6a9201e904141b75fa7b762c9b86fc480c41ac6a7da3903c9f95ff8d85f28 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3dd61c8bbe62664cb4c1459fd1d952cbd21a15db36f0ab30dde508445a8c3570 [INFO] running `Command { std: "docker" "start" "-a" "3dd61c8bbe62664cb4c1459fd1d952cbd21a15db36f0ab30dde508445a8c3570", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling proc-macro2 v1.0.28 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.74 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking instant v0.1.10 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling cpal v0.13.3 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking hound v3.4.0 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Checking tinyvec v1.3.1 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking ogg v0.8.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking nix v0.20.0 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking slice-deque v0.3.0 [INFO] [stderr] Compiling jobserver v0.1.22 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling cc v1.0.69 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Compiling minimp3-sys v0.3.2 [INFO] [stderr] Checking pink-trombone v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `z` is never read [INFO] [stdout] --> src/noise_gen.rs:3:33 [INFO] [stdout] | [INFO] [stdout] 2 | struct Grad { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 3 | pub x: f32, pub y: f32, pub z: f32 [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Grad` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/noise.rs:16:14 [INFO] [stdout] | [INFO] [stdout] 14 | let mut white_noise = new_looped_white_noise(loop_size, rng); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let mut filter = new_bandpass_filter(f0, q, sample_rate); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Box::new(move || filter.filter(white_noise.noise())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tract.rs:68:37 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn new(glottis: Glottis, sample_rate: u32, rng: &mut dyn NoiseSource) -> Tract { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | frication_noise_source: noise::new_filtered_noise_source( [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 69 | | 1000.0, [INFO] [stdout] 70 | | 0.5, [INFO] [stdout] 71 | | sample_rate, [INFO] [stdout] 72 | | 0x8000, [INFO] [stdout] 73 | | rng, [INFO] [stdout] 74 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trombone.rs:26:21 [INFO] [stdout] | [INFO] [stdout] 21 | let glottis = Glottis::new(sample_rate, rng, seed); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | // tract runs at twice the sample rate [INFO] [stdout] 23 | let tract = Tract::new(glottis, 2 * sample_rate, rng); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | shaper: TractShaper::new(tract), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pink-trombone` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "3dd61c8bbe62664cb4c1459fd1d952cbd21a15db36f0ab30dde508445a8c3570", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3dd61c8bbe62664cb4c1459fd1d952cbd21a15db36f0ab30dde508445a8c3570", kill_on_drop: false }` [INFO] [stdout] 3dd61c8bbe62664cb4c1459fd1d952cbd21a15db36f0ab30dde508445a8c3570