[INFO] fetching crate pinix 0.3.0... [INFO] checking pinix-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pinix 0.3.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate pinix 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pinix 0.3.0 [INFO] finished tweaking crates.io crate pinix 0.3.0 [INFO] tweaked toml for crates.io crate pinix 0.3.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate pinix 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 354dfa8af391c2a80d0e7093335d5dd788ab8c1c6e855c9cf2f1541617bf0b20 [INFO] running `Command { std: "docker" "start" "-a" "354dfa8af391c2a80d0e7093335d5dd788ab8c1c6e855c9cf2f1541617bf0b20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "354dfa8af391c2a80d0e7093335d5dd788ab8c1c6e855c9cf2f1541617bf0b20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "354dfa8af391c2a80d0e7093335d5dd788ab8c1c6e855c9cf2f1541617bf0b20", kill_on_drop: false }` [INFO] [stdout] 354dfa8af391c2a80d0e7093335d5dd788ab8c1c6e855c9cf2f1541617bf0b20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7224a2ef5adca0a57233e86a4f44b85a60e2b7eb3b06d3ad741c954152eb865c [INFO] running `Command { std: "docker" "start" "-a" "7224a2ef5adca0a57233e86a4f44b85a60e2b7eb3b06d3ad741c954152eb865c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking condtype v1.3.0 [INFO] [stderr] Checking regex-lite v0.1.5 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking indexmap v2.2.3 [INFO] [stderr] Compiling syn v2.0.49 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking clap_builder v4.5.1 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling serde_repr v0.1.18 [INFO] [stderr] Compiling divan-macros v0.1.14 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking clap v4.5.1 [INFO] [stderr] Checking divan v0.1.14 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking pinix v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/action.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 149 | raw.try_into().context("Could not convert raw action") [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:114:44 [INFO] [stdout] | [INFO] [stdout] 114 | prev_handlers.retain_mut(|h| match h.on_action(self, action) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:130:28 [INFO] [stdout] | [INFO] [stdout] 129 | pub fn plug(&mut self, handler: H) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | self.handlers.push(Box::new(handler) as _) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn println(&self, msg: impl AsRef) -> anyhow::Result<()> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | / self.multi_progress [INFO] [stdout] 159 | | .println(msg) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/style.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 82 | main: impl FnOnce(u16) -> R1, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | bar: impl FnOnce(u16) -> R2, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | / ProgressStyle::with_template(&format!("{}{}{elapsed}", main(main_size), bar(bar_size))) [INFO] [stdout] 108 | | .expect("invalid template") [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wrapper/stream.rs:44:21 [INFO] [stdout] | [INFO] [stdout] 42 | fn new(reader: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | Self { [INFO] [stdout] 44 | reader: BufReader::new(reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wrapper/stream.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 85 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | stdout: BorrowLines::new(stdout), [INFO] [stdout] 87 | | stderr: BorrowLines::new(stderr), [INFO] [stdout] 88 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/action.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 149 | raw.try_into().context("Could not convert raw action") [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:114:44 [INFO] [stdout] | [INFO] [stdout] 114 | prev_handlers.retain_mut(|h| match h.on_action(self, action) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:130:28 [INFO] [stdout] | [INFO] [stdout] 129 | pub fn plug(&mut self, handler: H) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | self.handlers.push(Box::new(handler) as _) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn println(&self, msg: impl AsRef) -> anyhow::Result<()> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | / self.multi_progress [INFO] [stdout] 159 | | .println(msg) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/style.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 82 | main: impl FnOnce(u16) -> R1, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | bar: impl FnOnce(u16) -> R2, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | / ProgressStyle::with_template(&format!("{}{}{elapsed}", main(main_size), bar(bar_size))) [INFO] [stdout] 108 | | .expect("invalid template") [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wrapper/stream.rs:44:21 [INFO] [stdout] | [INFO] [stdout] 42 | fn new(reader: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | Self { [INFO] [stdout] 44 | reader: BufReader::new(reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wrapper/stream.rs:85:12 [INFO] [stdout] | [INFO] [stdout] 85 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 86 | | stdout: BorrowLines::new(stdout), [INFO] [stdout] 87 | | stderr: BorrowLines::new(stderr), [INFO] [stdout] 88 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pinix` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pinix` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "7224a2ef5adca0a57233e86a4f44b85a60e2b7eb3b06d3ad741c954152eb865c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7224a2ef5adca0a57233e86a4f44b85a60e2b7eb3b06d3ad741c954152eb865c", kill_on_drop: false }` [INFO] [stdout] 7224a2ef5adca0a57233e86a4f44b85a60e2b7eb3b06d3ad741c954152eb865c