[INFO] fetching crate pingora-load-balancing 0.3.0... [INFO] checking pingora-load-balancing-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pingora-load-balancing 0.3.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate pingora-load-balancing 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pingora-load-balancing 0.3.0 [INFO] finished tweaking crates.io crate pingora-load-balancing 0.3.0 [INFO] tweaked toml for crates.io crate pingora-load-balancing 0.3.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 267 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bindgen v0.68.1 (latest: v0.70.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding brotli v3.5.0 (latest: v6.0.0) [INFO] [stderr] Adding brotli-decompressor v2.5.1 (latest: v4.0.1) [INFO] [stderr] Adding clap v3.2.25 (latest: v4.5.16) [INFO] [stderr] Adding clap_derive v3.2.25 (latest: v4.5.13) [INFO] [stderr] Adding clap_lex v0.2.4 (latest: v0.7.2) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h2 v0.3.26 (latest: v0.4.6) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding hostname v0.3.1 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (latest: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (latest: v1.4.1) [INFO] [stderr] Adding hyper-rustls v0.24.2 (latest: v0.27.2) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding memoffset v0.6.5 (latest: v0.9.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nix v0.24.3 (latest: v0.29.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (latest: v7.0.0) [INFO] [stderr] Adding peeking_take_while v0.1.2 (latest: v1.0.0) [INFO] [stderr] Adding protobuf v2.28.0 (latest: v3.5.1) [INFO] [stderr] Adding reqwest v0.11.27 (latest: v0.12.7) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding sentry v0.26.0 (latest: v0.34.0) [INFO] [stderr] Adding sentry-backtrace v0.26.0 (latest: v0.34.0) [INFO] [stderr] Adding sentry-contexts v0.26.0 (latest: v0.34.0) [INFO] [stderr] Adding sentry-core v0.26.0 (latest: v0.34.0) [INFO] [stderr] Adding sentry-panic v0.26.0 (latest: v0.34.0) [INFO] [stderr] Adding sentry-types v0.26.0 (latest: v0.34.0) [INFO] [stderr] Adding serde_yaml v0.8.26 (latest: v0.9.34+deprecated) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding sync_wrapper v0.1.2 (latest: v1.0.1) [INFO] [stderr] Adding system-configuration v0.5.1 (latest: v0.6.1) [INFO] [stderr] Adding system-configuration-sys v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding tokio-rustls v0.24.1 (latest: v0.26.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webpki-roots v0.25.4 (latest: v0.26.5) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding winreg v0.50.0 (latest: v0.52.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fc719021814e5821605c8eaa45a741991b5a31b501570724f2ff4c27c92ddced [INFO] running `Command { std: "docker" "start" "-a" "fc719021814e5821605c8eaa45a741991b5a31b501570724f2ff4c27c92ddced", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fc719021814e5821605c8eaa45a741991b5a31b501570724f2ff4c27c92ddced", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc719021814e5821605c8eaa45a741991b5a31b501570724f2ff4c27c92ddced", kill_on_drop: false }` [INFO] [stdout] fc719021814e5821605c8eaa45a741991b5a31b501570724f2ff4c27c92ddced [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] af8243bb37ea51d7b335fd345c9f3a3a81100dfc702dd30553d3e0476646783f [INFO] running `Command { std: "docker" "start" "-a" "af8243bb37ea51d7b335fd345c9f3a3a81100dfc702dd30553d3e0476646783f", kill_on_drop: false }` [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling sentry-contexts v0.26.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling protobuf v2.28.0 [INFO] [stderr] Compiling rust_decimal v1.36.0 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Compiling tokio-openssl v0.6.4 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking cc v1.1.15 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking uname v0.1.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling prometheus v0.13.4 [INFO] [stderr] Checking webpki-roots v0.25.4 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Checking brotli-decompressor v2.5.1 [INFO] [stderr] Checking pingora-error v0.3.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking openssl-src v300.3.1+3.3.1 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking pingora-http v0.3.0 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking daemonize v0.5.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking pingora-ketama v0.3.0 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking brotli v3.5.0 [INFO] [stderr] Compiling cmake v0.1.51 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling libz-ng-sys v1.1.16 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking sfv v0.9.4 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking pingora-timeout v0.3.0 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking pingora-runtime v0.3.0 [INFO] [stderr] Checking pingora-pool v0.3.0 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking debugid v0.8.0 [INFO] [stderr] Checking sentry-types v0.26.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking sentry-core v0.26.0 [INFO] [stderr] Checking sentry-backtrace v0.26.0 [INFO] [stderr] Checking sentry-panic v0.26.0 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking sentry v0.26.0 [INFO] [stderr] Checking pingora-openssl v0.3.0 [INFO] [stderr] Checking pingora-core v0.3.0 [INFO] [stderr] Checking pingora-load-balancing v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:119:27 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn new(discovery: Box) -> Self { [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | health_check: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:120:23 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn new(discovery: Box) -> Self { [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | backends: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:121:21 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn new(discovery: Box) -> Self { [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | health: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:249:31 [INFO] [stdout] | [INFO] [stdout] 247 | let check = health_check.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | let ht = health_table.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | runtime.spawn(async move { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 250 | | check_and_report(&backend, &check, &ht).await; [INFO] [stdout] 251 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/background.rs:28:80 [INFO] [stdout] | [INFO] [stdout] 28 | async fn start(&self, shutdown: pingora_core::server::ShutdownWatch) -> () { [INFO] [stdout] | ___________________________---------------------------------------------________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | | // 136 years [INFO] [stdout] 30 | | const NEVER: Duration = Duration::from_secs(u32::MAX as u64); [INFO] [stdout] 31 | | let mut now = Instant::now(); [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/discovery.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn try_from_iter>(iter: T) -> IoResult> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok(Self::new(upstreams)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/health_check.rs:69:24 [INFO] [stdout] | [INFO] [stdout] 63 | let mut peer_template = BasicPeer::new("0.0.0.0:1"); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | connector: TransportConnector::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/health_check.rs:172:24 [INFO] [stdout] | [INFO] [stdout] 162 | let mut req = RequestHeader::build("GET", b"/", None).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | let mut peer_template = HttpPeer::new("0.0.0.0:1", tls, sni); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | connector: HttpConnector::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/health_check.rs:175:24 [INFO] [stdout] | [INFO] [stdout] 162 | let mut req = RequestHeader::build("GET", b"/", None).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | let mut peer_template = HttpPeer::new("0.0.0.0:1", tls, sni); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | validator: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/health_check.rs:268:16 [INFO] [stdout] | [INFO] [stdout] 267 | let inner = self.0.load_full(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | Health(ArcSwap::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/selection/mod.rs:98:19 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn new(iter: I, max_iterations: usize) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | seen: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/selection/weighted.rs:49:23 [INFO] [stdout] | [INFO] [stdout] 40 | let backends = Vec::from_iter(backends.iter().cloned()).into_boxed_slice(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | weighted: weighted.into_boxed_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/selection/weighted.rs:50:24 [INFO] [stdout] | [INFO] [stdout] 40 | let backends = Vec::from_iter(backends.iter().cloned()).into_boxed_slice(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | algorithm: H::new(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pingora-load-balancing` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:119:27 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn new(discovery: Box) -> Self { [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | health_check: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:120:23 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn new(discovery: Box) -> Self { [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | backends: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:121:21 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn new(discovery: Box) -> Self { [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | health: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:249:31 [INFO] [stdout] | [INFO] [stdout] 247 | let check = health_check.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | let ht = health_table.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | runtime.spawn(async move { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 250 | | check_and_report(&backend, &check, &ht).await; [INFO] [stdout] 251 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/background.rs:28:80 [INFO] [stdout] | [INFO] [stdout] 28 | async fn start(&self, shutdown: pingora_core::server::ShutdownWatch) -> () { [INFO] [stdout] | ___________________________---------------------------------------------________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | | // 136 years [INFO] [stdout] 30 | | const NEVER: Duration = Duration::from_secs(u32::MAX as u64); [INFO] [stdout] 31 | | let mut now = Instant::now(); [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/discovery.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn try_from_iter>(iter: T) -> IoResult> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok(Self::new(upstreams)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/health_check.rs:69:24 [INFO] [stdout] | [INFO] [stdout] 63 | let mut peer_template = BasicPeer::new("0.0.0.0:1"); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | connector: TransportConnector::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/health_check.rs:172:24 [INFO] [stdout] | [INFO] [stdout] 162 | let mut req = RequestHeader::build("GET", b"/", None).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | let mut peer_template = HttpPeer::new("0.0.0.0:1", tls, sni); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | connector: HttpConnector::new(None), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/health_check.rs:175:24 [INFO] [stdout] | [INFO] [stdout] 162 | let mut req = RequestHeader::build("GET", b"/", None).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | let mut peer_template = HttpPeer::new("0.0.0.0:1", tls, sni); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | validator: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/health_check.rs:268:16 [INFO] [stdout] | [INFO] [stdout] 267 | let inner = self.0.load_full(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 268 | Health(ArcSwap::new(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/selection/mod.rs:98:19 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn new(iter: I, max_iterations: usize) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | seen: HashSet::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/selection/weighted.rs:49:23 [INFO] [stdout] | [INFO] [stdout] 40 | let backends = Vec::from_iter(backends.iter().cloned()).into_boxed_slice(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | weighted: weighted.into_boxed_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/selection/weighted.rs:50:24 [INFO] [stdout] | [INFO] [stdout] 40 | let backends = Vec::from_iter(backends.iter().cloned()).into_boxed_slice(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | algorithm: H::new(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pingora-load-balancing` (lib test) due to 14 previous errors [INFO] running `Command { std: "docker" "inspect" "af8243bb37ea51d7b335fd345c9f3a3a81100dfc702dd30553d3e0476646783f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af8243bb37ea51d7b335fd345c9f3a3a81100dfc702dd30553d3e0476646783f", kill_on_drop: false }` [INFO] [stdout] af8243bb37ea51d7b335fd345c9f3a3a81100dfc702dd30553d3e0476646783f