[INFO] fetching crate pingora-cache 0.3.0... [INFO] checking pingora-cache-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pingora-cache 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate pingora-cache 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pingora-cache 0.3.0 [INFO] finished tweaking crates.io crate pingora-cache 0.3.0 [INFO] tweaked toml for crates.io crate pingora-cache 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 289 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bindgen v0.68.1 (latest: v0.70.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding brotli v3.5.0 (latest: v6.0.0) [INFO] [stderr] Adding brotli-decompressor v2.5.1 (latest: v4.0.1) [INFO] [stderr] Adding clap v3.2.25 (latest: v4.5.16) [INFO] [stderr] Adding clap_derive v3.2.25 (latest: v4.5.13) [INFO] [stderr] Adding clap_lex v0.2.4 (latest: v0.7.2) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding env_logger v0.9.3 (latest: v0.11.5) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h2 v0.3.26 (latest: v0.4.6) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding hostname v0.3.1 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (latest: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (latest: v1.4.1) [INFO] [stderr] Adding hyper-rustls v0.24.2 (latest: v0.27.2) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding memoffset v0.6.5 (latest: v0.9.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nix v0.24.3 (latest: v0.29.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (latest: v7.0.0) [INFO] [stderr] Adding peeking_take_while v0.1.2 (latest: v1.0.0) [INFO] [stderr] Adding protobuf v2.28.0 (latest: v3.5.1) [INFO] [stderr] Adding reqwest v0.11.27 (latest: v0.12.7) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding rustracing v0.5.1 (latest: v0.6.0) [INFO] [stderr] Adding rustracing_jaeger v0.7.0 (latest: v0.10.0) [INFO] [stderr] Adding sentry v0.26.0 (latest: v0.34.0) [INFO] [stderr] Adding sentry-backtrace v0.26.0 (latest: v0.34.0) [INFO] [stderr] Adding sentry-contexts v0.26.0 (latest: v0.34.0) [INFO] [stderr] Adding sentry-core v0.26.0 (latest: v0.34.0) [INFO] [stderr] Adding sentry-panic v0.26.0 (latest: v0.34.0) [INFO] [stderr] Adding sentry-types v0.26.0 (latest: v0.34.0) [INFO] [stderr] Adding serde_yaml v0.8.26 (latest: v0.9.34+deprecated) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding sync_wrapper v0.1.2 (latest: v1.0.1) [INFO] [stderr] Adding system-configuration v0.5.1 (latest: v0.6.1) [INFO] [stderr] Adding system-configuration-sys v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding thrift_codec v0.1.1 (latest: v0.3.2) [INFO] [stderr] Adding tokio-rustls v0.24.1 (latest: v0.26.0) [INFO] [stderr] Adding trackable v0.2.24 (latest: v1.3.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webpki-roots v0.25.4 (latest: v0.26.5) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding winreg v0.50.0 (latest: v0.52.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 548a556b832a88a075fec4917d80e2d413ae196e9a1aed6961b9f7e326cc53a7 [INFO] running `Command { std: "docker" "start" "-a" "548a556b832a88a075fec4917d80e2d413ae196e9a1aed6961b9f7e326cc53a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "548a556b832a88a075fec4917d80e2d413ae196e9a1aed6961b9f7e326cc53a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "548a556b832a88a075fec4917d80e2d413ae196e9a1aed6961b9f7e326cc53a7", kill_on_drop: false }` [INFO] [stdout] 548a556b832a88a075fec4917d80e2d413ae196e9a1aed6961b9f7e326cc53a7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6beeb237945f9130fa9a106dfd0b5e8717d806d6b648189918f950d475278424 [INFO] running `Command { std: "docker" "start" "-a" "6beeb237945f9130fa9a106dfd0b5e8717d806d6b648189918f950d475278424", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling openssl-src v300.3.1+3.3.1 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling cmake v0.1.51 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling trackable_derive v1.0.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking debugid v0.8.0 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking match_cfg v0.1.0 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking trackable v1.3.0 [INFO] [stderr] Checking sentry-types v0.26.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Compiling libz-ng-sys v1.1.16 [INFO] [stderr] Compiling sentry-contexts v0.26.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling protobuf v2.28.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Compiling rust_decimal v1.36.0 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Compiling tokio-openssl v0.6.4 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking trackable v0.2.24 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking sentry-core v0.26.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking uname v0.1.1 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking sentry-backtrace v0.26.0 [INFO] [stderr] Checking pingora-error v0.3.0 [INFO] [stderr] Compiling prometheus v0.13.4 [INFO] [stderr] Checking webpki-roots v0.25.4 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking pingora-http v0.3.0 [INFO] [stderr] Checking sentry-panic v0.26.0 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking pingora-timeout v0.3.0 [INFO] [stderr] Checking brotli-decompressor v2.5.1 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sfv v0.9.4 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking pingora-pool v0.3.0 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking rustracing v0.5.1 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking brotli v3.5.0 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking thrift_codec v0.1.1 [INFO] [stderr] Checking pingora-runtime v0.3.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking sentry v0.26.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking daemonize v0.5.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking rustracing_jaeger v0.7.0 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking pingora-lru v0.3.0 [INFO] [stderr] Checking thousands v0.2.0 [INFO] [stderr] Checking mintex v0.1.3 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking dhat v0.3.3 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking pingora-header-serde v0.3.0 [INFO] [stderr] Checking pingora-openssl v0.3.0 [INFO] [stderr] Checking pingora-core v0.3.0 [INFO] [stderr] Checking pingora-cache v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:921:26 [INFO] [stdout] | [INFO] [stdout] 914 | let result = result.and_then(|(meta, header)| { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 921 | Some((meta, header)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_control.rs:188:14 [INFO] [stdout] | [INFO] [stdout] 166 | let mut directives = IndexMap::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | Some(CacheControl { directives }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eviction/lru.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 146 | item: CompactCacheKey, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | / self.0 [INFO] [stdout] 153 | | .evict_to_limit() [INFO] [stdout] 154 | | .into_iter() [INFO] [stdout] 155 | | .map(|(key, _weight)| key) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eviction/lru.rs:197:17 [INFO] [stdout] | [INFO] [stdout] 195 | let mut file = File::create(&file_path) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | .or_err_with(InternalError, || err_str_path("fail to create", &file_path))?; [INFO] [stdout] 197 | file.write_all(&data).or_err_with(InternalError, || { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eviction/simple_lru.rs:234:13 [INFO] [stdout] | [INFO] [stdout] 231 | let mut file = File::create(&file_path).or_err_with(InternalError, || { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | file.write_all(&data).or_err_with(InternalError, || { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:238:10 [INFO] [stdout] | [INFO] [stdout] 236 | let lock = LockCore::new_arc(timeout); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | let stub = LockStub(lock.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | (WritePermit(lock), stub) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/max_file_size.rs:55:89 [INFO] [stdout] | [INFO] [stdout] 55 | async fn write_body(&mut self, data: Bytes, eof: bool) -> pingora_error::Result<()> { [INFO] [stdout] | ____________________________________-----------__________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | | // fail if writing the body would exceed the max_file_size_bytes [INFO] [stdout] 57 | | if self.bytes_written + data.len() > self.max_file_size_bytes { [INFO] [stdout] 58 | | return Error::e_explain( [INFO] [stdout] ... | [INFO] [stdout] 69 | | self.inner.write_body(data, eof).await [INFO] [stdout] 70 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/max_file_size.rs:72:70 [INFO] [stdout] | [INFO] [stdout] 72 | async fn finish(self: Box) -> pingora_error::Result { [INFO] [stdout] | _____________________----_____________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | | self.inner.finish().await [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:54:19 [INFO] [stdout] | [INFO] [stdout] 51 | let (tx, _rx) = watch::channel(PartialState::Partial(0)); [INFO] [stdout] | -- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | body: Arc::new(RwLock::new(Vec::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:55:28 [INFO] [stdout] | [INFO] [stdout] 51 | let (tx, _rx) = watch::channel(PartialState::Partial(0)); [INFO] [stdout] | -- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | bytes_written: Arc::new(tx), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:185:21 [INFO] [stdout] | [INFO] [stdout] 181 | self: Box, // because self is always used as a trait object [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | ) -> Result<()> { [INFO] [stdout] | _____________________^ [INFO] [stdout] 186 | | Ok(()) [INFO] [stdout] 187 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:222:81 [INFO] [stdout] | [INFO] [stdout] 222 | async fn write_body(&mut self, data: bytes::Bytes, eof: bool) -> Result<()> { [INFO] [stdout] | ____________________________________------------------___________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | | let current_bytes = match *self.bytes_written.borrow() { [INFO] [stdout] 224 | | PartialState::Partial(p) => p, [INFO] [stdout] 225 | | PartialState::Complete(_) => panic!("already EOF"), [INFO] [stdout] ... | [INFO] [stdout] 235 | | Ok(()) [INFO] [stdout] 236 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:238:55 [INFO] [stdout] | [INFO] [stdout] 238 | async fn finish(self: Box) -> Result { [INFO] [stdout] | _____________________----______________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | | // safe, the temp object is inserted when the miss handler is created [INFO] [stdout] 240 | | let cache_object = self.temp.read().get(&self.key).unwrap().make_cache_object(); [INFO] [stdout] 241 | | let size = cache_object.body.len(); // FIXME: this just body size, also track meta size [INFO] [stdout] ... | [INFO] [stdout] 244 | | Ok(size) [INFO] [stdout] 245 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta.rs:336:19 [INFO] [stdout] | [INFO] [stdout] 334 | header: ResponseHeader, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 335 | ) -> CacheMeta { [INFO] [stdout] 336 | CacheMeta(Box::new(CacheMetaInner { [INFO] [stdout] | ___________________^ [INFO] [stdout] 337 | | internal: InternalMeta { [INFO] [stdout] 338 | | version: InternalMeta::VERSION, [INFO] [stdout] 339 | | fresh_until, [INFO] [stdout] ... | [INFO] [stdout] 347 | | extensions: Extensions::new(), [INFO] [stdout] 348 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta.rs:505:12 [INFO] [stdout] | [INFO] [stdout] 504 | let header = header_deserialize(header)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 505 | Ok(CacheMeta(Box::new(CacheMetaInner { [INFO] [stdout] | ____________^ [INFO] [stdout] 506 | | internal, [INFO] [stdout] 507 | | header, [INFO] [stdout] 508 | | extensions: Extensions::new(), [INFO] [stdout] 509 | | }))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta.rs:607:5 [INFO] [stdout] | [INFO] [stdout] 606 | pub(crate) fn header_deserialize>(buf: T) -> Result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 607 | HEADER_SERDE.deserialize(buf.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/put.rs:67:27 [INFO] [stdout] | [INFO] [stdout] 56 | cache_put: C, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | trace: trace::Span, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | miss_handler: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/put.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 56 | cache_put: C, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | trace: trace::Span, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | meta: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/put.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 56 | cache_put: C, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | trace: trace::Span, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | parser: ResponseParse::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/put.rs:396:16 [INFO] [stdout] | [INFO] [stdout] 384 | let mut response = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 392 | let header_bytes = self.buf.split_to(split_to).freeze(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | Ok(Some(response)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 20 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pingora-cache` (lib) due to 21 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:921:26 [INFO] [stdout] | [INFO] [stdout] 914 | let result = result.and_then(|(meta, header)| { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 921 | Some((meta, header)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_control.rs:188:14 [INFO] [stdout] | [INFO] [stdout] 166 | let mut directives = IndexMap::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | Some(CacheControl { directives }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eviction/lru.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 146 | item: CompactCacheKey, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | / self.0 [INFO] [stdout] 153 | | .evict_to_limit() [INFO] [stdout] 154 | | .into_iter() [INFO] [stdout] 155 | | .map(|(key, _weight)| key) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eviction/lru.rs:197:17 [INFO] [stdout] | [INFO] [stdout] 195 | let mut file = File::create(&file_path) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | .or_err_with(InternalError, || err_str_path("fail to create", &file_path))?; [INFO] [stdout] 197 | file.write_all(&data).or_err_with(InternalError, || { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eviction/simple_lru.rs:234:13 [INFO] [stdout] | [INFO] [stdout] 231 | let mut file = File::create(&file_path).or_err_with(InternalError, || { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | file.write_all(&data).or_err_with(InternalError, || { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:238:10 [INFO] [stdout] | [INFO] [stdout] 236 | let lock = LockCore::new_arc(timeout); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | let stub = LockStub(lock.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | (WritePermit(lock), stub) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/max_file_size.rs:55:89 [INFO] [stdout] | [INFO] [stdout] 55 | async fn write_body(&mut self, data: Bytes, eof: bool) -> pingora_error::Result<()> { [INFO] [stdout] | ____________________________________-----------__________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | | // fail if writing the body would exceed the max_file_size_bytes [INFO] [stdout] 57 | | if self.bytes_written + data.len() > self.max_file_size_bytes { [INFO] [stdout] 58 | | return Error::e_explain( [INFO] [stdout] ... | [INFO] [stdout] 69 | | self.inner.write_body(data, eof).await [INFO] [stdout] 70 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/max_file_size.rs:72:70 [INFO] [stdout] | [INFO] [stdout] 72 | async fn finish(self: Box) -> pingora_error::Result { [INFO] [stdout] | _____________________----_____________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | | self.inner.finish().await [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:54:19 [INFO] [stdout] | [INFO] [stdout] 51 | let (tx, _rx) = watch::channel(PartialState::Partial(0)); [INFO] [stdout] | -- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | body: Arc::new(RwLock::new(Vec::new())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:55:28 [INFO] [stdout] | [INFO] [stdout] 51 | let (tx, _rx) = watch::channel(PartialState::Partial(0)); [INFO] [stdout] | -- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | bytes_written: Arc::new(tx), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:185:21 [INFO] [stdout] | [INFO] [stdout] 181 | self: Box, // because self is always used as a trait object [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | ) -> Result<()> { [INFO] [stdout] | _____________________^ [INFO] [stdout] 186 | | Ok(()) [INFO] [stdout] 187 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:222:81 [INFO] [stdout] | [INFO] [stdout] 222 | async fn write_body(&mut self, data: bytes::Bytes, eof: bool) -> Result<()> { [INFO] [stdout] | ____________________________________------------------___________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | | let current_bytes = match *self.bytes_written.borrow() { [INFO] [stdout] 224 | | PartialState::Partial(p) => p, [INFO] [stdout] 225 | | PartialState::Complete(_) => panic!("already EOF"), [INFO] [stdout] ... | [INFO] [stdout] 235 | | Ok(()) [INFO] [stdout] 236 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:238:55 [INFO] [stdout] | [INFO] [stdout] 238 | async fn finish(self: Box) -> Result { [INFO] [stdout] | _____________________----______________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | | // safe, the temp object is inserted when the miss handler is created [INFO] [stdout] 240 | | let cache_object = self.temp.read().get(&self.key).unwrap().make_cache_object(); [INFO] [stdout] 241 | | let size = cache_object.body.len(); // FIXME: this just body size, also track meta size [INFO] [stdout] ... | [INFO] [stdout] 244 | | Ok(size) [INFO] [stdout] 245 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/memory.rs:360:19 [INFO] [stdout] | [INFO] [stdout] 354 | let mut header = ResponseHeader::build(200, None).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 360 | CacheMeta(Box::new(crate::meta::CacheMetaInner { [INFO] [stdout] | ___________________^ [INFO] [stdout] 361 | | internal, [INFO] [stdout] 362 | | header, [INFO] [stdout] 363 | | extensions: http::Extensions::new(), [INFO] [stdout] 364 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta.rs:336:19 [INFO] [stdout] | [INFO] [stdout] 334 | header: ResponseHeader, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 335 | ) -> CacheMeta { [INFO] [stdout] 336 | CacheMeta(Box::new(CacheMetaInner { [INFO] [stdout] | ___________________^ [INFO] [stdout] 337 | | internal: InternalMeta { [INFO] [stdout] 338 | | version: InternalMeta::VERSION, [INFO] [stdout] 339 | | fresh_until, [INFO] [stdout] ... | [INFO] [stdout] 347 | | extensions: Extensions::new(), [INFO] [stdout] 348 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta.rs:505:12 [INFO] [stdout] | [INFO] [stdout] 504 | let header = header_deserialize(header)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 505 | Ok(CacheMeta(Box::new(CacheMetaInner { [INFO] [stdout] | ____________^ [INFO] [stdout] 506 | | internal, [INFO] [stdout] 507 | | header, [INFO] [stdout] 508 | | extensions: Extensions::new(), [INFO] [stdout] 509 | | }))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/meta.rs:607:5 [INFO] [stdout] | [INFO] [stdout] 606 | pub(crate) fn header_deserialize>(buf: T) -> Result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 607 | HEADER_SERDE.deserialize(buf.as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/put.rs:67:27 [INFO] [stdout] | [INFO] [stdout] 56 | cache_put: C, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | trace: trace::Span, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | miss_handler: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/put.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 56 | cache_put: C, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | trace: trace::Span, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | meta: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/put.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 56 | cache_put: C, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | trace: trace::Span, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | parser: ResponseParse::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/put.rs:396:16 [INFO] [stdout] | [INFO] [stdout] 384 | let mut response = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 392 | let header_bytes = self.buf.split_to(split_to).freeze(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | Ok(Some(response)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pingora-cache` (lib test) due to 22 previous errors [INFO] running `Command { std: "docker" "inspect" "6beeb237945f9130fa9a106dfd0b5e8717d806d6b648189918f950d475278424", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6beeb237945f9130fa9a106dfd0b5e8717d806d6b648189918f950d475278424", kill_on_drop: false }` [INFO] [stdout] 6beeb237945f9130fa9a106dfd0b5e8717d806d6b648189918f950d475278424