[INFO] fetching crate ping-pong-cell 0.1.2... [INFO] checking ping-pong-cell-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ping-pong-cell 0.1.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate ping-pong-cell 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ping-pong-cell 0.1.2 [INFO] finished tweaking crates.io crate ping-pong-cell 0.1.2 [INFO] tweaked toml for crates.io crate ping-pong-cell 0.1.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 66a7ff9e5e2c87f899d0a00977b8a02d1d23020df1a843047c33a79af3b4c3f4 [INFO] running `Command { std: "docker" "start" "-a" "66a7ff9e5e2c87f899d0a00977b8a02d1d23020df1a843047c33a79af3b4c3f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "66a7ff9e5e2c87f899d0a00977b8a02d1d23020df1a843047c33a79af3b4c3f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66a7ff9e5e2c87f899d0a00977b8a02d1d23020df1a843047c33a79af3b4c3f4", kill_on_drop: false }` [INFO] [stdout] 66a7ff9e5e2c87f899d0a00977b8a02d1d23020df1a843047c33a79af3b4c3f4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 24b9cdd58780e736786227f293ff0c8b55b407cf2f55b4267c31477ec9063bac [INFO] running `Command { std: "docker" "start" "-a" "24b9cdd58780e736786227f293ff0c8b55b407cf2f55b4267c31477ec9063bac", kill_on_drop: false }` [INFO] [stderr] Checking ping-pong-cell v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated function `core::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/lib.rs:4:26 [INFO] [stdout] | [INFO] [stdout] 4 | use core::sync::atomic::{spin_loop_hint, AtomicBool}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `core::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/lib.rs:4:26 [INFO] [stdout] | [INFO] [stdout] 4 | use core::sync::atomic::{spin_loop_hint, AtomicBool}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `core::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/lib.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | spin_loop_hint(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `core::sync::atomic::spin_loop_hint`: use hint::spin_loop instead [INFO] [stdout] --> src/lib.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | spin_loop_hint(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::sync::atomic::AtomicBool::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/lib.rs:54:31 [INFO] [stdout] | [INFO] [stdout] 54 | while self.is_working.compare_and_swap(false, true, Acquire) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(value: Option) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | value: UnsafeCell::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:39:23 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn put_if_empty(&self, value: T) -> Result<(), T> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | self.transact(|state| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 40 | | if state.is_some() { [INFO] [stdout] 41 | | Err(value) [INFO] [stdout] 42 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] 46 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:23 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn put_empty_clone(&self, value: T) -> Result<(), (T, T)> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | self.transact(|state| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 67 | | if let Some(ref old) = state { [INFO] [stdout] 68 | | Err((value, old.clone())) [INFO] [stdout] 69 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] 73 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::sync::atomic::AtomicBool::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/lib.rs:54:31 [INFO] [stdout] | [INFO] [stdout] 54 | while self.is_working.compare_and_swap(false, true, Acquire) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:85:23 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn compare_and_swap(&self, expected: &T, new: T) -> Result<(), T> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | self.transact(|state| match state { [INFO] [stdout] | _______________________^ [INFO] [stdout] 86 | | Some(ref mut val) if val == expected => { [INFO] [stdout] 87 | | *val = new; [INFO] [stdout] 88 | | Ok(()) [INFO] [stdout] 89 | | } [INFO] [stdout] 90 | | _ => Err(new), [INFO] [stdout] 91 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:98:23 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn compare_swap_clone(&self, expected: &T, new: T) -> Result<(), (T, Option)> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | self.transact(|state| match state { [INFO] [stdout] | _______________________^ [INFO] [stdout] 99 | | Some(val) if val == expected => { [INFO] [stdout] 100 | | *state = Some(new); [INFO] [stdout] 101 | | Ok(()) [INFO] [stdout] ... | [INFO] [stdout] 104 | | None => Err((new, None)), [INFO] [stdout] 105 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ping-pong-cell` (lib test) due to 6 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(value: Option) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | value: UnsafeCell::new(value), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:39:23 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn put_if_empty(&self, value: T) -> Result<(), T> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | self.transact(|state| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 40 | | if state.is_some() { [INFO] [stdout] 41 | | Err(value) [INFO] [stdout] 42 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] 46 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:23 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn put_empty_clone(&self, value: T) -> Result<(), (T, T)> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | self.transact(|state| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 67 | | if let Some(ref old) = state { [INFO] [stdout] 68 | | Err((value, old.clone())) [INFO] [stdout] 69 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] 73 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:85:23 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn compare_and_swap(&self, expected: &T, new: T) -> Result<(), T> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | self.transact(|state| match state { [INFO] [stdout] | _______________________^ [INFO] [stdout] 86 | | Some(ref mut val) if val == expected => { [INFO] [stdout] 87 | | *val = new; [INFO] [stdout] 88 | | Ok(()) [INFO] [stdout] 89 | | } [INFO] [stdout] 90 | | _ => Err(new), [INFO] [stdout] 91 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:98:23 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn compare_swap_clone(&self, expected: &T, new: T) -> Result<(), (T, Option)> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | self.transact(|state| match state { [INFO] [stdout] | _______________________^ [INFO] [stdout] 99 | | Some(val) if val == expected => { [INFO] [stdout] 100 | | *state = Some(new); [INFO] [stdout] 101 | | Ok(()) [INFO] [stdout] ... | [INFO] [stdout] 104 | | None => Err((new, None)), [INFO] [stdout] 105 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ping-pong-cell` (lib) due to 6 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "24b9cdd58780e736786227f293ff0c8b55b407cf2f55b4267c31477ec9063bac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24b9cdd58780e736786227f293ff0c8b55b407cf2f55b4267c31477ec9063bac", kill_on_drop: false }` [INFO] [stdout] 24b9cdd58780e736786227f293ff0c8b55b407cf2f55b4267c31477ec9063bac