[INFO] fetching crate piholectl 0.2.0... [INFO] checking piholectl-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate piholectl 0.2.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate piholectl 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate piholectl 0.2.0 [INFO] finished tweaking crates.io crate piholectl 0.2.0 [INFO] tweaked toml for crates.io crate piholectl 0.2.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate piholectl 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] efc9bd965706f4850de28c731588d7a897ba409b3d5fa9df1baf3f8e20cde2d7 [INFO] running `Command { std: "docker" "start" "-a" "efc9bd965706f4850de28c731588d7a897ba409b3d5fa9df1baf3f8e20cde2d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "efc9bd965706f4850de28c731588d7a897ba409b3d5fa9df1baf3f8e20cde2d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "efc9bd965706f4850de28c731588d7a897ba409b3d5fa9df1baf3f8e20cde2d7", kill_on_drop: false }` [INFO] [stdout] efc9bd965706f4850de28c731588d7a897ba409b3d5fa9df1baf3f8e20cde2d7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9b21e397c6707cf0cb6f58636080ebe0cd1683e56b348e485e518dec6638dcd9 [INFO] running `Command { std: "docker" "start" "-a" "9b21e397c6707cf0cb6f58636080ebe0cd1683e56b348e485e518dec6638dcd9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling libc v0.2.127 [INFO] [stderr] Compiling serde_derive v1.0.142 [INFO] [stderr] Compiling serde v1.0.142 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling rustversion v1.0.9 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling serde_json v1.0.83 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Compiling rustls v0.20.6 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking chunked_transfer v1.4.0 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking os_str_bytes v6.3.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking unsafe-libyaml v0.2.2 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking directories v4.0.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking unicode-normalization v0.1.21 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking webpki-roots v0.22.4 [INFO] [stderr] Compiling strum_macros v0.24.2 [INFO] [stderr] Compiling serde_tuple_macros v0.5.0 [INFO] [stderr] Compiling clap_derive v3.2.17 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Compiling cli-table-derive v0.4.5 [INFO] [stderr] Compiling serde_repr v0.1.9 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking clap v3.2.17 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking serde_tuple v0.5.0 [INFO] [stderr] Checking chrono v0.4.20 [INFO] [stderr] Checking serde_yaml v0.9.9 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking ureq v2.5.0 [INFO] [stderr] Checking cli-table v0.4.7 [INFO] [stderr] Checking pi-hole-api v0.3.3 [INFO] [stderr] Checking piholectl v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `to_table` is never used [INFO] [stdout] --> src/table.rs:522:8 [INFO] [stdout] | [INFO] [stdout] 521 | pub trait ToTable { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 522 | fn to_table(self) -> TableStruct; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 17 | .map(|(host, result)| { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | result.map_err(|e| format!("{:?}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 117 | let domains_over_time = self [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | let ads_over_time = self.ads_over_time.into_iter().map(|(time, count)| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | domains_over_time.chain(ads_over_time).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:257:9 [INFO] [stdout] | [INFO] [stdout] 240 | let top_queries = self.top_queries.into_iter().map(|(domain, count)| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | let top_ads = self.top_ads.into_iter().map(|(domain, count)| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | top_queries.chain(top_ads).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 291 | fn to_table_rows(self, host: &str) -> Vec> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 292 | / self.into_iter() [INFO] [stdout] 293 | | .flat_map(|item| item.to_table_rows(host)) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `piholectl` (bin "piholectl" test) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `to_table` is never used [INFO] [stdout] --> src/table.rs:522:8 [INFO] [stdout] | [INFO] [stdout] 521 | pub trait ToTable { [INFO] [stdout] | ------- method in this trait [INFO] [stdout] 522 | fn to_table(self) -> TableStruct; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 17 | .map(|(host, result)| { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | result.map_err(|e| format!("{:?}", e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 117 | let domains_over_time = self [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | let ads_over_time = self.ads_over_time.into_iter().map(|(time, count)| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | domains_over_time.chain(ads_over_time).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:257:9 [INFO] [stdout] | [INFO] [stdout] 240 | let top_queries = self.top_queries.into_iter().map(|(domain, count)| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | let top_ads = self.top_ads.into_iter().map(|(domain, count)| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | top_queries.chain(top_ads).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 291 | fn to_table_rows(self, host: &str) -> Vec> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 292 | / self.into_iter() [INFO] [stdout] 293 | | .flat_map(|item| item.to_table_rows(host)) [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `piholectl` (bin "piholectl") due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "9b21e397c6707cf0cb6f58636080ebe0cd1683e56b348e485e518dec6638dcd9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b21e397c6707cf0cb6f58636080ebe0cd1683e56b348e485e518dec6638dcd9", kill_on_drop: false }` [INFO] [stdout] 9b21e397c6707cf0cb6f58636080ebe0cd1683e56b348e485e518dec6638dcd9