[INFO] fetching crate picturs 0.0.0... [INFO] checking picturs-0.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate picturs 0.0.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate picturs 0.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate picturs 0.0.0 [INFO] finished tweaking crates.io crate picturs 0.0.0 [INFO] tweaked toml for crates.io crate picturs 0.0.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate picturs 0.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 601ce1236bfe009c69546b73735dfa6ccd3fa21795b2b14e383a26a30b30696f [INFO] running `Command { std: "docker" "start" "-a" "601ce1236bfe009c69546b73735dfa6ccd3fa21795b2b14e383a26a30b30696f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "601ce1236bfe009c69546b73735dfa6ccd3fa21795b2b14e383a26a30b30696f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "601ce1236bfe009c69546b73735dfa6ccd3fa21795b2b14e383a26a30b30696f", kill_on_drop: false }` [INFO] [stdout] 601ce1236bfe009c69546b73735dfa6ccd3fa21795b2b14e383a26a30b30696f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a8c6ce2778054859f6f57b76885e3d385caf773c2ade59109de6d706cb465ea9 [INFO] running `Command { std: "docker" "start" "-a" "a8c6ce2778054859f6f57b76885e3d385caf773c2ade59109de6d706cb465ea9", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libc v0.2.70 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking bytemuck v1.2.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking miniz_oxide v0.3.6 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Compiling num-iter v0.1.40 [INFO] [stderr] Checking deflate v0.8.4 [INFO] [stderr] Checking tiff v0.4.0 [INFO] [stderr] Checking png v0.16.3 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking icns v0.3.1 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking jpeg-decoder v0.1.19 [INFO] [stderr] Checking image v0.23.4 [INFO] [stderr] Checking picturs v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::fs` [INFO] [stdout] --> src/cli/cli.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::fs; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `pictursError` should have an upper camel case name [INFO] [stdout] --> src/error/error.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct pictursError { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `PictursError` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IconType` [INFO] [stdout] --> src/img/encode.rs:4:24 [INFO] [stdout] | [INFO] [stdout] 4 | use icns::{IconFamily, IconType, Image}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/img/encode.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `dimensions::*` [INFO] [stdout] --> src/img/mod.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use dimensions::*; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs` [INFO] [stdout] --> src/cli/cli.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::fs; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `pictursError` should have an upper camel case name [INFO] [stdout] --> src/error/error.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct pictursError { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to upper camel case: `PictursError` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `IconType` [INFO] [stdout] --> src/img/encode.rs:4:24 [INFO] [stdout] | [INFO] [stdout] 4 | use icns::{IconFamily, IconType, Image}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::error::Error` [INFO] [stdout] --> src/img/encode.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::error::Error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `dimensions::*` [INFO] [stdout] --> src/img/mod.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub use dimensions::*; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `message` is never read [INFO] [stdout] --> src/error/error.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct pictursError { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 4 | pub message: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `pictursError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Dimensions` is never constructed [INFO] [stdout] --> src/img/dimensions.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Dimensions { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/img/dimensions.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 8 | impl Dimensions { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] 9 | pub fn new(width: u32, height: u32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/img/encode.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 47 | let file = File::create(format!("{}/icon.ico", file_dirname)).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | match encoder.encode( [INFO] [stdout] | _________^ [INFO] [stdout] 52 | | &img.to_bytes(), [INFO] [stdout] 53 | | img.dimensions().0, [INFO] [stdout] 54 | | img.dimensions().1, [INFO] [stdout] 55 | | img.color(), [INFO] [stdout] 56 | | ) { [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/img/encode.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 74 | let file = File::create(format!("{}/icon.png", file_dirname)).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | match encoder.encode( [INFO] [stdout] | _________^ [INFO] [stdout] 79 | | &img.to_bytes(), [INFO] [stdout] 80 | | img.dimensions().0, [INFO] [stdout] 81 | | img.dimensions().1, [INFO] [stdout] 82 | | img.color(), [INFO] [stdout] 83 | | ) { [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/img/encode.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 93 | let file = BufReader::new(File::open(input_file_path.clone()).unwrap()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let image = Image::read_png(file).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let out = BufWriter::new(File::create(format!("{}/icon.icns", file_dirname)).unwrap()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | match icon_family.write(out) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `picturs` (bin "picturs" test) due to 4 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `message` is never read [INFO] [stdout] --> src/error/error.rs:4:7 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct pictursError { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 4 | pub message: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `pictursError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Dimensions` is never constructed [INFO] [stdout] --> src/img/dimensions.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Dimensions { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/img/dimensions.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 8 | impl Dimensions { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] 9 | pub fn new(width: u32, height: u32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/img/encode.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 47 | let file = File::create(format!("{}/icon.ico", file_dirname)).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | match encoder.encode( [INFO] [stdout] | _________^ [INFO] [stdout] 52 | | &img.to_bytes(), [INFO] [stdout] 53 | | img.dimensions().0, [INFO] [stdout] 54 | | img.dimensions().1, [INFO] [stdout] 55 | | img.color(), [INFO] [stdout] 56 | | ) { [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/img/encode.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 74 | let file = File::create(format!("{}/icon.png", file_dirname)).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | match encoder.encode( [INFO] [stdout] | _________^ [INFO] [stdout] 79 | | &img.to_bytes(), [INFO] [stdout] 80 | | img.dimensions().0, [INFO] [stdout] 81 | | img.dimensions().1, [INFO] [stdout] 82 | | img.color(), [INFO] [stdout] 83 | | ) { [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/img/encode.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 93 | let file = BufReader::new(File::open(input_file_path.clone()).unwrap()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let image = Image::read_png(file).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let out = BufWriter::new(File::create(format!("{}/icon.icns", file_dirname)).unwrap()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | match icon_family.write(out) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `picturs` (bin "picturs") due to 4 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a8c6ce2778054859f6f57b76885e3d385caf773c2ade59109de6d706cb465ea9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8c6ce2778054859f6f57b76885e3d385caf773c2ade59109de6d706cb465ea9", kill_on_drop: false }` [INFO] [stdout] a8c6ce2778054859f6f57b76885e3d385caf773c2ade59109de6d706cb465ea9