[INFO] fetching crate pico-enumeration 0.3.1... [INFO] checking pico-enumeration-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pico-enumeration 0.3.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate pico-enumeration 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pico-enumeration 0.3.1 [INFO] finished tweaking crates.io crate pico-enumeration 0.3.1 [INFO] tweaked toml for crates.io crate pico-enumeration 0.3.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 59 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding core-foundation v0.6.4 (latest: v0.10.0) [INFO] [stderr] Adding core-foundation-sys v0.6.2 (latest: v0.8.7) [INFO] [stderr] Adding enum-iterator v0.6.0 (latest: v2.1.0) [INFO] [stderr] Adding enum-iterator-derive v0.6.0 (latest: v1.4.0) [INFO] [stderr] Adding io-kit-sys v0.1.0 (latest: v0.4.1) [INFO] [stderr] Adding libloading v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding mach v0.2.3 (latest: v0.3.2) [INFO] [stderr] Adding num-derive v0.3.3 (latest: v0.4.2) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding udev v0.5.0 (latest: v0.9.0) [INFO] [stderr] Adding usb_enumeration v0.1.2 (latest: v0.2.0) [INFO] [stderr] Adding version-compare v0.0.11 (latest: v0.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6af25a5e2fe84a5bf7c9a5f06fb80a5e436266a22efeaca76d0cd3b4b56b37ce [INFO] running `Command { std: "docker" "start" "-a" "6af25a5e2fe84a5bf7c9a5f06fb80a5e436266a22efeaca76d0cd3b4b56b37ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6af25a5e2fe84a5bf7c9a5f06fb80a5e436266a22efeaca76d0cd3b4b56b37ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6af25a5e2fe84a5bf7c9a5f06fb80a5e436266a22efeaca76d0cd3b4b56b37ce", kill_on_drop: false }` [INFO] [stdout] 6af25a5e2fe84a5bf7c9a5f06fb80a5e436266a22efeaca76d0cd3b4b56b37ce [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a632fc570b82d386d959ad4deb956ad426830dfbcb44539c416ac73dc9ae3c48 [INFO] running `Command { std: "docker" "start" "-a" "a632fc570b82d386d959ad4deb956ad426830dfbcb44539c416ac73dc9ae3c48", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking version-compare v0.0.11 [INFO] [stderr] Checking c_vec v2.0.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking pico-sys-dynamic v0.3.1 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking parking_lot_core v0.8.6 [INFO] [stderr] Checking udev v0.5.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking usb_enumeration v0.1.2 [INFO] [stderr] Compiling enum-iterator-derive v0.6.0 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking enum-iterator v0.6.0 [INFO] [stderr] Checking pico-common v0.3.1 [INFO] [stderr] Checking pico-driver v0.3.1 [INFO] [stderr] Checking pico-device v0.3.1 [INFO] [stderr] Checking pico-enumeration v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:183:37 [INFO] [stdout] | [INFO] [stdout] 183 | .map(|r| Ok(EnumeratedDevice::new(driver.clone(), r.variant, r.serial))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 25 | fn devices_and_errors(self) -> (Vec, Vec) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let (devices, errors): (Vec<_>, Vec<_>) = self.into_iter().partition(|e| e.is_ok()); [INFO] [stdout] | ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | devices.into_iter().map(|r| r.unwrap()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 25 | fn devices_and_errors(self) -> (Vec, Vec) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let (devices, errors): (Vec<_>, Vec<_>) = self.into_iter().partition(|e| e.is_ok()); [INFO] [stdout] | ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | errors.into_iter().map(|r| r.unwrap_err()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pico-enumeration` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:183:37 [INFO] [stdout] | [INFO] [stdout] 183 | .map(|r| Ok(EnumeratedDevice::new(driver.clone(), r.variant, r.serial))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 25 | fn devices_and_errors(self) -> (Vec, Vec) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let (devices, errors): (Vec<_>, Vec<_>) = self.into_iter().partition(|e| e.is_ok()); [INFO] [stdout] | ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | devices.into_iter().map(|r| r.unwrap()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 25 | fn devices_and_errors(self) -> (Vec, Vec) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let (devices, errors): (Vec<_>, Vec<_>) = self.into_iter().partition(|e| e.is_ok()); [INFO] [stdout] | ------- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | errors.into_iter().map(|r| r.unwrap_err()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pico-enumeration` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "a632fc570b82d386d959ad4deb956ad426830dfbcb44539c416ac73dc9ae3c48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a632fc570b82d386d959ad4deb956ad426830dfbcb44539c416ac73dc9ae3c48", kill_on_drop: false }` [INFO] [stdout] a632fc570b82d386d959ad4deb956ad426830dfbcb44539c416ac73dc9ae3c48