[INFO] fetching crate picky-krb 0.9.0... [INFO] checking picky-krb-0.9.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate picky-krb 0.9.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate picky-krb 0.9.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate picky-krb 0.9.0 [INFO] finished tweaking crates.io crate picky-krb 0.9.0 [INFO] tweaked toml for crates.io crate picky-krb 0.9.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 54 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] afd51d7b8c1970125912adfc30ceb9715a419b1f3be7f4c1b0939c75b31029b7 [INFO] running `Command { std: "docker" "start" "-a" "afd51d7b8c1970125912adfc30ceb9715a419b1f3be7f4c1b0939c75b31029b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "afd51d7b8c1970125912adfc30ceb9715a419b1f3be7f4c1b0939c75b31029b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "afd51d7b8c1970125912adfc30ceb9715a419b1f3be7f4c1b0939c75b31029b7", kill_on_drop: false }` [INFO] [stdout] afd51d7b8c1970125912adfc30ceb9715a419b1f3be7f4c1b0939c75b31029b7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f5ea39353549d65ca0364636ae239f911a8473c574ef9b6ae45d3f68490affa2 [INFO] running `Command { std: "docker" "start" "-a" "f5ea39353549d65ca0364636ae239f911a8473c574ef9b6ae45d3f68490affa2", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking crypto v0.5.1 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking des v0.8.1 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking oid v0.2.1 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking picky-asn1 v0.9.0 [INFO] [stderr] Checking picky-asn1-der v0.5.0 [INFO] [stderr] Checking picky-asn1-x509 v0.13.0 [INFO] [stderr] Checking picky-krb v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/diffie_hellman.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 101 | let public_key = BigUint::from_bytes_be(public_key); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let private_key = BigUint::from_bytes_be(private_key); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let p = BigUint::from_bytes_be(p); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | public_key.modpow(&private_key, &p).to_bytes_be() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/diffie_hellman.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 125 | let q = BigUint::from_bytes_be(q); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | [INFO] [stdout] 127 | rng.gen_range(BigUint::from_bytes_be(&[2])..(q - 1_u32)).to_bytes_be() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/diffie_hellman.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 133 | let x = BigUint::from_bytes_be(private_key); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | let g = BigUint::from_bytes_be(base); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | let p = BigUint::from_bytes_be(modulus); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | [INFO] [stdout] 137 | g.modpow(&x, &p).to_bytes_be() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_types.rs:403:23 [INFO] [stdout] | [INFO] [stdout] 399 | fn visit_seq(self, mut seq: A) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 403 | match seq.next_element() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `picky-krb` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/diffie_hellman.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 101 | let public_key = BigUint::from_bytes_be(public_key); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let private_key = BigUint::from_bytes_be(private_key); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let p = BigUint::from_bytes_be(p); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | public_key.modpow(&private_key, &p).to_bytes_be() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/diffie_hellman.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 125 | let q = BigUint::from_bytes_be(q); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | [INFO] [stdout] 127 | rng.gen_range(BigUint::from_bytes_be(&[2])..(q - 1_u32)).to_bytes_be() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/diffie_hellman.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 133 | let x = BigUint::from_bytes_be(private_key); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | let g = BigUint::from_bytes_be(base); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | let p = BigUint::from_bytes_be(modulus); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | [INFO] [stdout] 137 | g.modpow(&x, &p).to_bytes_be() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_types.rs:403:23 [INFO] [stdout] | [INFO] [stdout] 399 | fn visit_seq(self, mut seq: A) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 403 | match seq.next_element() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `picky-krb` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "f5ea39353549d65ca0364636ae239f911a8473c574ef9b6ae45d3f68490affa2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5ea39353549d65ca0364636ae239f911a8473c574ef9b6ae45d3f68490affa2", kill_on_drop: false }` [INFO] [stdout] f5ea39353549d65ca0364636ae239f911a8473c574ef9b6ae45d3f68490affa2