[INFO] fetching crate piccolo-util 0.3.3... [INFO] checking piccolo-util-0.3.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate piccolo-util 0.3.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate piccolo-util 0.3.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate piccolo-util 0.3.3 [INFO] finished tweaking crates.io crate piccolo-util 0.3.3 [INFO] tweaked toml for crates.io crate piccolo-util 0.3.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 31 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8f65a1f9ad9d822d52ff37a82cc4678a297b4d9fddf66d1ff80514fd2ad84c54 [INFO] running `Command { std: "docker" "start" "-a" "8f65a1f9ad9d822d52ff37a82cc4678a297b4d9fddf66d1ff80514fd2ad84c54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8f65a1f9ad9d822d52ff37a82cc4678a297b4d9fddf66d1ff80514fd2ad84c54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f65a1f9ad9d822d52ff37a82cc4678a297b4d9fddf66d1ff80514fd2ad84c54", kill_on_drop: false }` [INFO] [stdout] 8f65a1f9ad9d822d52ff37a82cc4678a297b4d9fddf66d1ff80514fd2ad84c54 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7f6838327ce549905f095a4d82af630c9655b493da299e8dc0536efdb5b58ae1 [INFO] running `Command { std: "docker" "start" "-a" "7f6838327ce549905f095a4d82af630c9655b493da299e8dc0536efdb5b58ae1", kill_on_drop: false }` [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking sptr v0.3.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling gc-arena-derive v0.5.3 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking gc-arena v0.5.3 [INFO] [stderr] Checking piccolo v0.3.3 [INFO] [stderr] Checking piccolo-util v0.3.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn in_scope<'f, R>(value: >::Frozen, cb: impl FnOnce(Self) -> R) -> R { [INFO] [stdout] | -------------------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let f = Self::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let p = f.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | FrozenScope::new().freeze(&f, value).scope(move || cb(p)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:75:52 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn in_scope<'f, R>(value: >::Frozen, cb: impl FnOnce(Self) -> R) -> R { [INFO] [stdout] | -------------------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let f = Self::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let p = f.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | FrozenScope::new().freeze(&f, value).scope(move || cb(p)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 89 | f: impl for<'f> FnOnce(&>::Frozen) -> R, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | ) -> Result { [INFO] [stdout] 91 | Ok(f(self [INFO] [stdout] | ____________^ [INFO] [stdout] 92 | | .inner [INFO] [stdout] 93 | | .try_borrow() [INFO] [stdout] 94 | | .map_err(|_| AccessError::BadBorrow)? [INFO] [stdout] 95 | | .as_ref() [INFO] [stdout] 96 | | .ok_or(AccessError::Expired)?)) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn with(&self, f: impl for<'f> FnOnce(&>::Frozen) -> R) -> R { [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | self.try_with(f).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 108 | f: impl for<'f> FnOnce(&mut >::Frozen) -> R, [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | ) -> Result { [INFO] [stdout] 110 | Ok(f(self [INFO] [stdout] | ____________^ [INFO] [stdout] 111 | | .inner [INFO] [stdout] 112 | | .try_borrow_mut() [INFO] [stdout] 113 | | .map_err(|_| AccessError::BadBorrow)? [INFO] [stdout] 114 | | .as_mut() [INFO] [stdout] 115 | | .ok_or(AccessError::Expired)?)) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn with_mut(&self, f: impl for<'f> FnOnce(&mut >::Frozen) -> R) -> R { [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | self.try_with_mut(f).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:148:21 [INFO] [stdout] | [INFO] [stdout] 144 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | handle: &'h Frozen, [INFO] [stdout] 146 | value: >::Frozen, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | ) -> FrozenScope<(FreezeGuard<'h, 'f, F>, D)> { [INFO] [stdout] 148 | FrozenScope(( [INFO] [stdout] | _____________________^ [INFO] [stdout] 149 | | FreezeGuard { [INFO] [stdout] 150 | | value: Some(value), [INFO] [stdout] 151 | | handle, [INFO] [stdout] 152 | | }, [INFO] [stdout] 153 | | self.0, [INFO] [stdout] 154 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/user_methods.rs:45:16 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn add(self, name: &'static str, ctx: Context<'gc>, method: F) -> bool [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let args: A = stack.consume(ctx)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let this = userdata.downcast::()?; [INFO] [stdout] 43 | let ret = method(&this, ctx, exec, args)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | stack.replace(ctx, ret); [INFO] [stdout] 45 | Ok(CallbackReturn::Return) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/user_methods.rs:69:16 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn add_write(self, name: &'static str, ctx: Context<'gc>, method: F) -> bool [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let args: A = stack.consume(ctx)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let mut this = userdata.downcast_write::(&ctx)?; [INFO] [stdout] 67 | let ret = method(&mut this, ctx, exec, args)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | stack.replace(ctx, ret); [INFO] [stdout] 69 | Ok(CallbackReturn::Return) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/user_methods.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn add(self, name: &'static str, ctx: Context<'gc>, method: F) -> bool [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | let args: A = stack.consume(ctx)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let this = userdata.downcast_static::()?; [INFO] [stdout] 127 | let ret = method(&this, ctx, exec, args)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | stack.replace(ctx, ret); [INFO] [stdout] 129 | Ok(CallbackReturn::Return) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde/de.rs:474:12 [INFO] [stdout] | [INFO] [stdout] 470 | fn variant_seed(self, seed: V) -> Result<(V::Value, Variant<'gc>), Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 474 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 475 | | seed.deserialize(Deserializer::from_value(self.key))?, [INFO] [stdout] 476 | | Variant::new(self.value), [INFO] [stdout] 477 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde/de.rs:542:12 [INFO] [stdout] | [INFO] [stdout] 538 | fn variant_seed(self, seed: V) -> Result<(V::Value, UnitVariant), Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 542 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 543 | | seed.deserialize(Deserializer::from_value(self.key))?, [INFO] [stdout] 544 | | UnitVariant::new(), [INFO] [stdout] 545 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `piccolo-util` (lib) due to 13 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn in_scope<'f, R>(value: >::Frozen, cb: impl FnOnce(Self) -> R) -> R { [INFO] [stdout] | -------------------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let f = Self::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let p = f.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | FrozenScope::new().freeze(&f, value).scope(move || cb(p)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:75:52 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn in_scope<'f, R>(value: >::Frozen, cb: impl FnOnce(Self) -> R) -> R { [INFO] [stdout] | -------------------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let f = Self::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let p = f.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | FrozenScope::new().freeze(&f, value).scope(move || cb(p)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 89 | f: impl for<'f> FnOnce(&>::Frozen) -> R, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | ) -> Result { [INFO] [stdout] 91 | Ok(f(self [INFO] [stdout] | ____________^ [INFO] [stdout] 92 | | .inner [INFO] [stdout] 93 | | .try_borrow() [INFO] [stdout] 94 | | .map_err(|_| AccessError::BadBorrow)? [INFO] [stdout] 95 | | .as_ref() [INFO] [stdout] 96 | | .ok_or(AccessError::Expired)?)) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn with(&self, f: impl for<'f> FnOnce(&>::Frozen) -> R) -> R { [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | self.try_with(f).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 108 | f: impl for<'f> FnOnce(&mut >::Frozen) -> R, [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | ) -> Result { [INFO] [stdout] 110 | Ok(f(self [INFO] [stdout] | ____________^ [INFO] [stdout] 111 | | .inner [INFO] [stdout] 112 | | .try_borrow_mut() [INFO] [stdout] 113 | | .map_err(|_| AccessError::BadBorrow)? [INFO] [stdout] 114 | | .as_mut() [INFO] [stdout] 115 | | .ok_or(AccessError::Expired)?)) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn with_mut(&self, f: impl for<'f> FnOnce(&mut >::Frozen) -> R) -> R { [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | self.try_with_mut(f).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:148:21 [INFO] [stdout] | [INFO] [stdout] 144 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | handle: &'h Frozen, [INFO] [stdout] 146 | value: >::Frozen, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | ) -> FrozenScope<(FreezeGuard<'h, 'f, F>, D)> { [INFO] [stdout] 148 | FrozenScope(( [INFO] [stdout] | _____________________^ [INFO] [stdout] 149 | | FreezeGuard { [INFO] [stdout] 150 | | value: Some(value), [INFO] [stdout] 151 | | handle, [INFO] [stdout] 152 | | }, [INFO] [stdout] 153 | | self.0, [INFO] [stdout] 154 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/user_methods.rs:45:16 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn add(self, name: &'static str, ctx: Context<'gc>, method: F) -> bool [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let args: A = stack.consume(ctx)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let this = userdata.downcast::()?; [INFO] [stdout] 43 | let ret = method(&this, ctx, exec, args)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | stack.replace(ctx, ret); [INFO] [stdout] 45 | Ok(CallbackReturn::Return) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/user_methods.rs:69:16 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn add_write(self, name: &'static str, ctx: Context<'gc>, method: F) -> bool [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let args: A = stack.consume(ctx)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let mut this = userdata.downcast_write::(&ctx)?; [INFO] [stdout] 67 | let ret = method(&mut this, ctx, exec, args)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | stack.replace(ctx, ret); [INFO] [stdout] 69 | Ok(CallbackReturn::Return) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/user_methods.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn add(self, name: &'static str, ctx: Context<'gc>, method: F) -> bool [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | let args: A = stack.consume(ctx)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let this = userdata.downcast_static::()?; [INFO] [stdout] 127 | let ret = method(&this, ctx, exec, args)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | stack.replace(ctx, ret); [INFO] [stdout] 129 | Ok(CallbackReturn::Return) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde/de.rs:474:12 [INFO] [stdout] | [INFO] [stdout] 470 | fn variant_seed(self, seed: V) -> Result<(V::Value, Variant<'gc>), Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 474 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 475 | | seed.deserialize(Deserializer::from_value(self.key))?, [INFO] [stdout] 476 | | Variant::new(self.value), [INFO] [stdout] 477 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde/de.rs:542:12 [INFO] [stdout] | [INFO] [stdout] 538 | fn variant_seed(self, seed: V) -> Result<(V::Value, UnitVariant), Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 542 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 543 | | seed.deserialize(Deserializer::from_value(self.key))?, [INFO] [stdout] 544 | | UnitVariant::new(), [INFO] [stdout] 545 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `piccolo-util` (lib test) due to 13 previous errors [INFO] running `Command { std: "docker" "inspect" "7f6838327ce549905f095a4d82af630c9655b493da299e8dc0536efdb5b58ae1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f6838327ce549905f095a4d82af630c9655b493da299e8dc0536efdb5b58ae1", kill_on_drop: false }` [INFO] [stdout] 7f6838327ce549905f095a4d82af630c9655b493da299e8dc0536efdb5b58ae1