[INFO] fetching crate picard-core 0.0.1... [INFO] checking picard-core-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate picard-core 0.0.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate picard-core 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate picard-core 0.0.1 [INFO] finished tweaking crates.io crate picard-core 0.0.1 [INFO] tweaked toml for crates.io crate picard-core 0.0.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 8 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a5ba834131870c52743eff192c8a6859829f53b1c807250896baf64a4295b2b3 [INFO] running `Command { std: "docker" "start" "-a" "a5ba834131870c52743eff192c8a6859829f53b1c807250896baf64a4295b2b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a5ba834131870c52743eff192c8a6859829f53b1c807250896baf64a4295b2b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5ba834131870c52743eff192c8a6859829f53b1c807250896baf64a4295b2b3", kill_on_drop: false }` [INFO] [stdout] a5ba834131870c52743eff192c8a6859829f53b1c807250896baf64a4295b2b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] db342a6522cbf79bf3fbb083792a47770b5a346edcecb6b6bbe9bc2285ad80a1 [INFO] running `Command { std: "docker" "start" "-a" "db342a6522cbf79bf3fbb083792a47770b5a346edcecb6b6bbe9bc2285ad80a1", kill_on_drop: false }` [INFO] [stderr] Checking picard-core v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `buffer::ShaderBuffer` [INFO] [stdout] --> src/lib.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use buffer::ShaderBuffer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `buffer::ShaderBuffer` [INFO] [stdout] --> src/lib.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use buffer::ShaderBuffer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pos` [INFO] [stdout] --> src/buffer.rs:102:35 [INFO] [stdout] | [INFO] [stdout] 102 | pub(crate) fn seek(&mut self, pos: u64, mode: io::SeekFrom) -> Result { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_pos` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MAX_OPDESC` is never used [INFO] [stdout] --> src/lib.rs:14:7 [INFO] [stdout] | [INFO] [stdout] 14 | const MAX_OPDESC: usize = 128; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `little_endian` is never read [INFO] [stdout] --> src/buffer.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct ShaderBuffer { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 5 | buf: Cursor>, [INFO] [stdout] 6 | little_endian: bool [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple methods are never used [INFO] [stdout] --> src/buffer.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 9 | impl ShaderBuffer { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 18 | pub(crate) fn set_little_endian(&mut self, little: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | pub(crate) fn read_u64(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | pub(crate) fn write_u64(&mut self, value: u64) -> Result<(), io::Error> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | pub(crate) fn read_u32(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 46 | pub(crate) fn write_u32(&mut self, value: u32) -> Result<(), io::Error> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | pub(crate) fn read_u16(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 62 | pub(crate) fn write_u16(&mut self, value: u16) -> Result<(), io::Error> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 70 | pub(crate) fn read_u8(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 74 | pub(crate) fn write_u8(&mut self, value: u8) -> Result<(), io::Error> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 78 | pub(crate) fn read_f32(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 86 | pub(crate) fn write_f32(&mut self, value: f32) -> Result<(), io::Error> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub(crate) fn read_raw(&mut self, buffer: &mut [u8]) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 98 | pub(crate) fn write_raw(&mut self, buffer: &[u8]) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 102 | pub(crate) fn seek(&mut self, pos: u64, mode: io::SeekFrom) -> Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 106 | pub(crate) fn tell(&mut self) -> u64 { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bit` is never used [INFO] [stdout] --> src/utils.rs:2:8 [INFO] [stdout] | [INFO] [stdout] 2 | pub fn bit(n: T) -> T where T: std::ops::Shl + From { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub fn bit(n: T) -> T where T: std::ops::Shl + From { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 3 | T::from(1_u8) << n [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pos` [INFO] [stdout] --> src/buffer.rs:102:35 [INFO] [stdout] | [INFO] [stdout] 102 | pub(crate) fn seek(&mut self, pos: u64, mode: io::SeekFrom) -> Result { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_pos` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MAX_OPDESC` is never used [INFO] [stdout] --> src/lib.rs:14:7 [INFO] [stdout] | [INFO] [stdout] 14 | const MAX_OPDESC: usize = 128; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `picard-core` (lib test) due to 2 previous errors; 6 warnings emitted [INFO] [stdout] warning: field `little_endian` is never read [INFO] [stdout] --> src/buffer.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct ShaderBuffer { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 5 | buf: Cursor>, [INFO] [stdout] 6 | little_endian: bool [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: multiple methods are never used [INFO] [stdout] --> src/buffer.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 9 | impl ShaderBuffer { [INFO] [stdout] | ----------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 18 | pub(crate) fn set_little_endian(&mut self, little: bool) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | pub(crate) fn read_u64(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 30 | pub(crate) fn write_u64(&mut self, value: u64) -> Result<(), io::Error> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | pub(crate) fn read_u32(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 46 | pub(crate) fn write_u32(&mut self, value: u32) -> Result<(), io::Error> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | pub(crate) fn read_u16(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 62 | pub(crate) fn write_u16(&mut self, value: u16) -> Result<(), io::Error> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 70 | pub(crate) fn read_u8(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 74 | pub(crate) fn write_u8(&mut self, value: u8) -> Result<(), io::Error> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 78 | pub(crate) fn read_f32(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 86 | pub(crate) fn write_f32(&mut self, value: f32) -> Result<(), io::Error> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub(crate) fn read_raw(&mut self, buffer: &mut [u8]) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 98 | pub(crate) fn write_raw(&mut self, buffer: &[u8]) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 102 | pub(crate) fn seek(&mut self, pos: u64, mode: io::SeekFrom) -> Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 106 | pub(crate) fn tell(&mut self) -> u64 { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bit` is never used [INFO] [stdout] --> src/utils.rs:2:8 [INFO] [stdout] | [INFO] [stdout] 2 | pub fn bit(n: T) -> T where T: std::ops::Shl + From { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub fn bit(n: T) -> T where T: std::ops::Shl + From { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 3 | T::from(1_u8) << n [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `picard-core` (lib) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "db342a6522cbf79bf3fbb083792a47770b5a346edcecb6b6bbe9bc2285ad80a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db342a6522cbf79bf3fbb083792a47770b5a346edcecb6b6bbe9bc2285ad80a1", kill_on_drop: false }` [INFO] [stdout] db342a6522cbf79bf3fbb083792a47770b5a346edcecb6b6bbe9bc2285ad80a1