[INFO] fetching crate phpup 0.1.8... [INFO] checking phpup-0.1.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate phpup 0.1.8 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate phpup 0.1.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate phpup 0.1.8 [INFO] finished tweaking crates.io crate phpup 0.1.8 [INFO] tweaked toml for crates.io crate phpup 0.1.8 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate phpup 0.1.8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b91ca98eb509fa16611ef78ec5f404a9e63c7df9926a77bb88cd683e5772d3fc [INFO] running `Command { std: "docker" "start" "-a" "b91ca98eb509fa16611ef78ec5f404a9e63c7df9926a77bb88cd683e5772d3fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b91ca98eb509fa16611ef78ec5f404a9e63c7df9926a77bb88cd683e5772d3fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b91ca98eb509fa16611ef78ec5f404a9e63c7df9926a77bb88cd683e5772d3fc", kill_on_drop: false }` [INFO] [stdout] b91ca98eb509fa16611ef78ec5f404a9e63c7df9926a77bb88cd683e5772d3fc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 078e3580de031d484abd6dd0375d8985e142cb947b3f51dcf8d1ae808fdf5bbb [INFO] running `Command { std: "docker" "start" "-a" "078e3580de031d484abd6dd0375d8985e142cb947b3f51dcf8d1ae808fdf5bbb", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling libc v0.2.113 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling serde_derive v1.0.133 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling serde v1.0.133 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling crc32fast v1.3.0 [INFO] [stderr] Compiling serde_json v1.0.75 [INFO] [stderr] Compiling rustversion v1.0.6 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Checking console v0.15.0 [INFO] [stderr] Checking xattr v0.2.2 [INFO] [stderr] Checking filetime v0.2.15 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking cpufeatures v0.2.1 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling unindent v0.1.7 [INFO] [stderr] Checking fastrand v1.6.0 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Compiling indoc v1.0.3 [INFO] [stderr] Checking tar v0.4.38 [INFO] [stderr] Checking sha2 v0.10.2 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking which v4.2.4 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking indicatif v0.16.2 [INFO] [stderr] Compiling darling_core v0.13.1 [INFO] [stderr] Compiling clap_derive v3.0.6 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Compiling darling_macro v0.13.1 [INFO] [stderr] Checking clap v3.0.10 [INFO] [stderr] Compiling darling v0.13.1 [INFO] [stderr] Compiling serde_with_macros v1.5.1 [INFO] [stderr] Checking clap_complete v3.0.6 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking serde_with v1.11.0 [INFO] [stderr] Checking phpup v0.1.8 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/install/make.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 47 | let (tx, rx) = channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | / std::process::Command::new(command) [INFO] [stdout] 51 | | .args(args) [INFO] [stdout] 52 | | .current_dir(current_dir) [INFO] [stdout] 53 | | .output(), [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/install/make.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 47 | let (tx, rx) = channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | / std::process::Command::new(command) [INFO] [stdout] 51 | | .args(args) [INFO] [stdout] 52 | | .current_dir(current_dir) [INFO] [stdout] 53 | | .output(), [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/use.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / #[clap( [INFO] [stdout] 17 | | name = "version | alias | system", [INFO] [stdout] 18 | | help = "installed version or alias name or system" [INFO] [stdout] 19 | | )] [INFO] [stdout] 20 | | request_version: Option, [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/curl.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 48 | let process = Command::new(command[0]) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok((process.stdout.unwrap(), process.stderr.unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/use.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | / #[clap( [INFO] [stdout] 17 | | name = "version | alias | system", [INFO] [stdout] 18 | | help = "installed version or alias name or system" [INFO] [stdout] 19 | | )] [INFO] [stdout] 20 | | request_version: Option, [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/curl.rs:57:8 [INFO] [stdout] | [INFO] [stdout] 48 | let process = Command::new(command[0]) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok((process.stdout.unwrap(), process.stderr.unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/release.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 109 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/release.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version/alias.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn link(&self, version: &Local, aliases_dir: impl AsRef) -> Result<(), Error> { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let mut file = fs::File::create(self.filepath(aliases_dir))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | file.write_all(version.to_string().as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version/file.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 67 | fn search_current(&self, current_dir: impl AsRef) -> Result, Error> { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let filepath = current_dir.as_ref().join(self.filename.as_path()); [INFO] [stdout] 69 | fs::read_to_string(&filepath) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/release.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 109 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/release.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version/alias.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn link(&self, version: &Local, aliases_dir: impl AsRef) -> Result<(), Error> { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let mut file = fs::File::create(self.filepath(aliases_dir))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | file.write_all(version.to_string().as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version/file.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 67 | fn search_current(&self, current_dir: impl AsRef) -> Result, Error> { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let filepath = current_dir.as_ref().join(self.filename.as_path()); [INFO] [stdout] 69 | fs::read_to_string(&filepath) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version/local.rs:46:33 [INFO] [stdout] | [INFO] [stdout] 46 | .and_then(|symlink| symlink.read_link().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/version/local.rs:46:33 [INFO] [stdout] | [INFO] [stdout] 46 | .and_then(|symlink| symlink.read_link().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `phpup` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `phpup` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "078e3580de031d484abd6dd0375d8985e142cb947b3f51dcf8d1ae808fdf5bbb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "078e3580de031d484abd6dd0375d8985e142cb947b3f51dcf8d1ae808fdf5bbb", kill_on_drop: false }` [INFO] [stdout] 078e3580de031d484abd6dd0375d8985e142cb947b3f51dcf8d1ae808fdf5bbb