[INFO] fetching crate photo-captioner 0.1.3... [INFO] checking photo-captioner-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate photo-captioner 0.1.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate photo-captioner 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate photo-captioner 0.1.3 [INFO] finished tweaking crates.io crate photo-captioner 0.1.3 [INFO] tweaked toml for crates.io crate photo-captioner 0.1.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate photo-captioner 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e4eb37673999de876abac973b4e151b4e4738c111e9f2c746785cf7cdd47def [INFO] running `Command { std: "docker" "start" "-a" "3e4eb37673999de876abac973b4e151b4e4738c111e9f2c746785cf7cdd47def", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e4eb37673999de876abac973b4e151b4e4738c111e9f2c746785cf7cdd47def", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e4eb37673999de876abac973b4e151b4e4738c111e9f2c746785cf7cdd47def", kill_on_drop: false }` [INFO] [stdout] 3e4eb37673999de876abac973b4e151b4e4738c111e9f2c746785cf7cdd47def [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 87c74078598802e7eecb2da978617c4c475ed3b4f8495466bfb112429a91576b [INFO] running `Command { std: "docker" "start" "-a" "87c74078598802e7eecb2da978617c4c475ed3b4f8495466bfb112429a91576b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling syn v1.0.8 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling fnv v1.0.6 [INFO] [stderr] Compiling strsim v0.9.2 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling ahash v0.6.3 [INFO] [stderr] Compiling cc v1.0.47 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Compiling serde v1.0.102 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking num-complex v0.3.1 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking array-macro v1.0.4 [INFO] [stderr] Compiling signal-hook v0.3.10 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Checking owning_ref v0.4.0 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking chrono v0.4.9 [INFO] [stderr] Checking regex-automata v0.1.8 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling ncurses v5.99.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking num v0.3.1 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking xi-unicode v0.3.0 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking csv-core v0.1.6 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling proc-macro-error v0.2.6 [INFO] [stderr] Compiling enum-map-derive v0.4.3 [INFO] [stderr] Compiling structopt-derive v0.3.4 [INFO] [stderr] Checking bstr v0.2.8 [INFO] [stderr] Checking enum-map v0.6.1 [INFO] [stderr] Checking csv v1.1.1 [INFO] [stderr] Checking structopt v0.3.4 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling wasmer_enumset_derive v0.5.0 [INFO] [stderr] Checking wasmer_enumset v1.0.1 [INFO] [stderr] Checking cursive_core v0.2.2 [INFO] [stderr] Checking cursive v0.16.3 [INFO] [stderr] Checking photo-captioner v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | / /// File extensions recognised as images that require captions. [INFO] [stdout] 67 | | #[structopt(short = "x", long = "extensions", default_value = "jpg, jpeg, png, heif")] [INFO] [stdout] 68 | | extensions: StringArray, [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | / /// File extensions recognised as images that require captions. [INFO] [stdout] 67 | | #[structopt(short = "x", long = "extensions", default_value = "jpg, jpeg, png, heif")] [INFO] [stdout] 68 | | extensions: StringArray, [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:237:65 [INFO] [stdout] | [INFO] [stdout] 237 | let image_file_name = String::from(record_ref.get_filename().clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:237:65 [INFO] [stdout] | [INFO] [stdout] 237 | let image_file_name = String::from(record_ref.get_filename().clone()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `photo-captioner` (bin "photo-captioner" test) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `photo-captioner` (bin "photo-captioner") due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "87c74078598802e7eecb2da978617c4c475ed3b4f8495466bfb112429a91576b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87c74078598802e7eecb2da978617c4c475ed3b4f8495466bfb112429a91576b", kill_on_drop: false }` [INFO] [stdout] 87c74078598802e7eecb2da978617c4c475ed3b4f8495466bfb112429a91576b