[INFO] fetching crate phorg 0.17.6... [INFO] checking phorg-0.17.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate phorg 0.17.6 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate phorg 0.17.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate phorg 0.17.6 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate phorg 0.17.6 [INFO] tweaked toml for crates.io crate phorg 0.17.6 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate phorg 0.17.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a6bb2d863c97f4948f441ed98e6b39de813f73666086dc8a79d1d90ab75793c5 [INFO] running `Command { std: "docker" "start" "-a" "a6bb2d863c97f4948f441ed98e6b39de813f73666086dc8a79d1d90ab75793c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a6bb2d863c97f4948f441ed98e6b39de813f73666086dc8a79d1d90ab75793c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a6bb2d863c97f4948f441ed98e6b39de813f73666086dc8a79d1d90ab75793c5", kill_on_drop: false }` [INFO] [stdout] a6bb2d863c97f4948f441ed98e6b39de813f73666086dc8a79d1d90ab75793c5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 84bf9609baa4daa695fcdd612e6ea0314e57687f826b3fa893191de02ce260f4 [INFO] running `Command { std: "docker" "start" "-a" "84bf9609baa4daa695fcdd612e6ea0314e57687f826b3fa893191de02ce260f4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling cc v1.0.101 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking object v0.36.0 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking mutate_once v0.1.1 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking kamadak-exif v0.5.5 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking uuid v1.9.1 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking cfb v0.7.3 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking infer v0.16.0 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking nom-exif v1.3.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking os_info v3.8.2 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking human-panic v2.0.1 [INFO] [stderr] Checking phorg v0.17.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files.rs:275:26 [INFO] [stdout] | [INFO] [stdout] 275 | .and_then(|data| exif::DateTime::from_ascii(data).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files.rs:355:5 [INFO] [stdout] | [INFO] [stdout] 354 | let mut bufreader = std::io::BufReader::new(file); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 355 | / exif::Reader::new() [INFO] [stdout] 356 | | .read_from_container(&mut bufreader) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files.rs:275:26 [INFO] [stdout] | [INFO] [stdout] 275 | .and_then(|data| exif::DateTime::from_ascii(data).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 31 | let mut file = std::fs::File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | / match self { [INFO] [stdout] 33 | | Hash::Sha1 => digest_sha1(&mut file), [INFO] [stdout] 34 | | Hash::Sha256 => digest_sha256(&mut file), [INFO] [stdout] 35 | | Hash::Md5 => digest_md5(&mut file), [INFO] [stdout] 36 | | Hash::Crc32 => digest_crc32(&mut file), [INFO] [stdout] 37 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files.rs:355:5 [INFO] [stdout] | [INFO] [stdout] 354 | let mut bufreader = std::io::BufReader::new(file); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 355 | / exif::Reader::new() [INFO] [stdout] 356 | | .read_from_container(&mut bufreader) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 31 | let mut file = std::fs::File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | / match self { [INFO] [stdout] 33 | | Hash::Sha1 => digest_sha1(&mut file), [INFO] [stdout] 34 | | Hash::Sha256 => digest_sha256(&mut file), [INFO] [stdout] 35 | | Hash::Md5 => digest_md5(&mut file), [INFO] [stdout] 36 | | Hash::Crc32 => digest_crc32(&mut file), [INFO] [stdout] 37 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `phorg` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `phorg` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "84bf9609baa4daa695fcdd612e6ea0314e57687f826b3fa893191de02ce260f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "84bf9609baa4daa695fcdd612e6ea0314e57687f826b3fa893191de02ce260f4", kill_on_drop: false }` [INFO] [stdout] 84bf9609baa4daa695fcdd612e6ea0314e57687f826b3fa893191de02ce260f4