[INFO] fetching crate phlow-ffi 2.0.0... [INFO] checking phlow-ffi-2.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate phlow-ffi 2.0.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate phlow-ffi 2.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate phlow-ffi 2.0.0 [INFO] finished tweaking crates.io crate phlow-ffi 2.0.0 [INFO] tweaked toml for crates.io crate phlow-ffi 2.0.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 44 packages to latest compatible versions [INFO] [stderr] Adding phlow v1.7.1 (latest: v2.0.1) [INFO] [stderr] Adding phlow-derive v1.4.0 (latest: v2.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ed066b32be0ccf73790c15ee7238e372714771d5676bf8783287765f9000ed06 [INFO] running `Command { std: "docker" "start" "-a" "ed066b32be0ccf73790c15ee7238e372714771d5676bf8783287765f9000ed06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ed066b32be0ccf73790c15ee7238e372714771d5676bf8783287765f9000ed06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed066b32be0ccf73790c15ee7238e372714771d5676bf8783287765f9000ed06", kill_on_drop: false }` [INFO] [stdout] ed066b32be0ccf73790c15ee7238e372714771d5676bf8783287765f9000ed06 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f2531587d624c7e3ad168778975684f7ce9dafe5a8e684e175338fe4ef625b18 [INFO] running `Command { std: "docker" "start" "-a" "f2531587d624c7e3ad168778975684f7ce9dafe5a8e684e175338fe4ef625b18", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling rust-format v0.3.4 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking widestring v1.1.0 [INFO] [stderr] Checking user-error v1.2.8 [INFO] [stderr] Compiling phlow-derive v1.4.0 [INFO] [stderr] Compiling phlow-derive v2.0.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking phlow v1.7.1 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking value-box v2.3.3 [INFO] [stderr] Checking string-box v1.1.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking phlow v2.0.1 [INFO] [stderr] Checking phlow-ffi v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phlow_object.rs:10:51 [INFO] [stdout] | [INFO] [stdout] 10 | .with_ref_ok(|phlow_object| ValueBox::new(phlow_object.phlow_view_methods())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phlow_object.rs:19:51 [INFO] [stdout] | [INFO] [stdout] 19 | .with_ref_ok(|phlow_object| ValueBox::new(phlow_object.phlow_views())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phlow_view.rs:11:25 [INFO] [stdout] | [INFO] [stdout] 9 | op: impl FnOnce(&T) -> Result, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | ) -> Result { [INFO] [stdout] 11 | phlow_view.with_ref(|phlow_view| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 12 | | downcast_view_ref::(&phlow_view) [INFO] [stdout] 13 | | .map_err(|error| error.into()) [INFO] [stdout] 14 | | .and_then(|view| op(view)) [INFO] [stdout] 15 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phlow_view.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 9 | op: impl FnOnce(&T) -> Result, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | / downcast_view_ref::(&phlow_view) [INFO] [stdout] 13 | | .map_err(|error| error.into()) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phlow_view.rs:14:23 [INFO] [stdout] | [INFO] [stdout] 9 | op: impl FnOnce(&T) -> Result, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | .and_then(|view| op(view)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phlow_view.rs:77:62 [INFO] [stdout] | [INFO] [stdout] 77 | .map(|view| view.map_or(std::ptr::null_mut(), |view| ValueBox::new(view).into_raw())) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phlow_view_method.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 43 | method.map_or(std::ptr::null_mut(), |method| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | ValueBox::new(method).into_raw() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `phlow-ffi` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phlow_object.rs:10:51 [INFO] [stdout] | [INFO] [stdout] 10 | .with_ref_ok(|phlow_object| ValueBox::new(phlow_object.phlow_view_methods())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phlow_object.rs:19:51 [INFO] [stdout] | [INFO] [stdout] 19 | .with_ref_ok(|phlow_object| ValueBox::new(phlow_object.phlow_views())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phlow_view.rs:11:25 [INFO] [stdout] | [INFO] [stdout] 9 | op: impl FnOnce(&T) -> Result, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | ) -> Result { [INFO] [stdout] 11 | phlow_view.with_ref(|phlow_view| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 12 | | downcast_view_ref::(&phlow_view) [INFO] [stdout] 13 | | .map_err(|error| error.into()) [INFO] [stdout] 14 | | .and_then(|view| op(view)) [INFO] [stdout] 15 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phlow_view.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 9 | op: impl FnOnce(&T) -> Result, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 12 | / downcast_view_ref::(&phlow_view) [INFO] [stdout] 13 | | .map_err(|error| error.into()) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phlow_view.rs:14:23 [INFO] [stdout] | [INFO] [stdout] 9 | op: impl FnOnce(&T) -> Result, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | .and_then(|view| op(view)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phlow_view.rs:77:62 [INFO] [stdout] | [INFO] [stdout] 77 | .map(|view| view.map_or(std::ptr::null_mut(), |view| ValueBox::new(view).into_raw())) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/phlow_view_method.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 43 | method.map_or(std::ptr::null_mut(), |method| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | ValueBox::new(method).into_raw() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `phlow-ffi` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "f2531587d624c7e3ad168778975684f7ce9dafe5a8e684e175338fe4ef625b18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f2531587d624c7e3ad168778975684f7ce9dafe5a8e684e175338fe4ef625b18", kill_on_drop: false }` [INFO] [stdout] f2531587d624c7e3ad168778975684f7ce9dafe5a8e684e175338fe4ef625b18