[INFO] fetching crate philec 0.1.4... [INFO] checking philec-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate philec 0.1.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate philec 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate philec 0.1.4 [INFO] finished tweaking crates.io crate philec 0.1.4 [INFO] tweaked toml for crates.io crate philec 0.1.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.6.10 (latest: v1.1.3) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding regex v0.2.11 (latest: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.5.6 (latest: v0.8.4) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding thread_local v0.3.6 (latest: v1.1.8) [INFO] [stderr] Adding ucd-util v0.1.10 (latest: v0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 02585c14d337351df2807caa770cebfaf07a7d1f8e3d1b5b21de377ab0d237e8 [INFO] running `Command { std: "docker" "start" "-a" "02585c14d337351df2807caa770cebfaf07a7d1f8e3d1b5b21de377ab0d237e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "02585c14d337351df2807caa770cebfaf07a7d1f8e3d1b5b21de377ab0d237e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "02585c14d337351df2807caa770cebfaf07a7d1f8e3d1b5b21de377ab0d237e8", kill_on_drop: false }` [INFO] [stdout] 02585c14d337351df2807caa770cebfaf07a7d1f8e3d1b5b21de377ab0d237e8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 656f248c2e24a1157a4f9fbb7e7129e418bb4fb31ab84596d87c29ba26924a55 [INFO] running `Command { std: "docker" "start" "-a" "656f248c2e24a1157a4f9fbb7e7129e418bb4fb31ab84596d87c29ba26924a55", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Checking heck v0.3.3 [INFO] [stderr] Checking phile v0.1.4 [INFO] [stderr] Checking philec v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/main.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | #![cfg_attr(feature = "cargo-clippy", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/main.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | #![cfg_attr(feature = "cargo-clippy", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/main.rs:342:12 [INFO] [stdout] | [INFO] [stdout] 342 | #[cfg_attr(feature = "cargo-clippy", allow(let_unit_value))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:164:40 [INFO] [stdout] | [INFO] [stdout] 164 | files: HashMap>>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 164 | files: HashMap>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/main.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | #![cfg_attr(feature = "cargo-clippy", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:178:69 [INFO] [stdout] | [INFO] [stdout] 178 | fn writer_with_name(&mut self, name: &str) -> Result>> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 178 | fn writer_with_name(&mut self, name: &str) -> Result>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/main.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | #![cfg_attr(feature = "cargo-clippy", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/main.rs:342:12 [INFO] [stdout] | [INFO] [stdout] 342 | #[cfg_attr(feature = "cargo-clippy", allow(let_unit_value))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:186:28 [INFO] [stdout] | [INFO] [stdout] 186 | let rc: Rc> = Rc::new(RefCell::new(file)); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 186 | let rc: Rc> = Rc::new(RefCell::new(file)); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:164:40 [INFO] [stdout] | [INFO] [stdout] 164 | files: HashMap>>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 164 | files: HashMap>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:178:69 [INFO] [stdout] | [INFO] [stdout] 178 | fn writer_with_name(&mut self, name: &str) -> Result>> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 178 | fn writer_with_name(&mut self, name: &str) -> Result>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:186:28 [INFO] [stdout] | [INFO] [stdout] 186 | let rc: Rc> = Rc::new(RefCell::new(file)); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 186 | let rc: Rc> = Rc::new(RefCell::new(file)); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `migration_script` is never read [INFO] [stdout] --> src/main.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 152 | struct ProgramArgs { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 156 | migration_script: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ProgramArgs` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:388:54 [INFO] [stdout] | [INFO] [stdout] 386 | let wp0 = RcCell::new(FileWriterProvider::new(&args)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | let wp1 = wp0.clone(); [INFO] [stdout] 388 | let result = philec_main(&args, &mut move |name| wp0.borrow_mut()?.writer_with_name(name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `philec` (bin "philec") due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `migration_script` is never read [INFO] [stdout] --> src/main.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 152 | struct ProgramArgs { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 156 | migration_script: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ProgramArgs` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:388:54 [INFO] [stdout] | [INFO] [stdout] 386 | let wp0 = RcCell::new(FileWriterProvider::new(&args)); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | let wp1 = wp0.clone(); [INFO] [stdout] 388 | let result = philec_main(&args, &mut move |name| wp0.borrow_mut()?.writer_with_name(name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `philec` (bin "philec" test) due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "656f248c2e24a1157a4f9fbb7e7129e418bb4fb31ab84596d87c29ba26924a55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "656f248c2e24a1157a4f9fbb7e7129e418bb4fb31ab84596d87c29ba26924a55", kill_on_drop: false }` [INFO] [stdout] 656f248c2e24a1157a4f9fbb7e7129e418bb4fb31ab84596d87c29ba26924a55