[INFO] fetching crate phi-accrual-detector 0.3.1... [INFO] checking phi-accrual-detector-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate phi-accrual-detector 0.3.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate phi-accrual-detector 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate phi-accrual-detector 0.3.1 [INFO] finished tweaking crates.io crate phi-accrual-detector 0.3.1 [INFO] tweaked toml for crates.io crate phi-accrual-detector 0.3.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate phi-accrual-detector 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 44ca453cf689be2a988dd00d34d11b74aee33c0910dc91b041b09eb2067f3219 [INFO] running `Command { std: "docker" "start" "-a" "44ca453cf689be2a988dd00d34d11b74aee33c0910dc91b041b09eb2067f3219", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "44ca453cf689be2a988dd00d34d11b74aee33c0910dc91b041b09eb2067f3219", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "44ca453cf689be2a988dd00d34d11b74aee33c0910dc91b041b09eb2067f3219", kill_on_drop: false }` [INFO] [stdout] 44ca453cf689be2a988dd00d34d11b74aee33c0910dc91b041b09eb2067f3219 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 17ccf877b8914132c9e59d891c697c03b16a0eef54e8ab2019e3a252ea788eb6 [INFO] running `Command { std: "docker" "start" "-a" "17ccf877b8914132c9e59d891c697c03b16a0eef54e8ab2019e3a252ea788eb6", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling zerocopy v0.8.0-alpha.6 [INFO] [stderr] Checking value-bag v1.8.1 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking async-task v4.7.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking waker-fn v1.1.1 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking event-listener v5.3.0 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking async-executor v1.11.0 [INFO] [stderr] Checking rand_core v0.9.0-alpha.1 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Checking event-listener-strategy v0.5.1 [INFO] [stderr] Checking rand_chacha v0.9.0-alpha.1 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Checking async-channel v2.2.1 [INFO] [stderr] Checking rand v0.9.0-alpha.1 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Checking chrono v0.4.37 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking polling v3.6.0 [INFO] [stderr] Checking async-io v2.3.2 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Checking phi-accrual-detector v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:173:117 [INFO] [stdout] | [INFO] [stdout] 173 | async fn mean_with_stats<'a>(&self, stats: Arc>) -> Result> { [INFO] [stdout] | _________________________________________-------------------------------------------_________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | | let mut mean: f64 = 0.; [INFO] [stdout] 175 | | let len = &stats.arrival_intervals.len(); [INFO] [stdout] 176 | | for v in &stats.arrival_intervals { [INFO] [stdout] ... | [INFO] [stdout] 179 | | Ok(mean) [INFO] [stdout] 180 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/lib.rs:264:13 [INFO] [stdout] | [INFO] [stdout] 264 | for i in 1..10 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `phi-accrual-detector` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:173:117 [INFO] [stdout] | [INFO] [stdout] 173 | async fn mean_with_stats<'a>(&self, stats: Arc>) -> Result> { [INFO] [stdout] | _________________________________________-------------------------------------------_________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | | let mut mean: f64 = 0.; [INFO] [stdout] 175 | | let len = &stats.arrival_intervals.len(); [INFO] [stdout] 176 | | for v in &stats.arrival_intervals { [INFO] [stdout] ... | [INFO] [stdout] 179 | | Ok(mean) [INFO] [stdout] 180 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/lib.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 245 | &stats.insert(curr_time.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 245 | let _ = &stats.insert(curr_time.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/lib.rs:250:13 [INFO] [stdout] | [INFO] [stdout] 250 | &stats.insert(arrived_at); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 250 | let _ = &stats.insert(arrived_at); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/lib.rs:285:13 [INFO] [stdout] | [INFO] [stdout] 285 | &detector.insert(arrived_at).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 285 | let _ = &detector.insert(arrived_at).await; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `phi-accrual-detector` (lib test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "17ccf877b8914132c9e59d891c697c03b16a0eef54e8ab2019e3a252ea788eb6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "17ccf877b8914132c9e59d891c697c03b16a0eef54e8ab2019e3a252ea788eb6", kill_on_drop: false }` [INFO] [stdout] 17ccf877b8914132c9e59d891c697c03b16a0eef54e8ab2019e3a252ea788eb6