[INFO] fetching crate phantasma 0.1.0... [INFO] checking phantasma-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate phantasma 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate phantasma 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate phantasma 0.1.0 [INFO] finished tweaking crates.io crate phantasma 0.1.0 [INFO] tweaked toml for crates.io crate phantasma 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate phantasma 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fcb597e92913d75742b696b4460dce7707684c75c56052153d20930ff2cc54c2 [INFO] running `Command { std: "docker" "start" "-a" "fcb597e92913d75742b696b4460dce7707684c75c56052153d20930ff2cc54c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fcb597e92913d75742b696b4460dce7707684c75c56052153d20930ff2cc54c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fcb597e92913d75742b696b4460dce7707684c75c56052153d20930ff2cc54c2", kill_on_drop: false }` [INFO] [stdout] fcb597e92913d75742b696b4460dce7707684c75c56052153d20930ff2cc54c2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0ddd516bfd5203d983b31ba73a76df7701fecc850a2f6ea42175ea9b66496eca [INFO] running `Command { std: "docker" "start" "-a" "0ddd516bfd5203d983b31ba73a76df7701fecc850a2f6ea42175ea9b66496eca", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling serde v1.0.201 [INFO] [stderr] Checking winnow v0.6.8 [INFO] [stderr] Compiling thiserror v1.0.60 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking lexopt v0.3.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.61 [INFO] [stderr] Compiling serde_derive v1.0.201 [INFO] [stderr] Compiling thiserror-impl v1.0.60 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_edit v0.22.12 [INFO] [stderr] Checking toml v0.8.12 [INFO] [stderr] Checking phantasma v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/master_server.rs:186:21 [INFO] [stdout] | [INFO] [stdout] 186 | let mut cur = Cursor::new(&mut buf[..]); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:59:49 [INFO] [stdout] | [INFO] [stdout] 59 | .map_err(|_| Error::Options("Failed to parse log level option".into()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:71:49 [INFO] [stdout] | [INFO] [stdout] 71 | .map_err(|_| Error::Options("Failed to parse IP address option".into()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:78:49 [INFO] [stdout] | [INFO] [stdout] 78 | .map_err(|_| Error::Options("Failed to parse port number option".into()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/master_server.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 88 | let sock = UdpSocket::bind(addr).map_err(Error::BindSocket)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | [INFO] [stdout] 90 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | sock, [INFO] [stdout] 92 | | start_time: Instant::now(), [INFO] [stdout] 93 | | challenges: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 98 | | timeout: cfg.server.timeout, [INFO] [stdout] 99 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/master_server.rs:223:15 [INFO] [stdout] | [INFO] [stdout] 222 | fn add_server(&mut self, addr: SocketAddrV4, server: Server) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | match self.servers.insert(addr, Entry::new(self.now(), server)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server_info.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 181 | let (challenge, info) = parser.parse()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | Ok((challenge, info, tail)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server_info.rs:235:12 [INFO] [stdout] | [INFO] [stdout] 197 | let mut info = ServerInfo::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | Ok((challenge, info)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `phantasma` (bin "phantasma") due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/master_server.rs:186:21 [INFO] [stdout] | [INFO] [stdout] 186 | let mut cur = Cursor::new(&mut buf[..]); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:59:49 [INFO] [stdout] | [INFO] [stdout] 59 | .map_err(|_| Error::Options("Failed to parse log level option".into()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:71:49 [INFO] [stdout] | [INFO] [stdout] 71 | .map_err(|_| Error::Options("Failed to parse IP address option".into()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:78:49 [INFO] [stdout] | [INFO] [stdout] 78 | .map_err(|_| Error::Options("Failed to parse port number option".into()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/master_server.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 88 | let sock = UdpSocket::bind(addr).map_err(Error::BindSocket)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | [INFO] [stdout] 90 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | sock, [INFO] [stdout] 92 | | start_time: Instant::now(), [INFO] [stdout] 93 | | challenges: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 98 | | timeout: cfg.server.timeout, [INFO] [stdout] 99 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/master_server.rs:223:15 [INFO] [stdout] | [INFO] [stdout] 222 | fn add_server(&mut self, addr: SocketAddrV4, server: Server) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | match self.servers.insert(addr, Entry::new(self.now(), server)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server_info.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 181 | let (challenge, info) = parser.parse()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | Ok((challenge, info, tail)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server_info.rs:235:12 [INFO] [stdout] | [INFO] [stdout] 197 | let mut info = ServerInfo::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | Ok((challenge, info)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `phantasma` (bin "phantasma" test) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "0ddd516bfd5203d983b31ba73a76df7701fecc850a2f6ea42175ea9b66496eca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ddd516bfd5203d983b31ba73a76df7701fecc850a2f6ea42175ea9b66496eca", kill_on_drop: false }` [INFO] [stdout] 0ddd516bfd5203d983b31ba73a76df7701fecc850a2f6ea42175ea9b66496eca