[INFO] fetching crate ph 0.8.3... [INFO] checking ph-0.8.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ph 0.8.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ph 0.8.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ph 0.8.3 [INFO] finished tweaking crates.io crate ph 0.8.3 [INFO] tweaked toml for crates.io crate ph 0.8.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 76 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3788f82bab51aad4dc1b61ba11e04b875950ca1e8e5cbdd310e7d49ee8d5dd96 [INFO] running `Command { std: "docker" "start" "-a" "3788f82bab51aad4dc1b61ba11e04b875950ca1e8e5cbdd310e7d49ee8d5dd96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3788f82bab51aad4dc1b61ba11e04b875950ca1e8e5cbdd310e7d49ee8d5dd96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3788f82bab51aad4dc1b61ba11e04b875950ca1e8e5cbdd310e7d49ee8d5dd96", kill_on_drop: false }` [INFO] [stdout] 3788f82bab51aad4dc1b61ba11e04b875950ca1e8e5cbdd310e7d49ee8d5dd96 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 31ba23338d08c1a420d1f176060ff0f80333271e2a4a0bc25271c6596573b0c1 [INFO] running `Command { std: "docker" "start" "-a" "31ba23338d08c1a420d1f176060ff0f80333271e2a4a0bc25271c6596573b0c1", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking dyn_size_of v0.4.2 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking binout v0.2.1 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking bitm v0.4.2 [INFO] [stderr] Checking wyhash v0.5.0 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking ph v0.8.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `no_branchless_bb` [INFO] [stdout] --> src/fmph/function.rs:133:11 [INFO] [stdout] | [INFO] [stdout] 133 | #[cfg(not(feature = "no_branchless_bb"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `fnv`, `sip13`, and `wyhash` [INFO] [stdout] = help: consider adding `no_branchless_bb` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `no_branchless_bb` [INFO] [stdout] --> src/fmph/function.rs:144:7 [INFO] [stdout] | [INFO] [stdout] 144 | #[cfg(feature = "no_branchless_bb")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `fnv`, `sip13`, and `wyhash` [INFO] [stdout] = help: consider adding `no_branchless_bb` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `no_branchless_bb` [INFO] [stdout] --> src/fmph/function.rs:164:11 [INFO] [stdout] | [INFO] [stdout] 164 | #[cfg(feature = "no_branchless_bb")] if collision[index].load(Relaxed) & mask != 0 { return; } // TODO opłaca się? bezpieczne? benchm... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `fnv`, `sip13`, and `wyhash` [INFO] [stdout] = help: consider adding `no_branchless_bb` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/function.rs:108:39 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn hash_lsize(hash_builder: S, relative_level_size: u16) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | Self { relative_level_size, ..Self::hash(hash_builder) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/function.rs:214:21 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn new(mut conf: BuildConf, keys: &impl KeySet) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | arrays: Vec::>::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/function.rs:481:12 [INFO] [stdout] | [INFO] [stdout] 475 | pub fn read_with_hasher(input: &mut dyn io::Read, hasher: S) -> io::Result [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 476 | { [INFO] [stdout] 477 | let level_sizes = VByte::read_array(input)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | let array_content_len = level_sizes.iter().map(|v|*v as usize).sum::(); [INFO] [stdout] 479 | let array_content = AsIs::read_n(input, array_content_len)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 480 | let (array_with_rank, _) = ArrayWithRank::build(array_content); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 481 | Ok(Self { array: array_with_rank, level_sizes, hash_builder: hasher }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/function.rs:529:40 [INFO] [stdout] | [INFO] [stdout] 523 | pub fn try_with_conf_stats(mut keys: KS, conf: BuildConf, stats: &mut BS) -> Option [INFO] [stdout] | ------------ ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 526 | let mut builder = Builder::new(conf, &keys); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 529 | (builder.input_size == 0).then(|| builder.finish()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/function.rs:540:9 [INFO] [stdout] | [INFO] [stdout] 537 | pub fn with_conf_stats(keys: impl KeySet, conf: BuildConf, stats: &mut BS) -> Self [INFO] [stdout] | -------------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 540 | Self::try_with_conf_stats(keys, conf, stats).expect("Constructing fmph::Function failed. Probably the input contains duplicate ke... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/goindexing.rs:106:46 [INFO] [stdout] | [INFO] [stdout] 103 | #[inline(always)] fn copy_group_if_better(&self, dst: &mut [u64], src: &[u64], group_index: usize, callback: CB) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | dst.conditionally_copy_fragment(src, |best, new| [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 107 | | if best.count_ones() < new.count_ones() { [INFO] [stdout] 108 | | callback(); [INFO] [stdout] 109 | | true [INFO] [stdout] 110 | | } else { false }, group_index, (*self).into()) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/goindexing.rs:323:12 [INFO] [stdout] | [INFO] [stdout] 323 | Ok((bits_per_group_seed, read_bits(input, number_of_seeds * bits_per_group_seed.0 as usize)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/goindexing.rs:360:12 [INFO] [stdout] | [INFO] [stdout] 360 | Ok((bits_per_group_seed, AsIs::read_n(input, number_of_seeds)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/goindexing.rs:436:12 [INFO] [stdout] | [INFO] [stdout] 436 | Ok((bits_per_group_seed, read_bits(input, number_of_seeds * Self::BITS as usize)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/gofunction.rs:300:21 [INFO] [stdout] | [INFO] [stdout] 295 | pub fn new(mut conf: GOBuildConf) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | arrays: Vec::>::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/gofunction.rs:301:26 [INFO] [stdout] | [INFO] [stdout] 295 | pub fn new(mut conf: GOBuildConf) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 301 | group_seeds: Vec::>::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/gofunction.rs:455:26 [INFO] [stdout] | [INFO] [stdout] 448 | pub fn finish(self) -> GOFunction { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 449 | let (array, _) = ArrayWithRank::build(self.arrays.concat().into_boxed_slice()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 450 | let group_seeds_concatenated = self.conf.goconf.bits_per_seed.concatenate_seed_vecs(&self.level_sizes, self.group_seeds); [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 455 | level_sizes: self.level_sizes.into_boxed_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/gofunction.rs:568:12 [INFO] [stdout] | [INFO] [stdout] 557 | pub fn read_with_hasher(input: &mut dyn io::Read, hash_builder: S) -> io::Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 560 | let level_size = VByte::read_array(input)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 563 | let array_content = read_bits(input, bits_per_group * number_of_groups)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 564 | let (array_with_rank, _) = ArrayWithRank::build(array_content); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 565 | [INFO] [stdout] 566 | let (bits_per_group_seed, group_seeds) = SS::read_seed_vec(input, number_of_groups)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 567 | [INFO] [stdout] 568 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 569 | | array: array_with_rank, [INFO] [stdout] 570 | | group_seeds, [INFO] [stdout] 571 | | level_sizes: level_size, [INFO] [stdout] ... | [INFO] [stdout] 576 | | }, [INFO] [stdout] 577 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/gofunction.rs:622:53 [INFO] [stdout] | [INFO] [stdout] 618 | pub fn try_with_conf_stats(mut keys: KS, conf: GOBuildConf, stats: &mut BS) -> Option [INFO] [stdout] | ------------ ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 621 | let mut builder = GOBuilder::new(conf); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 622 | builder.build_levels(&mut keys, stats).then(|| { [INFO] [stdout] | _____________________________________________________^ [INFO] [stdout] 623 | | drop(keys); [INFO] [stdout] 624 | | builder.finish() [INFO] [stdout] 625 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/gofunction.rs:634:9 [INFO] [stdout] | [INFO] [stdout] 631 | pub fn with_conf_stats(keys: KS, conf: GOBuildConf, stats: &mut BS) -> Self [INFO] [stdout] | -------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 634 | Self::try_with_conf_stats(keys, conf, stats).expect("Constructing fmph::GOFunction failed. Probably the input contains duplicate ... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/keyset.rs:38:43 [INFO] [stdout] | [INFO] [stdout] 38 | self.for_each_key(|k| result.push(map(k)), retained_hint); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/keyset.rs:152:35 [INFO] [stdout] | [INFO] [stdout] 151 | #[inline(always)] fn map_each_key(&self, map: M, _retained_hint: P) -> Vec [INFO] [stdout] | ------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | where M: FnMut(&K) -> R { self.iter().map(map).collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/keyset.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 160 | #[inline(always)] fn par_map_each_key(&self, map: M, _retained_hint: P) -> Vec [INFO] [stdout] | ------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | self.into_par_iter().map(map).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/keyset.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 242 | #[inline(always)] fn map_each_key(&self, map: M, _retained_hint: P) -> Vec [INFO] [stdout] | ------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | self.slice[0..self.len].into_iter().map(map).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/keyset.rs:251:9 [INFO] [stdout] | [INFO] [stdout] 248 | #[inline(always)] fn par_map_each_key(&self, map: M, _retained_hint: P) -> Vec [INFO] [stdout] | ------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | self.slice[0..self.len].into_par_iter().map(map).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/keyset.rs:777:9 [INFO] [stdout] | [INFO] [stdout] 774 | #[inline(always)] fn for_each_key(&self, mut f: F, retained_hint: P) [INFO] [stdout] | -------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 777 | self.keys.iter().filter(retained_hint).for_each(|k| f(&k)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/keyset.rs:818:9 [INFO] [stdout] | [INFO] [stdout] 815 | #[inline] fn into_vec

(self, retained_hint: P) -> Vec [INFO] [stdout] | ---- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 818 | self.keys.iter().filter(retained_hint).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/keyset.rs:872:19 [INFO] [stdout] | [INFO] [stdout] 871 | pub fn dynamic(keys: PI, clone_threshold: usize) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 872 | Self::new(DynamicKeySet::new(keys), clone_threshold) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fmph/keyset.rs:891:19 [INFO] [stdout] | [INFO] [stdout] 890 | pub fn dynamic_with_len(keys: PI, len: usize, clone_threshold: usize) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 891 | Self::new(DynamicKeySet::with_len(keys, len), clone_threshold) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 24 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ph` (lib) due to 25 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "31ba23338d08c1a420d1f176060ff0f80333271e2a4a0bc25271c6596573b0c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31ba23338d08c1a420d1f176060ff0f80333271e2a4a0bc25271c6596573b0c1", kill_on_drop: false }` [INFO] [stdout] 31ba23338d08c1a420d1f176060ff0f80333271e2a4a0bc25271c6596573b0c1