[INFO] fetching crate pgrx-bindgen 0.12.1... [INFO] checking pgrx-bindgen-0.12.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pgrx-bindgen 0.12.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate pgrx-bindgen 0.12.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pgrx-bindgen 0.12.1 [INFO] finished tweaking crates.io crate pgrx-bindgen 0.12.1 [INFO] tweaked toml for crates.io crate pgrx-bindgen 0.12.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 76 packages to latest compatible versions [INFO] [stderr] Adding bindgen v0.69.4 (latest: v0.70.1) [INFO] [stderr] Adding cargo_toml v0.19.2 (latest: v0.20.4) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding supports-color v2.1.0 (latest: v3.0.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e91330d9e9d5db0bb80a502cfd483a0693fada5100665896326d6ce4f59702fb [INFO] running `Command { std: "docker" "start" "-a" "e91330d9e9d5db0bb80a502cfd483a0693fada5100665896326d6ce4f59702fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e91330d9e9d5db0bb80a502cfd483a0693fada5100665896326d6ce4f59702fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e91330d9e9d5db0bb80a502cfd483a0693fada5100665896326d6ce4f59702fb", kill_on_drop: false }` [INFO] [stdout] e91330d9e9d5db0bb80a502cfd483a0693fada5100665896326d6ce4f59702fb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e558899c71f8dd3e5111f4b38a514283953bf692213220ff1169269646dabb5c [INFO] running `Command { std: "docker" "start" "-a" "e558899c71f8dd3e5111f4b38a514283953bf692213220ff1169269646dabb5c", kill_on_drop: false }` [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking is_ci v1.2.0 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking libloading v0.8.5 [INFO] [stderr] Compiling bindgen v0.69.4 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking supports-color v2.1.0 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking owo-colors v4.0.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking pathsearch v0.2.0 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking cexpr v0.6.0 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking cargo_toml v0.19.2 [INFO] [stderr] Checking pgrx-pg-config v0.12.1 [INFO] [stderr] Checking pgrx-bindgen v0.12.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/build.rs:166:23 [INFO] [stdout] | [INFO] [stdout] 166 | .map(|c| (c.major_version().expect("invalid major version"), c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/build.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 229 | let threads = pg_configs [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | let results = threads [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | results.into_iter().try_for_each(|r| r) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/build.rs:241:27 [INFO] [stdout] | [INFO] [stdout] 241 | .map(|thread| thread.join().expect("thread panicked while generating bindings")) [INFO] [stdout] | ------ ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/build.rs:743:5 [INFO] [stdout] | [INFO] [stdout] 743 | syn::parse_file(bindings.as_str()).wrap_err_with(|| "failed to parse generated bindings") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/build.rs:817:5 [INFO] [stdout] | [INFO] [stdout] 816 | fn add_blocklists(bind: bindgen::Builder) -> bindgen::Builder { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 817 | / bind.blocklist_type("Datum") // manually wrapping datum for correctness [INFO] [stdout] 818 | | .blocklist_type("Oid") // "Oid" is not just any u32 [INFO] [stdout] 819 | | .blocklist_function("varsize_any") // pgrx converts the VARSIZE_ANY macro, so we don't want to also have this function, which is ... [INFO] [stdout] 820 | | .blocklist_function("(?:raw_)?(?:expression|query|query_or_expression)_tree_walker") [INFO] [stdout] ... | [INFO] [stdout] 839 | | // and are not useful for us. [INFO] [stdout] 840 | | .blocklist_function("(?:sigstack|sigreturn|siggetmask|gets|vfork|te?mpnam(?:_r)?|mktemp)") [INFO] [stdout] | |__________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/build.rs:846:5 [INFO] [stdout] | [INFO] [stdout] 845 | fn add_derives(bind: bindgen::Builder) -> bindgen::Builder { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 846 | / bind.derive_debug(true) [INFO] [stdout] 847 | | .derive_copy(true) [INFO] [stdout] 848 | | .derive_default(true) [INFO] [stdout] 849 | | .derive_eq(false) [INFO] [stdout] 850 | | .derive_partialeq(false) [INFO] [stdout] 851 | | .derive_hash(false) [INFO] [stdout] 852 | | .derive_ord(false) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pgrx-bindgen` (lib) due to 7 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/build.rs:166:23 [INFO] [stdout] | [INFO] [stdout] 166 | .map(|c| (c.major_version().expect("invalid major version"), c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/build.rs:243:9 [INFO] [stdout] | [INFO] [stdout] 229 | let threads = pg_configs [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | let results = threads [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | results.into_iter().try_for_each(|r| r) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/build.rs:241:27 [INFO] [stdout] | [INFO] [stdout] 241 | .map(|thread| thread.join().expect("thread panicked while generating bindings")) [INFO] [stdout] | ------ ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/build.rs:743:5 [INFO] [stdout] | [INFO] [stdout] 743 | syn::parse_file(bindings.as_str()).wrap_err_with(|| "failed to parse generated bindings") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/build.rs:817:5 [INFO] [stdout] | [INFO] [stdout] 816 | fn add_blocklists(bind: bindgen::Builder) -> bindgen::Builder { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 817 | / bind.blocklist_type("Datum") // manually wrapping datum for correctness [INFO] [stdout] 818 | | .blocklist_type("Oid") // "Oid" is not just any u32 [INFO] [stdout] 819 | | .blocklist_function("varsize_any") // pgrx converts the VARSIZE_ANY macro, so we don't want to also have this function, which is ... [INFO] [stdout] 820 | | .blocklist_function("(?:raw_)?(?:expression|query|query_or_expression)_tree_walker") [INFO] [stdout] ... | [INFO] [stdout] 839 | | // and are not useful for us. [INFO] [stdout] 840 | | .blocklist_function("(?:sigstack|sigreturn|siggetmask|gets|vfork|te?mpnam(?:_r)?|mktemp)") [INFO] [stdout] | |__________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/build.rs:846:5 [INFO] [stdout] | [INFO] [stdout] 845 | fn add_derives(bind: bindgen::Builder) -> bindgen::Builder { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 846 | / bind.derive_debug(true) [INFO] [stdout] 847 | | .derive_copy(true) [INFO] [stdout] 848 | | .derive_default(true) [INFO] [stdout] 849 | | .derive_eq(false) [INFO] [stdout] 850 | | .derive_partialeq(false) [INFO] [stdout] 851 | | .derive_hash(false) [INFO] [stdout] 852 | | .derive_ord(false) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pgrx-bindgen` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "e558899c71f8dd3e5111f4b38a514283953bf692213220ff1169269646dabb5c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e558899c71f8dd3e5111f4b38a514283953bf692213220ff1169269646dabb5c", kill_on_drop: false }` [INFO] [stdout] e558899c71f8dd3e5111f4b38a514283953bf692213220ff1169269646dabb5c