[INFO] fetching crate pgident 0.0.3... [INFO] checking pgident-0.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pgident 0.0.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate pgident 0.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pgident 0.0.3 [INFO] finished tweaking crates.io crate pgident 0.0.3 [INFO] tweaked toml for crates.io crate pgident 0.0.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7b0e7ebad34737285ddd7c486fe3c7a73e85eeeb5ad62329cf0eacab66c9df0d [INFO] running `Command { std: "docker" "start" "-a" "7b0e7ebad34737285ddd7c486fe3c7a73e85eeeb5ad62329cf0eacab66c9df0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7b0e7ebad34737285ddd7c486fe3c7a73e85eeeb5ad62329cf0eacab66c9df0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b0e7ebad34737285ddd7c486fe3c7a73e85eeeb5ad62329cf0eacab66c9df0d", kill_on_drop: false }` [INFO] [stdout] 7b0e7ebad34737285ddd7c486fe3c7a73e85eeeb5ad62329cf0eacab66c9df0d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c5ec0c49e7af57c7a55fba53d5a8448a39d0dce3b35a7b9db201ad1a64aa35e5 [INFO] running `Command { std: "docker" "start" "-a" "c5ec0c49e7af57c7a55fba53d5a8448a39d0dce3b35a7b9db201ad1a64aa35e5", kill_on_drop: false }` [INFO] [stderr] Checking pgident v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/name.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(id: T) -> Result { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | Ok(Self::Id(PgIdent::new(id)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/name.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new_ns(ns: U) -> Result [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | let mut ids = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Ok(Self::Namespaced(ids)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/name.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn with_name(&self, name_part: T) -> Result, IdentError> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let name_part = PgIdent::new(name_part)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | Self::Id(_) => Self::Id(name_part), [INFO] [stdout] 47 | | Self::IdPair(schema, _) => Self::IdPair(schema.clone().into(), name_part), [INFO] [stdout] 48 | | Self::Namespaced(ids) => { [INFO] [stdout] ... | [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pgident` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/name.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(id: T) -> Result { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | Ok(Self::Id(PgIdent::new(id)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/name.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new_ns(ns: U) -> Result [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | let mut ids = Vec::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | Ok(Self::Namespaced(ids)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/name.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn with_name(&self, name_part: T) -> Result, IdentError> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let name_part = PgIdent::new(name_part)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 46 | | Self::Id(_) => Self::Id(name_part), [INFO] [stdout] 47 | | Self::IdPair(schema, _) => Self::IdPair(schema.clone().into(), name_part), [INFO] [stdout] 48 | | Self::Namespaced(ids) => { [INFO] [stdout] ... | [INFO] [stdout] 52 | | } [INFO] [stdout] 53 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pgident` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "c5ec0c49e7af57c7a55fba53d5a8448a39d0dce3b35a7b9db201ad1a64aa35e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5ec0c49e7af57c7a55fba53d5a8448a39d0dce3b35a7b9db201ad1a64aa35e5", kill_on_drop: false }` [INFO] [stdout] c5ec0c49e7af57c7a55fba53d5a8448a39d0dce3b35a7b9db201ad1a64aa35e5