[INFO] fetching crate pg_task 0.2.0... [INFO] checking pg_task-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pg_task 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate pg_task 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pg_task 0.2.0 [INFO] finished tweaking crates.io crate pg_task 0.2.0 [INFO] tweaked toml for crates.io crate pg_task 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate pg_task 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 74327a466b0af13236d6b8cc08e4e55f72afcf06e24063298c7843d2e2bd36b7 [INFO] running `Command { std: "docker" "start" "-a" "74327a466b0af13236d6b8cc08e4e55f72afcf06e24063298c7843d2e2bd36b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "74327a466b0af13236d6b8cc08e4e55f72afcf06e24063298c7843d2e2bd36b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "74327a466b0af13236d6b8cc08e4e55f72afcf06e24063298c7843d2e2bd36b7", kill_on_drop: false }` [INFO] [stdout] 74327a466b0af13236d6b8cc08e4e55f72afcf06e24063298c7843d2e2bd36b7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2428a804064a40577f99ef689319ecd470f2815324b6588ad39cba1d0090f00a [INFO] running `Command { std: "docker" "start" "-a" "2428a804064a40577f99ef689319ecd470f2815324b6588ad39cba1d0090f00a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling cc v1.0.101 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling tinyvec_macros v0.1.1 [INFO] [stderr] Compiling subtle v2.6.1 [INFO] [stderr] Compiling pin-project-lite v0.2.14 [INFO] [stderr] Compiling serde_json v1.0.118 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling zerocopy v0.7.34 [INFO] [stderr] Compiling untrusted v0.9.0 [INFO] [stderr] Compiling futures-core v0.3.30 [INFO] [stderr] Compiling tinyvec v1.6.1 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling allocator-api2 v0.2.18 [INFO] [stderr] Compiling unicode-bidi v0.3.15 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling bytes v1.6.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling futures-sink v0.3.30 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling percent-encoding v2.3.1 [INFO] [stderr] Compiling form_urlencoded v1.2.1 [INFO] [stderr] Compiling unicode-normalization v0.1.23 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling tracing-core v0.1.32 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling log v0.4.21 [INFO] [stderr] Compiling unicode_categories v0.1.1 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling mio v0.8.11 [INFO] [stderr] Compiling socket2 v0.5.7 [INFO] [stderr] Compiling crc-catalog v2.4.0 [INFO] [stderr] Compiling futures-task v0.3.30 [INFO] [stderr] Compiling pin-utils v0.1.0 [INFO] [stderr] Compiling idna v0.5.0 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling iana-time-zone v0.1.60 [INFO] [stderr] Compiling base64 v0.21.7 [INFO] [stderr] Compiling ppv-lite86 v0.2.17 [INFO] [stderr] Compiling tokio v1.38.0 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling futures-io v0.3.30 [INFO] [stderr] Compiling parking v2.2.0 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling event-listener v5.3.1 [INFO] [stderr] Compiling futures-util v0.3.30 [INFO] [stderr] Compiling url v2.5.2 [INFO] [stderr] Compiling rustls-pemfile v1.0.4 [INFO] [stderr] Compiling chrono v0.4.38 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Compiling crc v3.2.1 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Compiling hashlink v0.9.1 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling futures-channel v0.3.30 [INFO] [stderr] Compiling crossbeam-queue v0.3.11 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling unicode-properties v0.1.1 [INFO] [stderr] Compiling hashbrown v0.12.3 [INFO] [stderr] Compiling webpki-roots v0.25.4 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Compiling uuid v1.9.1 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Compiling hkdf v0.12.4 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Compiling fastrand v2.1.0 [INFO] [stderr] Compiling sqlformat v0.2.4 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling whoami v1.5.1 [INFO] [stderr] Compiling fsio v0.1.3 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Compiling envmnt v0.8.4 [INFO] [stderr] Compiling ci_info v0.10.2 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling nias v0.5.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking code-path v0.3.1 [INFO] [stderr] Checking source-chain v0.1.0 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Compiling tempfile v3.10.1 [INFO] [stderr] Compiling tokio-stream v0.1.15 [INFO] [stderr] Compiling sct v0.7.1 [INFO] [stderr] Compiling rustls-webpki v0.101.7 [INFO] [stderr] Compiling tracing v0.1.40 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking futures-intrusive v0.5.0 [INFO] [stderr] Compiling sqlx-core v0.8.0 [INFO] [stderr] Compiling rusty-hook v0.11.2 [INFO] [stderr] Compiling sqlx-postgres v0.8.0 [INFO] [stderr] Compiling sqlx-macros-core v0.8.0 [INFO] [stderr] Compiling sqlx-macros v0.8.0 [INFO] [stderr] Checking sqlx v0.8.0 [INFO] [stderr] Checking pg_task v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/next_step.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn now(step: impl Into) -> StepResult { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(Self::Now(step.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/next_step.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn delay(step: impl Into, delay: Duration) -> StepResult { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(Self::Delayed(step.into(), delay)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits.rs:39:81 [INFO] [stdout] | [INFO] [stdout] 39 | async fn enqueue<'e>(&self, db: impl PgExecutor<'e>) -> crate::Result { [INFO] [stdout] | _________________________________-----------------------_________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | | self.schedule(db, Utc::now()).await [INFO] [stdout] 41 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits.rs:44:96 [INFO] [stdout] | [INFO] [stdout] 44 | async fn delay<'e>(&self, db: impl PgExecutor<'e>, delay: Duration) -> crate::Result { [INFO] [stdout] | _______________________________-----------------------__________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | | let delay = [INFO] [stdout] 46 | | chrono::Duration::from_std(delay).unwrap_or_else(|_| chrono::Duration::max_value()); [INFO] [stdout] 47 | | self.schedule(db, Utc::now() + delay).await [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits.rs:55:30 [INFO] [stdout] | [INFO] [stdout] 53 | db: impl PgExecutor<'e>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | at: DateTime, [INFO] [stdout] 55 | ) -> crate::Result { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 56 | | let step = serde_json::to_string(self) [INFO] [stdout] 57 | | .map_err(|e| Error::SerializeStep(e, format!("{self:?}")))?; [INFO] [stdout] 58 | | sqlx::query!( [INFO] [stdout] ... | [INFO] [stdout] 66 | | .map_err(Error::AddTask) [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pg_task` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/next_step.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn now(step: impl Into) -> StepResult { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | Ok(Self::Now(step.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/next_step.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn delay(step: impl Into, delay: Duration) -> StepResult { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(Self::Delayed(step.into(), delay)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits.rs:39:81 [INFO] [stdout] | [INFO] [stdout] 39 | async fn enqueue<'e>(&self, db: impl PgExecutor<'e>) -> crate::Result { [INFO] [stdout] | _________________________________-----------------------_________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | | self.schedule(db, Utc::now()).await [INFO] [stdout] 41 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits.rs:44:96 [INFO] [stdout] | [INFO] [stdout] 44 | async fn delay<'e>(&self, db: impl PgExecutor<'e>, delay: Duration) -> crate::Result { [INFO] [stdout] | _______________________________-----------------------__________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | | let delay = [INFO] [stdout] 46 | | chrono::Duration::from_std(delay).unwrap_or_else(|_| chrono::Duration::max_value()); [INFO] [stdout] 47 | | self.schedule(db, Utc::now() + delay).await [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/traits.rs:55:30 [INFO] [stdout] | [INFO] [stdout] 53 | db: impl PgExecutor<'e>, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | at: DateTime, [INFO] [stdout] 55 | ) -> crate::Result { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 56 | | let step = serde_json::to_string(self) [INFO] [stdout] 57 | | .map_err(|e| Error::SerializeStep(e, format!("{self:?}")))?; [INFO] [stdout] 58 | | sqlx::query!( [INFO] [stdout] ... | [INFO] [stdout] 66 | | .map_err(Error::AddTask) [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pg_task` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "2428a804064a40577f99ef689319ecd470f2815324b6588ad39cba1d0090f00a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2428a804064a40577f99ef689319ecd470f2815324b6588ad39cba1d0090f00a", kill_on_drop: false }` [INFO] [stdout] 2428a804064a40577f99ef689319ecd470f2815324b6588ad39cba1d0090f00a